Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Apr 2023 22:53:23 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Changbin Du <changbin.du@huawei.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hui Wang <hw.huiwang@huawei.com>
Subject: Re: [PATCH] perf: unwind: suppress massive unsupported target
 platform errors
Message-ID: <ZEx4k+tl6HPH3fsx@kernel.org>
References: <20230426032246.3608596-1-changbin.du@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230426032246.3608596-1-changbin.du@huawei.com>
Precedence: bulk

Em Wed, Apr 26, 2023 at 11:22:46AM +0800, Changbin Du escreveu:
> When cross-analyzing perf data recorded on an another platform, massive
> unsupported target platform errors are printed. So let's show this message
> as warning and only once.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Changbin Du <changbin.du@huawei.com>
> ---
>  tools/perf/util/unwind-libunwind.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
> index 509c287ee762..e95adbedf6ed 100644
> --- a/tools/perf/util/unwind-libunwind.c
> +++ b/tools/perf/util/unwind-libunwind.c
> @@ -54,7 +54,7 @@ int unwind__prepare_access(struct maps *maps, struct map *map, bool *initialized
>  	}
>  
>  	if (!ops) {
> -		pr_err("unwind: target platform=%s is not supported\n", arch);
> +		pr_warning_once("unwind: target platform=%s is not supported\n", arch);
>  		return 0;
>  	}
>  out_register:
> -- 
> 2.25.1
> 

-- 

- Arnaldo