Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Apr 2023 22:23:23 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Palmer Dabbelt <palmer@dabbelt.com>
Cc:     p4ranlee@gmail.com, jolsa@kernel.org, namhyung@kernel.org,
        irogers@google.com, Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, acme@redhat.com, anton@ozlabs.org,
        dja@axtens.net, mpe@ellerman.id.au,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] perf tools riscv: Add support for riscv
 lookup_binutils_path
Message-ID: <ZExxi7KAW7W/OSwa@kernel.org>
References: <20230315051500.13064-1-p4ranlee@gmail.com>
 <mhng-534349ae-0594-455c-bc27-da0d8a70d0be@palmer-ri-x1c9>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <mhng-534349ae-0594-455c-bc27-da0d8a70d0be@palmer-ri-x1c9>
Precedence: bulk

Em Tue, Apr 18, 2023 at 08:41:21PM -0700, Palmer Dabbelt escreveu:
> On Tue, 14 Mar 2023 22:15:01 PDT (-0700), p4ranlee@gmail.com wrote:
> > Add RISC-V binutils path on lookup triplets.
> > 
> > Signed-off-by: Paran Lee <p4ranlee@gmail.com>
> > ---
> >  tools/perf/arch/common.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> > index 59dd875fd5e4..e80d4d22cabf 100644
> > --- a/tools/perf/arch/common.c
> > +++ b/tools/perf/arch/common.c
> > @@ -43,6 +43,20 @@ const char *const powerpc_triplets[] = {
> >  	NULL
> >  };
> > 
> > +const char *const riscv32_triplets[] = {
> > +	"riscv32-unknown-linux-gnu-",
> > +	"riscv32-linux-android-",
> > +	"riscv32-linux-gnu-",
> > +	NULL
> > +};
> > +
> > +const char *const riscv64_triplets[] = {
> > +	"riscv64-unknown-linux-gnu-",
> > +	"riscv64-linux-android-",
> > +	"riscv64-linux-gnu-",
> > +	NULL
> > +};
> > +
> >  const char *const s390_triplets[] = {
> >  	"s390-ibm-linux-",
> >  	"s390x-linux-gnu-",
> > @@ -166,6 +180,10 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
> >  		path_list = arm64_triplets;
> >  	else if (!strcmp(arch, "powerpc"))
> >  		path_list = powerpc_triplets;
> > +	else if (!strcmp(arch, "riscv32"))
> > +		path_list = riscv32_triplets;
> > +	else if (!strcmp(arch, "riscv64"))
> > +		path_list = riscv64_triplets;
> >  	else if (!strcmp(arch, "sh"))
> >  		path_list = sh_triplets;
> >  	else if (!strcmp(arch, "s390"))
> 
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Thanks, applied.

- Arnaldo