Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbXJAO1x (ORCPT ); Mon, 1 Oct 2007 10:27:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752075AbXJAO1q (ORCPT ); Mon, 1 Oct 2007 10:27:46 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:52115 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbXJAO1p (ORCPT ); Mon, 1 Oct 2007 10:27:45 -0400 Date: Mon, 1 Oct 2007 09:27:41 -0500 From: "Serge E. Hallyn" To: Pavel Emelyanov Cc: sukadev@us.ibm.com, "Serge E. Hallyn" , Linux Kernel Mailing List , "Eric W. Biederman" , Linux Containers Subject: Re: [PATCH 1/5] The config option itself Message-ID: <20071001142741.GC30599@sergelap.austin.ibm.com> References: <46FA7D4D.8040808@openvz.org> <46FA7E20.80207@openvz.org> <20070926163432.GA23435@sergelap.austin.ibm.com> <20070926170621.GB23435@sergelap.austin.ibm.com> <20070927023024.GA24004@us.ibm.com> <46FB682B.2000100@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46FB682B.2000100@openvz.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3878 Lines: 95 Quoting Pavel Emelyanov (xemul@openvz.org): > sukadev@us.ibm.com wrote: > > Serge E. Hallyn [serue@us.ibm.com] wrote: > > | Quoting Serge E. Hallyn (serue@us.ibm.com): > > | > Quoting Pavel Emelyanov (xemul@openvz.org): > > | > > The option is called NAMESPACES. It can be selectable only > > | > > if EMBEDDED is chosen (this was Eric's requisition). When > > | > > the EMBEDDED is off namespaces will be on automatically. > > | > > > > | > > One more option (NAMESPACES_EXPERIMENTAL) was added by > > | > > Serge's request to move there all the namespaces that are > > | > > not finished yet. Currently only the user and the network > > | > > namespaces are such. > > | > > > > | > > Signed-off-by: Pavel Emelyanov > > | > > > > | > > --- > > | > > > > | > > diff --git a/init/Kconfig b/init/Kconfig > > | > > index 684ccfb..05a71d7 100644 > > | > > --- a/init/Kconfig > > | > > +++ b/init/Kconfig > > | > > @@ -369,6 +360,23 @@ config RELAY > > | > > > > | > > If unsure, say N. > > | > > > > | > > +config NAMESPACES > > | > > + bool "The namespaces support" if EMBEDDED > > | > > + default !EMBEDDED > > | > > + help > > | > > + Provides the way to make tasks work with different objects using > > | > > + the same id. For example same IPC id may refer to different objects > > | > > + or same user id or pid may refer to different tasks when used in > > | > > + different namespaces. > > | > > + > > | > > +config NAMESPACES_EXPERIMENTAL > > | > > + bool "Add the experimantal namespaces support" if EMBEDDED > > | > > > | > Hi Pavel, > > | > > > | > Overall this patchset looks good. > > | > > > | > However the NAMESPACES_EXPERIMENTAL option should not have the > > | > 'if EMBEDDED', right? This is about EXPERIMENTAL, not about > > | > EMBEDDED, unlike the plain NAMESPACES option. > > | > > > | > -serge > > | > > | Actually that doesn't seem to work either. Even though > > | SECURITY_NAMESPACES=y, the config system seems to infer that > > | since NAMESPACES is not user-selectable, NAMESPACES_EXPERIMENTAL > > | shouldn't be either. So we end up with NAMESPACES_EXPERIMENTAL > > | being on and not un-selectable if !EMBEDDED. > > > > Yes. Given that NAMESPACES depends on EMBEDDED, NAMESPACES_EXPERIMENTAL > > can simply depend on NAMESPACES and EXPERIMENTAL with a default of N. > > Nope. The intention is that the NAMESPACES and NAMESPACES_EXPERIMENTAL No, Eric wanted NAMESPACES to only be unselecteable if EMBEDDED=y, but NAMESPACES_EXPERIMENTAL should always be unselectable. If current config logic can't do that then we should forget about the EMBEDDED requirement altogether. The rest of this patchset looks great. Thanks, Pavel. -serge > must not be selectable if EMBEDDED=n, but if we make NS_EXPERIMENTAL > depend on NAMESPACES only we'll have to make a choice in !EMBEDDED. > > > BTW, does the position of 'config NAMESPACES' in init/Kconfig file > > matter ? If it is dependent on EMBEDDED, should it not come later > > in the file, after 'config EMBEDDED' ? > > > > | > > | > > + depends on NAMESPACES && EXPERIMENTAL > > | > > + default !EMBEDDED > > | > > + help > > | > > + Also include the support for the namespaces that are not fnished > > | > > + or well developed yet > > | > > + > > | > > config BLK_DEV_INITRD > > | > > bool "Initial RAM filesystem and RAM disk (initramfs/initrd) support" > > | > > depends on BROKEN || !FRV > > | _______________________________________________ > > | Containers mailing list > > | Containers@lists.linux-foundation.org > > | https://lists.linux-foundation.org/mailman/listinfo/containers > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/