Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp3059799rwr; Fri, 28 Apr 2023 23:15:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ65a8hHyO4mX0tsinRreq5ILIcjVFjONTY/MAlo+ffl/uIPLAhxC9QAMDaCGtFzb8t52/XR X-Received: by 2002:a05:6a20:440d:b0:f8:ea21:7c4f with SMTP id ce13-20020a056a20440d00b000f8ea217c4fmr8875122pzb.5.1682748941452; Fri, 28 Apr 2023 23:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682748941; cv=none; d=google.com; s=arc-20160816; b=YLwEoVBTCczr0GuqxLZ6dY8qO6eaRWCKnZdOtgI79fFqhUAyYXs/qQGALdTAi7jFcI poYqpqcTPgR9u92StOhDT8VRA31KEQj27pjNviPjfV4o5LQoWRkK5dPil5Za1PQcWW62 304iyEnn+K6OXqULz0a5m5frsfgsl7Gz3nBbmibIffxTf1kBqH0TGbG7TYspxciMC8M/ jwzjyxeHAuxq6lA7qKm7YtkWUd+mA1+X8LLZr8GgBBVGVejGkMmeho2LXan5tnqyJtJQ hQDYrTk4TMSbgL8J8V4qpK7JiyKT+iFglpg8+1FLKXAu7Eve5F5rVcXa9B5/FJPH8i/G Ffpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=udIESTQJWghJ0eXfw1zjkQa1ohgrnaNqFMimydoVXZk=; b=g68u+vBxQ4BQKGYJdPaJxu2h20pz3pEB/CM3jWYddI3+xJk9Yrm8ZWXtx8h/d89UTY Q1eVBT/yWQRvJTo7pckSku9MEPgYuFBld7j19+04mCI7G4barNS+H8Kb1+KNxz/6EdUG OXdag8Z/9VqGmHs2JaR+R64IhmgKWKBfLUo2z+xDxOGwgq861wm+nW+9lOJaxWKHmQMP OIoWfbLhNhnAsRt8H8EqAng+C4ipF3XW/YU+7RKuFRNaw9fvQ1PwODMXLJqAsI6NzBez sNouxmuXHqlNlhIWaH0o43JmWFOLDPHopQbmBDG0A3YAh4kZuTAbMvDTFEZh7qBBniiX U/jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b="S7NAdMt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r195-20020a632bcc000000b0052877366da6si10038173pgr.104.2023.04.28.23.15.29; Fri, 28 Apr 2023 23:15:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b="S7NAdMt/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbjD2FoE (ORCPT + 99 others); Sat, 29 Apr 2023 01:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347515AbjD2Fni (ORCPT ); Sat, 29 Apr 2023 01:43:38 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBE8B3ABC for ; Fri, 28 Apr 2023 22:43:02 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-555d93630e7so10465977b3.3 for ; Fri, 28 Apr 2023 22:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682746902; x=1685338902; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=udIESTQJWghJ0eXfw1zjkQa1ohgrnaNqFMimydoVXZk=; b=S7NAdMt/BLILu3k9cqlhzRidxjuY8lPnMt9sI+f7V2WnoL0rxhIkGSZbMkNXRfehPv 5TPdUIB0O+pIIqNJVeoQHIqeLHdKnubmejL5VoddsDUULbDGIMPX1pvwM6yU06ZFwrQC 0eXx+8aYwje6WrjerTb2LqIO9f52ufMyswrjFggR7oKPCkP48oaqYCu/R8K8JIRFgkSZ +HFtXojLsja1GXQtRnMhcQ3JfR3PLQbsgqaq6q3opqfKF6AOcHzH4KX1Ku6AcICuzCEb IC2Nt0douaEw6NzsuPzD+GLN4s4QEv9KyLJCP0fOzB4wXNJGtjSxVDJfH92Cu3jvRarf FnKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682746902; x=1685338902; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=udIESTQJWghJ0eXfw1zjkQa1ohgrnaNqFMimydoVXZk=; b=FgpXdLc5Mkr8sO1JWfg2/TL5470ivo+jtL7zlir2dLZTW2z/IRdm8P+iRDyr6r4Wyb dnOdnWKDW2eLGqmj1xqby0WF4OZ0AIgGKfzWGS4JUSBfm5ReGgLnHyYJD3s2Kbd6n4cl +j6akqtMkpoi39Mne4q+dMBdSg0v/XpMsb1q1xMtr7v/zEpbj7mrgbRJXC1S3kSJau56 n1Li47UtSc7zkoCJwARRDrW5X11cgfqIzZBy52FIbxNBoG3+qZBqs7KkVaSN/X9EZHGZ dgapF7mGxZ/icBFceqryxMM5RMUQKpbgG/FXchd/+odEOloO3UvGvTNlJXh4MEXLZ0v2 ek9w== X-Gm-Message-State: AC+VfDyWT6g92lOllO1z0DrA1H3udTKhhx8WiWu65e0wnHTiyqCvaDT6 zW17rufnqqxyoUSJ21lhfjotcbTaqaxW X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:c563:7e28:fb7c:bce3]) (user=irogers job=sendgmr) by 2002:a81:ad07:0:b0:556:2da0:fc6 with SMTP id l7-20020a81ad07000000b005562da00fc6mr4244919ywh.7.1682746902557; Fri, 28 Apr 2023 22:41:42 -0700 (PDT) Date: Fri, 28 Apr 2023 22:35:05 -0700 In-Reply-To: <20230429053506.1962559-1-irogers@google.com> Message-Id: <20230429053506.1962559-46-irogers@google.com> Mime-Version: 1.0 References: <20230429053506.1962559-1-irogers@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Subject: [PATCH v3 45/46] perf stat: Don't disable TopdownL1 metric on hybrid From: Ian Rogers To: Arnaldo Carvalho de Melo , Kan Liang , Ahmad Yasin , Peter Zijlstra , Ingo Molnar , Stephane Eranian , Andi Kleen , Perry Taylor , Samantha Alt , Caleb Biggers , Weilin Wang , Edward Baker , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Florian Fischer , Rob Herring , Zhengjun Xing , John Garry , Kajol Jain , Sumanth Korikkar , Thomas Richter , Tiezhu Yang , Ravi Bangoria , Leo Yan , Yang Jihong , James Clark , Suzuki Poulouse , Kang Minchul , Athira Rajeev , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ian Rogers Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that hybrid bugs are fixed sufficient to run TopdownL1 metrics, don't implicitly disable them for hybrid. Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index f4e572f9de6b..67dc69270ae4 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1900,12 +1900,7 @@ static int add_default_attributes(void) * Add TopdownL1 metrics if they exist. To minimize * multiplexing, don't request threshold computation. */ - /* - * TODO: TopdownL1 is disabled on hybrid CPUs to avoid a crashes - * caused by exposing latent bugs. This is fixed properly in: - * https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/ - */ - if (metricgroup__has_metric(pmu, "TopdownL1") && !perf_pmu__has_hybrid()) { + if (metricgroup__has_metric(pmu, "TopdownL1")) { struct evlist *metric_evlist = evlist__new(); struct evsel *metric_evsel; -- 2.40.1.495.gc816e09b53d-goog