Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Apr 2023 15:10:40 +0200
From:   Mehdi Djait <mehdi.djait.k@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     jic23@kernel.org, mazziesaccount@gmail.com,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/7] iio: accel: kionix-kx022a: Add an i2c_device_id
 table
Message-ID: <ZE0XUJMnnUPeYGve@carbian>
References: <cover.1682373451.git.mehdi.djait.k@gmail.com>
 <a232fe7a8104f8d1cddfc5950aa48748ea90bffa.1682373451.git.mehdi.djait.k@gmail.com>
 <ZEfYOO9TQSbEyCu2@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZEfYOO9TQSbEyCu2@smile.fi.intel.com>
Precedence: bulk

Hi Andi,

On Tue, Apr 25, 2023 at 04:40:08PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 25, 2023 at 12:22:24AM +0200, Mehdi Djait wrote:
> > Add the missing i2c device id 
> 
> Seems like unfinished commit message (also note missing period, that's why
> I paid attention to this).
> 

While the period is indeed missing. I did not find anything else to
write in the commit message other than 'Add the missing i2c device id'

> ...
> 
> > +static const struct i2c_device_id kx022a_i2c_id[] = {
> > +	{ .name = "kx022a", 0 },
> 
> ', 0' is redundant.

I will remove it

--
Kind Regards
Mehdi Djait