Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Apr 2023 14:36:31 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Evan Green <evan@rivosinc.com>
Cc:     Palmer Dabbelt <palmer@rivosinc.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Andrew Jones <ajones@ventanamicro.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Heiko Stuebner <heiko.stuebner@vrull.eu>,
        Jisheng Zhang <jszhang@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 2/3] RISC-V: Track ISA extensions per hart
Message-ID: <20230429-record-plunder-a21cf40d4cee@spud>
References: <20230428190609.3239486-1-evan@rivosinc.com>
 <20230428190609.3239486-3-evan@rivosinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BLU7QsAwGsxIomG5"
Content-Disposition: inline
In-Reply-To: <20230428190609.3239486-3-evan@rivosinc.com>
Precedence: bulk


--BLU7QsAwGsxIomG5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 28, 2023 at 12:06:07PM -0700, Evan Green wrote:

> @@ -112,14 +116,17 @@ void __init riscv_fill_hwcap(void)
>  	bitmap_zero(riscv_isa, RISCV_ISA_EXT_MAX);
> =20
>  	for_each_of_cpu_node(node) {
> +		struct riscv_isainfo *isainfo;
>  		unsigned long this_hwcap =3D 0;
> -		DECLARE_BITMAP(this_isa, RISCV_ISA_EXT_MAX);
>  		const char *temp;
> +		unsigned int cpu_id;
> =20
>  		rc =3D riscv_of_processor_hartid(node, &hartid);
>  		if (rc < 0)
>  			continue;
> =20
> +		cpu_id =3D riscv_hartid_to_cpuid(hartid);
> +		isainfo =3D &hart_isa[cpu_id];
>  		if (of_property_read_string(node, "riscv,isa", &isa)) {

Would you mind adding a blank line above the if statement please?
Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>  			pr_warn("Unable to find \"riscv,isa\" devicetree entry\n");
>  			continue;

--BLU7QsAwGsxIomG5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZE0dSQAKCRB4tDGHoIJi
0gsnAQD3C7wPGlXJpnjjDLb+5iaR4064+DeCKq1zwwCZmkbK2QEAulHfubOOEb14
bOcIpu2YKL/pjU13yG9aPi38S9/RUwk=
=b/Lb
-----END PGP SIGNATURE-----

--BLU7QsAwGsxIomG5--