Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Sat, 29 Apr 2023 08:21:31 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Nathan Chancellor <nathan@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Jiri Slaby <jirislaby@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        syzbot <syzbot+b7c3ba8cdc2f6cf83c21@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] tty: tty_io: remove hung_up_tty_fops
Message-ID: <58974d54-9e02-4800-814f-9206c3cfcc95@roeck-us.net>
References: <e1fe6a44-3021-62ad-690a-69146e39e1ac@I-love.SAKURA.ne.jp>
 <20230424004431.GG3390869@ZenIV>
 <8e21256a-736e-4c2d-1ff4-723775bcac46@I-love.SAKURA.ne.jp>
 <2fca7932-5030-32c3-dd61-48dd78e58e11@I-love.SAKURA.ne.jp>
 <20230425160344.GS3390869@ZenIV>
 <1b405689-ea0a-6696-6709-d372ce72d68c@I-love.SAKURA.ne.jp>
 <5cebade5-0aa9-506c-c817-7bcf098eba89@I-love.SAKURA.ne.jp>
 <20230428162718.GA1099174@dev-arch.thelio-3990X>
 <6dca757e-74ac-773d-2a50-4e48b2f56880@I-love.SAKURA.ne.jp>
 <2023042859-kosher-specimen-9a0f@gregkh>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023042859-kosher-specimen-9a0f@gregkh>
Precedence: bulk

On Fri, Apr 28, 2023 at 07:31:35PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 29, 2023 at 01:41:02AM +0900, Tetsuo Handa wrote:
> > On 2023/04/29 1:27, Nathan Chancellor wrote:
> > > I see this change has shown up in -next as commit 4c87e9e5479b ("tty:
> > > tty_io: remove hung_up_tty_fops"), where it causes the following warning
> > > for configurations without CONFIG_COMPAT (I used ARCH=arm defconfig):
> > > 
> > >   drivers/tty/tty_io.c:446:13: warning: 'hung_up_tty_compat_ioctl' defined but not used [-Wunused-function]
> > >     446 | static long hung_up_tty_compat_ioctl(struct file *file,
> > >         |             ^~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > I am not sure if you just added that patch for additional test coverage
> > > or for final acceptance but the following diff resolves this warning for
> > > me, perhaps it can be folded in for a v2?
> > 
> > Thank you for reporting. Yes, moving the definition will solve the warning.
> > 
> > I'm testing this patch using my volatile tree before getting merged to a
> > permanent tree.
> 
> How are you adding new stuff to linux-next right now when the tree
> should be "closed"?  And I haven't reviewed this yet, what tree has

That happens all the time, and quite often the "late" additions are applied
to mainline immediately afterwards and end up causing problems there.
I can only hope that this won't happen with this one.

> picked it up?
> 
> Please wait until after -rc1 is out for new stuff, you know this...
> 

This patch is supposed to fix a data race, so maybe it wasn't considered
"new". Just guessing, of course.

Guenter