Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Apr 2023 11:58:04 -0700 (PDT)
Subject:     Re: [PATCH v7 0/2] StarFive's SYSCON support
In-Reply-To: <20230406103308.1280860-1-william.qiu@starfivetech.com>
CC:     devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, Conor Dooley <conor@kernel.org>,
        kernel@esmil.dk, william.qiu@starfivetech.com
From:   Palmer Dabbelt <palmer@dabbelt.com>
To:     william.qiu@starfivetech.com
Message-ID: <mhng-698f09f5-3840-4456-87c2-5c04742b42f4@palmer-ri-x1c9a>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 06 Apr 2023 03:33:06 PDT (-0700), william.qiu@starfivetech.com wrote:
> Hi,
>
> This patchset adds initial rudimentary support for the StarFive
> designware mobile storage host controller driver. And this driver will
> be used in StarFive's VisionFive 2 board. The main purpose of adding
> this driver is to accommodate the ultra-high speed mode of eMMC.
>
> The last patch should be applied after the patchset [1]:
> [1] https://lore.kernel.org/all/20230401111934.130844-1-hal.feng@starfivetech.com/
>
> Changes v5->v6:
> - Rebased to 6.3-rc3.
> - Modified compatible's property.
> - Added clock-controller and power-controller node.
>
> Changes v5->v6:
> - Rebased to 6.3-rc1.
> - Changed file name to starfive,jh7110.yaml.
> - Modified commit description.
> - Added syscon node dts patch to other dependent modules.
>
> Changes v4->v5:
> - Added a incremental updates to fix a bug that prev_err is uninitialized.
> - Dropped the merged patches.
> - Dropped the dts patch.
> - Sorted compatible alphabetically in yaml.
>
> Changes v3->v4:
> - Added documentation to describe StarFive System Controller Registers.
> - Added aon_syscon and stg_syscon node.
> - Fixed some checkpatch errors/warnings.
>
> Changes v2->v3:
> - Wraped commit message according to Linux coding style.
> - Rephrased the description of the patches.
> - Changed the description of syscon regsiter.
> - Dropped redundant properties.
>
> Changes v1->v2:
> - Renamed the dt-binding 'starfive,jh7110-sdio.yaml' to 'starfive,jh7110-mmc.yaml'.
> - Changed the type of 'starfive,syscon' and modify its description.
> - Deleted unused head files like '#include <linux/gpio.h>'.
> - Added comment for the 'rise_point' and 'fall_point'.
> - Changed the API 'num_caps' to 'common_caps'.
> - Changed the node name 'sys_syscon' to 'syscon'.
> - Changed the node name 'sdio' to 'mmc'.
>
> The patch series is based on v6.3.
>
> William Qiu (2):
>   dt-bindings: soc: starfive: Add StarFive syscon doc
>   riscv: dts: starfive: jh7110: Add syscon nodes
>
>  .../soc/starfive/starfive,jh7110-syscon.yaml  | 56 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  arch/riscv/boot/dts/starfive/jh7110.dtsi      | 15 +++++
>  3 files changed, 76 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>