Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230424102827.58707-1-ukleinek@debian.org>
In-Reply-To: <20230424102827.58707-1-ukleinek@debian.org>
From:   Ian Rogers <irogers@google.com>
Date:   Sat, 29 Apr 2023 14:05:58 -0700
Message-ID: <CAP-5=fUOL0FmtMbLQtRx2-_i6uvbsBLsxaAg54x8umT4npT7iA@mail.gmail.com>
Subject: Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds
To:     =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <ukleinek@debian.org>
Cc:     Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org,
        Diederik de Haas <didi.debian@cknow.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 24, 2023 at 3:28=E2=80=AFAM Uwe Kleine-K=C3=B6nig <ukleinek@deb=
ian.org> wrote:
>
> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
> Makefiles with the same problem.
>
> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
> Signed-off-by: Uwe Kleine-K=C3=B6nig <ukleinek@debian.org>

Acked-by: Ian Rogers <irogers@google.com>

Same problem here I think:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/too=
ls/lib/api/Makefile#n42

Thanks,
Ian

> ---
>  tools/lib/symbol/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/symbol/Makefile b/tools/lib/symbol/Makefile
> index 13d43c6f92b4..4a08cc4e19f2 100644
> --- a/tools/lib/symbol/Makefile
> +++ b/tools/lib/symbol/Makefile
> @@ -39,7 +39,7 @@ endif
>  endif
>
>  ifeq ($(DEBUG),0)
> -  CFLAGS +=3D -D_FORTIFY_SOURCE
> +  CFLAGS +=3D -D_FORTIFY_SOURCE=3D2
>  endif
>
>  # Treat warnings as errors unless directed not to
> --
> 2.39.2
>