Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Sat, 29 Apr 2023 21:48:18 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   "Konstantin Ryabitsev" <konstantin.ryabitsev@linux.dev>
Message-ID: <5fe1484b4f2b4ae960a9b599c4ab3ace@linux.dev>
Subject: Re: [PATCH] RISC-V: fixup in-flight collision with
 ARCH_WANT_OPTIMIZE_VMEMMAP rename
To:     "Palmer Dabbelt" <palmer@dabbelt.com>,
        "Conor Dooley" <conor@kernel.org>
Cc:     "Conor Dooley" <conor.dooley@microchip.com>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        akpm@linux-foundation.org, aneesh.kumar@linux.ibm.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        lukas.bulwahn@gmail.com
In-Reply-To: <mhng-b5a20207-95a2-4607-9e6c-52396d569d91@palmer-ri-x1c9a>
References: <mhng-b5a20207-95a2-4607-9e6c-52396d569d91@palmer-ri-x1c9a>
Precedence: bulk

April 29, 2023 4:17 PM, "Palmer Dabbelt" <palmer@dabbelt.com> wrote:=0A>>=
> I guess you picking this up for your second PR makes the most sense=0A>=
>> Palmer?=0A> =0A> Yep, except it crashes b4=0A> =0A> $ b4 shazam -lts h=
ttps://lore.kernel.org/all/20230429-trilogy-jolly-12bf5c53d62d@spud=0A> G=
rabbing thread from lore.kernel.org/all/20230429-trilogy-jolly-12bf5c53d6=
2d%40spud/t.mbox.gz=0A> Analyzing 2 messages in the thread=0A> Checking a=
ttestation on all messages, may take a moment...=0A> Traceback (most rece=
nt call last):=0A> File "/home/palmer/.local/src/b4/b4/command.py", line =
383, in <module>=0A> cmd()=0A> File "/home/palmer/.local/src/b4/b4/comman=
d.py", line 366, in cmd=0A> cmdargs.func(cmdargs)=0A> File "/home/palmer/=
.local/src/b4/b4/command.py", line 100, in cmd_shazam=0A> b4.mbox.main(cm=
dargs)=0A> File "/home/palmer/.local/src/b4/b4/mbox.py", line 713, in mai=
n=0A> make_am(msgs, cmdargs, msgid)=0A> File "/home/palmer/.local/src/b4/=
b4/mbox.py", line 101, in make_am=0A> am_msgs =3D lser.get_am_ready(noadd=
trailers=3Dcmdargs.noaddtrailers,=0A> File "/home/palmer/.local/src/b4/b4=
/__init__.py", line 552, in get_am_ready=0A> checkmark, trailers, attcrit=
 =3D lmsg.get_attestation_trailers(attpolicy, maxdays)=0A> File "/home/pa=
lmer/.local/src/b4/b4/__init__.py", line 1319, in get_attestation_trailer=
s=0A> for attestor in self.attestors:=0A> File "/home/palmer/.local/src/b=
4/b4/__init__.py", line 1158, in attestors=0A> self._load_patatt_attestor=
s()=0A> File "/home/palmer/.local/src/b4/b4/__init__.py", line 1261, in _=
load_patatt_attestors=0A> patatt_config =3D patatt.get_config_from_git(r'=
patatt\..*', multivals=3D['keyringsrc'])=0A> AttributeError: module 'pata=
tt' has no attribute 'get_config_from_git'=0A> =0A> So I probably need to=
 just go update my setup, I've got a bunch of wacky stuff.=0A> I'll try a=
nd remember to do so, but I'm going to scrub through other bits=0A> first=
...=0A=0AIndeed, you have a newer version of b4 without also updating the=
 patatt dependency. If you're using b4 from git, you need to "git submodu=
le update".=0A=0ARegards,=0A-K