Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 29 Apr 2023 20:01:11 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     David Hildenbrand <david@redhat.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Matthew Wilcox <willy@infradead.org>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>,
        Christian Benvenuti <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bjorn Topel <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Christian Brauner <brauner@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        Oleg Nesterov <oleg@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Mika Penttila <mpenttil@redhat.com>,
        David Howells <dhowells@redhat.com>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5] mm/gup: disallow GUP writing to file-backed mappings
 by default
Message-ID: <ZE2ht9AGx321j0+s@nvidia.com>
References: <6b73e692c2929dc4613af711bdf92e2ec1956a66.1682638385.git.lstoakes@gmail.com>
 <afcc124e-7a9b-879c-dfdf-200426b84e24@redhat.com>
 <ZEvZtIb2EDb/WudP@nvidia.com>
 <ZEwPscQu68kx32zF@mit.edu>
 <ZEwVbPM2OPSeY21R@nvidia.com>
 <ZEybNZ7Rev+XM4GU@mit.edu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZEybNZ7Rev+XM4GU@mit.edu>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iE0OKmkRiV3OCd4usK7tt+/I2b7ADXN9MFJv9oHh2+6omO5t018JxSVLeAI8?=
 =?us-ascii?Q?3bkcI+iHJm/IKJevp6X8c515vNGHtpMnVi9BTx9pSk23U48tuAYS/d8kl90a?=
 =?us-ascii?Q?cQwz32+xyEe1e4trNfj3WEGeF1MlEUuidkRLorfOcQ+E6rDGPVYTTb4jkNuO?=
 =?us-ascii?Q?VgvYwvI5SYSwcwyTR3HzFQKHoiREZqZAT459owUGvea8sXMdY1av3n6PA/AI?=
 =?us-ascii?Q?SqlyyXvZ3+2Znu06TR+ldDD11Z5JNs6J+gZ1l3SHmgyCTdIhr4oFlPEJ7116?=
 =?us-ascii?Q?UVaHuJjw/Tp88nqDhMOZoWTd5LxyamWp7FLxEbVE7JvypAXHgdhDpifYioZQ?=
 =?us-ascii?Q?j3MoK7hytJI9Mr/DsB4Uckp3+JLthoOWeN3eWreRU26D1Jd1lPs3jJHGhtGm?=
 =?us-ascii?Q?mZQPfzuLRbUWQzteFu22zSQ4Kqtp5sPm60XQw/5qaoBi0K9zTuChq5RAs7hG?=
 =?us-ascii?Q?+zcPULtvzHx+IRy5wK9QFuStnLLycVYumWYNHUKIv7kKmcIep2X8yUdUBxRe?=
 =?us-ascii?Q?oLcoCPRnwKL+wZgVksgJaCuDB6vQn0r8fHmx79xQXAVOwNVRPJsnX10vgBHI?=
 =?us-ascii?Q?CnaN8ZlrrFrudWgQ12LzAEJ2CMNYpWJyGnte91s2I5VP1GP13GYD/F21nWel?=
 =?us-ascii?Q?Cg9I0ltOvtG5iT8jpxXk5a8wcMU8Qt8IrL+yKAfsyuGkFvXLwTtsntKwzfjQ?=
 =?us-ascii?Q?np/cKeTA0iLtmWPJ1JpfZPgbDs7nT69AyXwOKB2Qx6el5jCKYozHGbr45/mI?=
 =?us-ascii?Q?kadHaAw6dR/x4vRoh/XA7glfEUxGN/spAG0f1Msuza11uHQ8Q/nezLCRxrw4?=
 =?us-ascii?Q?ZKjDgYfF6VMZFsfLQVtzNvjy0d9AM2vlgykgWzkoazxMT+ZXjkSJksIKdIqD?=
 =?us-ascii?Q?Y1FUG+czFcDT3O2pwl4q8698854OcWiiLDZKVQyopd+Ns+wvmSfHuutmA1Ak?=
 =?us-ascii?Q?HYFKNEmcayaUYe1VwY5eY0M2yaIAntpf4mFNCzVmp9NkGlnJUnLt/fCk/yUy?=
 =?us-ascii?Q?QH5zXlWdn10aTXHJWUcYY9DP+ANP4cxYg6kCuTTzFobUwfPX5ZPalWOICLju?=
 =?us-ascii?Q?ewYwSBWMl/p4W0xJ5CE0kHfNOgJXedjExoINm0KUcovJrC2ODHrEkmvEjXU3?=
 =?us-ascii?Q?TRlX2eKJFnk1fsQ3zhSr1HXdWN7h2L31dTh41F/vIsGiZLj9vOeIfy+uZVZF?=
 =?us-ascii?Q?gDOWaAHgXw1eaeRMiTYy1u3Q6okOj7Fgp7mA9jsePe+/mNwxtGdM+ykZ0C2R?=
 =?us-ascii?Q?eLTJgYS0VVUGcV/Ph1n4kDsh0dBHogUZpvK8UwkageVPAJHWyb/YiMupN3Qc?=
 =?us-ascii?Q?35dg5GuHI6JRXIjAW2bsanRMj8ENVqD8RT1Xs6ot/na5+h+g+WVS/ev6LoW+?=
 =?us-ascii?Q?c9YH5aVBdWW6+ZDgkiUuuybN3vu4xrskLXzxhy5sE8I7ScbzRf2a4vP8lfaW?=
 =?us-ascii?Q?MNPFLoqdhI4HvN0Qt2XtS/kA+IANIdBuoKa2Qg1/yZ/WUMRA2L1Nh5wuw2SH?=
 =?us-ascii?Q?ee7T2OlxRK6PALE3QIFwX+T9XQ+hR0s57u8+dqD5Bc5YblOZwS1HLXIR6LvS?=
 =?us-ascii?Q?hRb06Q/7QA/njs9VES4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7f0a4b6-9920-4195-1190-08db4905a0ea
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2023 23:01:12.9432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gSGh5gs93kWmWsiRmyswfGfTbUstHzbWQYn2DRr4ZlUBnrGex5QPWGFEimC42Dzj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8162
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 29, 2023 at 12:21:09AM -0400, Theodore Ts'o wrote:

> In any case, the file system maintainers' position (mine and I doubt
> Dave Chinner's position has changed) is that if you write to
> file-backed mappings via GUP/RDMA/process_vm_writev, and it causes
> silent data corruption, you get to keep both pieces, and don't go
> looking for us for anything other than sympathy...

This alone is enough reason to block it. I'm tired of this round and
round and I think we should just say enough, the mm will work to
enforce this view point. Files can only be written through PTEs.

If this upsets people they can work on fixing it, but at least we
don't have these kernel problems and inconsistencies to deal with.

Jason