Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp3980736rwr; Sat, 29 Apr 2023 20:11:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ETmbcYjgegQj5kTPqME/rXyCv4nKScZqrs8CqJ/wZci92n/+91JrR/W2vn5eDbpSnSUvD X-Received: by 2002:a17:90a:1a07:b0:242:d8e6:7b68 with SMTP id 7-20020a17090a1a0700b00242d8e67b68mr6697858pjk.1.1682824305189; Sat, 29 Apr 2023 20:11:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682824305; cv=none; d=google.com; s=arc-20160816; b=sgy4phbFvNRPXOGMRLURuhNb/SpygLeXRNXSFD1gVJ6+qKA94DBblh1d/YnmIyfoe0 yIHM7/v2L6zjo6cOqHKc2YPn6Wf7Uv1d5N/hz5l7K2yAuSTJIVtKZSF8BPRacVthVbrI Df/6owMlBK3OZBT8fMSSA+SutrIM1TYgGg6KBRncbEWqLfmsousFifKtVWz+20+ePjSo X7uUxLCOF0e1YJWRAyAJAbkoC1hxaP/TUaEJZ0rbcxciHg4W0DEXsey8uOetQxRmgQJV cWIMLA4/JekAP9iG4JdijQTPleoO9syQAS43qi8Bi1hG7tHQkL0WlMxr1Z6JtTyNZ9LS gljg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=zypWVf9MXS+lPQIzItTqVr7FILdJ9hERlQX46tPuHAQ=; b=nUMgOa2HcyEKs5idXe0DG2wu5Byn5StWjy//ySRjjc/+buzDw+IpmnbbrKtc+xUehz seIKEq1fDWwjeu+vwy2aX2FwT7XJi9DDI29lu+nHW23GweVoUWFwLiZIEp5mce28Juq8 WE3X2P8akUEcghkMsBl/+sAxVdFLUGjMdtQWMC0PsfI7kzmsje2EBrmWm4FboQcORyVU 8ORiXTK+u4aSf6hAEK06PntgTutLOQsJYyb1LpSxODUA7TRE1WV3JrRnD/S4vY8Mh+78 /YLELPm0ndpIWX+z9KHUvNxMuyKGkhI8UI/uqvrf7blcUw9mdGdx3Ixc/IoXW0/hrP4k sZeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=NSLLVLm8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q4-20020a631f44000000b0051398cda533si21698867pgm.388.2023.04.29.20.11.27; Sat, 29 Apr 2023 20:11:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=NSLLVLm8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230404AbjD3Csb (ORCPT + 99 others); Sat, 29 Apr 2023 22:48:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjD3Csa (ORCPT ); Sat, 29 Apr 2023 22:48:30 -0400 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D4801BD5 for ; Sat, 29 Apr 2023 19:48:28 -0700 (PDT) Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 4204A20033; Sun, 30 Apr 2023 10:48:20 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1682822901; bh=zypWVf9MXS+lPQIzItTqVr7FILdJ9hERlQX46tPuHAQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=NSLLVLm8VQGFuxD5PGQtL/WcVqx3tOl/CP/Jl7iQD0NlAb1TGdR/ax5AnNHXyFCd4 6je199kUjTKo2+uP99776iidHnguIDdLfHKuT0cXs0wSmOc9wtMmuvXAmfbZwDEAez DHYuhJbXY2jZn0b3VsrucGOlZ9TGuwbIFb6gDm0hr/MMPgPJBXxEOAlNU723jEUNeF hfhisf854oJ4wVb9YLvj/Xi0N6zwMSD9RWryEdcQ7JrPejipP1tyfjg+CjbT+RD+2p Yb5YH3tL56d+TPtiCUP4pG+m3qBebrLel5KKljeay5cXWFry+mFU9c62idf3Mfscjh +leRbFah41gbA== Message-ID: <71e6b0d439cf53d9b8824370a52a5bed9ce4fcf9.camel@codeconstruct.com.au> Subject: Re: [PATCH] i3c: ast2600: set variable ast2600_i3c_ops storage-class-specifier to static From: Jeremy Kerr To: Tom Rix , alexandre.belloni@bootlin.com Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sun, 30 Apr 2023 10:48:19 +0800 In-Reply-To: <20230429134601.2688558-1-trix@redhat.com> References: <20230429134601.2688558-1-trix@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3-1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, > smatch reports > drivers/i3c/master/ast2600-i3c-master.c:121:34: warning: symbol > =C2=A0 'ast2600_i3c_ops' was not declared. Should it be static? >=20 > This variable is only used in its defining file, so it should be > static. Super, thanks! Reviewed-by: Jeremy Kerr Cheers, Jeremy