Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Arnd Bergmann <arnd@arndb.de>, Adam Borowski <kilobyte@angband.pl>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Usyskin, Alexander" <alexander.usyskin@intel.com>
Subject: RE: [PATCH] mei: make hdcp and pxp depend on X86 && PCI
Thread-Topic: [PATCH] mei: make hdcp and pxp depend on X86 && PCI
Thread-Index: AQHZderH+wsq6lIxj02Y7iezAU/Pd687czNQgAB5swCAAB4tAIAAHfEAgABrM4CAAVOV8IACVwiAgAJJtZA=
Date:   Sun, 30 Apr 2023 06:38:27 +0000
Message-ID: <MN2PR11MB40930E6A1A2029BBB19B51D7E5699@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <20230423135124.55196-1-kilobyte@angband.pl>
 <MN2PR11MB409305D13E46C371321AC2F0E5649@MN2PR11MB4093.namprd11.prod.outlook.com>
 <20230425115210.GA4151911@angband.pl>
 <2023042502-resolute-divisible-fbff@gregkh>
 <20230425152720.GA4155584@angband.pl>
 <a8840c41-6245-4531-8b23-5c4e594c1ca9@app.fastmail.com>
 <MN2PR11MB4093C51F94BC3CDDC1F34968E5659@MN2PR11MB4093.namprd11.prod.outlook.com>
 <688fe177-5f00-4434-ba08-2348a8e5ee15@app.fastmail.com>
In-Reply-To: <688fe177-5f00-4434-ba08-2348a8e5ee15@app.fastmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?09hUKLXpa4fxe2eXJuitTZ9EL/ORf6NVWuw9cijoaxOylbXxzOLIgYJe2Biq?=
 =?us-ascii?Q?y9hSSscIr+jsNnF9H18q4M/l2Xi7RVFvnQMo9R+YpRSGc8tCAwoIEzoDhvKt?=
 =?us-ascii?Q?L4RubGs8Q/AtLdBcMz9gn82DvRfG4ykCNVhe1p1KTkdNAV/HMdtU0aECb6BD?=
 =?us-ascii?Q?wdudJ7jgYvhfVM6Nz8FkpjYu0Oa0JgnmEl+nAYM1BNF0XZ4BEI7GIHBSIcnT?=
 =?us-ascii?Q?aQge1lSPljArixONAWsB03lPp1Q/IZuPtAawyDYEnBfK2VCA8QfxD3CTZdla?=
 =?us-ascii?Q?+VXsmH5QEGBZctbqeWPW4H+sNyGEVLqMPHBw4BDxaVTG1vUQC9P3W3M5jg4A?=
 =?us-ascii?Q?hk3p2K+7bJ6VA2pBDPs38eFI8p+7RVs8O6e87TPsayJU1vhi9/0vzFavYIdS?=
 =?us-ascii?Q?PjgbxsinNoZQilnwjjqTLEljecmu2wHQwiCWYts25U7i52NvjkMRnFOXjn3R?=
 =?us-ascii?Q?JSDVmE/NKkP2gLI432GBccXftJrGvBTPlHNYmOy5QyT3aP04QUYO2E+fnoUI?=
 =?us-ascii?Q?uIyi8az2LWQIoLVTtbIdnfQmghI/UmEMYAhkqbvtduUbjeLn0UoLm61inuYy?=
 =?us-ascii?Q?djwqgocWEU8ds7abT0Kp6b6jcrfeiwcdV3TTo4pzLFR8KfLVO36kS3In+r/T?=
 =?us-ascii?Q?4B2MbSt+Uzk8cXByFT6jsw3VmBaEKOKpxXIbe1/W7YuOLJB6BgQVqaNXiY8I?=
 =?us-ascii?Q?cdIryT+tLK4O0lADKuZcPc+pmWUTVJ+BFOXNcZ1WBh0LT6CLMxsOt2OPE11K?=
 =?us-ascii?Q?YLcxQ5bPwiQTW97yMQ5iPfKGut3RuSO9w69FJedzRBI4g8YW5sHadvSq0CmA?=
 =?us-ascii?Q?1MIYfVDEBwx5xRhkWalJqrltM/MtkwfhF9Gg2Dp9BjJQHftxctKOV/Bl8kRQ?=
 =?us-ascii?Q?1uH8NdEuoU/EtBcDWTIlQ55YC/KEh9br25lFPBKt7k6RKNy6PKkGinOlBzCJ?=
 =?us-ascii?Q?x23Uf3Q/oMj24wcIYzFt4JAJEie1BdauMjqDGPVY9DPl1qn9Ak9n7+K7ThC4?=
 =?us-ascii?Q?vdDN09bFpcrs59Ur7H13HGuhN0q3NJqMKDeEVYFX08Q6spO4vQCRJ2RYxmb8?=
 =?us-ascii?Q?vU+8Ja6cI76m0iwVA/2TeGV0b4jAg+xPEHYPmH7YQNDsbjFuc9vBFsG4UBKT?=
 =?us-ascii?Q?MUbkHw+CGbcf6QnwjWfokHpa+nqh11mkWXcuO3RGhse9j0LWzkO+bRkP/4cO?=
 =?us-ascii?Q?z1abeDD03A/QRHhc0R/Zlcr6yVKkTnXIm0/8WZ0vx91RAgHbBCRtxMjaJrCb?=
 =?us-ascii?Q?sUQbJy2IqFuLgOWHCLngG5gyvChSUqlwPZMi6mw1lLmulLD9ioKLXCYZN3xg?=
 =?us-ascii?Q?aLn3K03C5FPjBYMWIEPLFmdo24SMWf25A/CKSzuAPpm8XvbxAGTS80h8gj9R?=
 =?us-ascii?Q?1KZFwPSK/AkWaJFM/pt4bkLaE/1oDGuTY7fPPBtk+QLT3x0gaXRVpYvGS41w?=
 =?us-ascii?Q?XJ/MzdqV0zUhUSLe8V5jnBXRsWwOlB0K/gzP0ODxQ0N6RJsJRnpDhWPCZLF1?=
 =?us-ascii?Q?tX/QYqIYXJNvzqd5zYv61NCNjFb/Mm2tCbPf5WCxeeCr3UdIaXyX4KOpK/E0?=
 =?us-ascii?Q?uevQhLDLTvQp/wsiL1WQiaHDR0RcKZ7349jfmfyF?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8593a86-db74-4837-a858-08db494581a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2023 06:38:27.9740
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VrVO8xWsmeV87Wd4h3bMILqORjAOeeJMtSCF+vDLsY/9BwGkZkdg9FcGjur7IqdJ9vCeB5JBKdCmYuewGC1lEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5648
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Wed, Apr 26, 2023, at 19:11, Winkler, Tomas wrote:
> >>
> >> On Tue, Apr 25, 2023, at 16:27, Adam Borowski wrote:
> >> > The problem in mainline is inconsistency: out of 6 config items, 4
> >> > repeat the "depends on X86 && PCI" line, the other 2 do not.
> >> > There's indeed no immediate functional issue, but I'd argue that a
> >> > dormant bug is
> >> still a bug.
> >
> > The MEI protocol (CONFIG_INTEL_MEI) is not PCI or X86 dependent.
> > INTEL_MEI_GSC is PCI dependent but not X86. (Hope I correct also on
> > implementation side) They HW layers are currently X86 dependent.
>=20
> Ok, so in that case the dependencies should be relaxed like below I guess=
, in
> order to allow using the MEI on non-x86 i915 devices.
>=20
>       Arnd
>=20
> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index
> d21486d69df2..7c6e3b4588d0 100644
> --- a/drivers/misc/mei/Kconfig
> +++ b/drivers/misc/mei/Kconfig
> @@ -2,7 +2,6 @@
>  # Copyright (c) 2003-2019, Intel Corporation. All rights reserved.
>  config INTEL_MEI
>         tristate "Intel Management Engine Interface"
> -       depends on X86 && PCI
>         help
>           The Intel Management Engine (Intel ME) provides Manageability,
>           Security and Media services for system containing Intel chipset=
s.
> @@ -39,7 +38,7 @@ config INTEL_MEI_ME
>  config INTEL_MEI_TXE
>         tristate "Intel Trusted Execution Environment with ME Interface"
>         select INTEL_MEI
> -       depends on X86 && PCI
> +       depends on X86
This should be both X86 and PCI, this is  a HW dependent module=20
>         help
>           MEI Support for Trusted Execution Environment device on Intel S=
oCs
>=20
> @@ -50,7 +49,7 @@ config INTEL_MEI_GSC
>         tristate "Intel MEI GSC embedded device"
>         depends on INTEL_MEI
>         depends on INTEL_MEI_ME
> -       depends on X86 && PCI
> +       depends on PCI
>         depends on DRM_I915
>         help
>           Intel auxiliary driver for GSC devices embedded in Intel graphi=
cs devices.