Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <14858d07-abc2-48f9-329a-6d5a4faceeb9@debian.org>
Date:   Sun, 30 Apr 2023 11:11:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug
 builds
To:     Ian Rogers <irogers@google.com>
Cc:     Arnaldo Carvalho de Melo <acme@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org,
        Diederik de Haas <didi.debian@cknow.org>
References: <20230424102827.58707-1-ukleinek@debian.org>
 <CAP-5=fUOL0FmtMbLQtRx2-_i6uvbsBLsxaAg54x8umT4npT7iA@mail.gmail.com>
Content-Language: en-US, de-DE
From:   =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <ukleinek@debian.org>
In-Reply-To: <CAP-5=fUOL0FmtMbLQtRx2-_i6uvbsBLsxaAg54x8umT4npT7iA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/29/23 23:05, Ian Rogers wrote:
> On Mon, Apr 24, 2023 at 3:28 AM Uwe Kleine-König <ukleinek@debian.org> wrote:
>>
>> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
>> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
>> Makefiles with the same problem.
>>
>> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
>> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks

> Same problem here I think:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/api/Makefile#n42

Indeed, and similar patch here:

	https://lore.kernel.org/all/20230424102049.58338-1-ukleinek@debian.org/

Best regards
Uwe