Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>
CC:     Sagi Grimberg <sagi@grimberg.me>, Daniel Wagner <dwagner@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before
 module unloading
Thread-Topic: [PATCH blktests v2 2/2] nvme-rc: Cleanup fc resource before
 module unloading
Thread-Index: AQHZe0tFVEwtRfzey0GWUGL193fJOg==
Date:   Sun, 30 Apr 2023 10:05:19 +0000
Message-ID: <cmhxiighi3pelki7nd7v6sz7a3ekusxs6wq5rcxunbpe7wob5m@ei6u4tzgsfyn>
References: <20230419084757.24846-1-dwagner@suse.de>
 <20230419084757.24846-3-dwagner@suse.de>
 <3ec250a9-54c7-3e0d-2463-f8faf15cdb58@grimberg.me>
 <ae4faa38-9d84-c708-8228-223ed7fc68db@nvidia.com>
In-Reply-To: <ae4faa38-9d84-c708-8228-223ed7fc68db@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MVwlBzOfcGfWo3On05P3pj7+wx36TKwRnBcD63Ek0axja32xhD0/Kb57sXZM?=
 =?us-ascii?Q?pejfD0s+SP/FzfGW+OdaRXt/2m9u7cx0HUK0gBDMEzbf5i5QpgXd73Le+rrS?=
 =?us-ascii?Q?Dm7OZslMJhmYEKdqRQ83u9U09t5gJUlOWHNoCujGNCHzVrEHf69qzMFjpaLS?=
 =?us-ascii?Q?37uZARVTmogWYrTOhCeLGjukeJJMsPGa4+MLBiI/aYzHxc8hWRpQSYTZfuyu?=
 =?us-ascii?Q?o9TV8D1ppK23CEPYTWf377bzE+Vrwn/FI3llxdpH7cQk7EHWmgb7Xn673n1R?=
 =?us-ascii?Q?gKOAXVrr1en/WJ7590IXaszv0n4qLce/BNi48LxbryuOnqRrcd+9tJtYzG1S?=
 =?us-ascii?Q?x1XLaB9KbMVOTp4pXtiVTsbK6Dkvjinbbn+v1Mjxs3MDHJNsauTvH1KVQ1YQ?=
 =?us-ascii?Q?rmcXgEGMKM8A8T30n7BY2TpG6r2C4uBcwmBAJ8xgbTY1frEy1KvR2qzWWrSo?=
 =?us-ascii?Q?yXwn+7P31RT2JcKtae/rosONpR88HvBYSxdtsgDw47/DROijcU5YL81U5GNe?=
 =?us-ascii?Q?lNaWjgt72QbeQO037vV/47vkcOJXdZQXTmNCEy6wQhscJ9nMACOxdWgdu9eE?=
 =?us-ascii?Q?HTGxLkSzM16FzcNXh88hef0mK/Bnk1hoJ0uLa6JtiqayWW83xNuOqXVWdP0/?=
 =?us-ascii?Q?HeehvMkSI383ddw6gGJqwW7v+KOn8VJyfK2eYcG8JbYkJ9TAQvO2CB6pYg4x?=
 =?us-ascii?Q?wN0LSFQBLoPOI736ronguoPMbGpSx5/pESMfcd1TmPtaowxQHXbSQ8/lU3uF?=
 =?us-ascii?Q?tBFLUjO0jizlECNkDcgNLnNcbZXCN0IZuDy+BquxG1ZCNxzLcfkQeGCwjTsp?=
 =?us-ascii?Q?U5QOarI6ySzvvzOe3ogBzjCehDnztBBM4qoWAF2Sys7uOvYy87NiiHuJJ8n+?=
 =?us-ascii?Q?eYBVveey+Ejzi21q5tQNvMv7yCF/MQPTmnd+wFeltOqHeTLPIeQCvDP+0lav?=
 =?us-ascii?Q?pcRt28n8oB0mz3pnnPyvf4j3XcDDamOznQn9re6rK6Fg3Yh1lnxzrNTJ2/Wl?=
 =?us-ascii?Q?t5D4MUMlLV1XUniq6NyXVawz+VSWlZvjDya7kJKR74YTaPxFczW8hAU4njtn?=
 =?us-ascii?Q?Dp9t8wKbSjnzH36lxLn4LyS1THOd8O4JLLM+5PTNDURwULQMz9kT5OdpjbRi?=
 =?us-ascii?Q?ccUXyVVoYBiC11JqR16VPR98oU5FLNXxblmqA2ZQGcJam1uGJi214nAnYdrB?=
 =?us-ascii?Q?/5wPtfGo0fSlV2Ikn2o2mzSmmXVJuXl+sM3Wb0d221f0GaluZZmeDNEhUrxV?=
 =?us-ascii?Q?junXd8CkZcU+cTDPn4EY8INU7YsAI8Mj8r9TG810DA/FojtHsXB0BJpLua2X?=
 =?us-ascii?Q?85QZ4AwmQm8EL9J/wJJxqs9zsHi7xWkcscsnIxc2/L+qCo6DJLnPcuEQU6lf?=
 =?us-ascii?Q?CxGgXJhMqWFhldE11PbC1yHOrjtVdaE1JW7ThRLj0bwevmASGqIVghgU79TR?=
 =?us-ascii?Q?BnTerl/dSOmZxDUcGTBaL9sQaWmzXYdLezoXwmxvQ+71DuIkdiZA9oE6/BCM?=
 =?us-ascii?Q?BmGXRBrE3FAXwyibH/YkLUQY3yo2DLZbxHEfBdcPYmGxPbvk8iC0UTGRAVrI?=
 =?us-ascii?Q?xWoizbn7Y4HNHXqwFdGwQn7uZ3Nm1hhUy3nho34YHjwMlyxOIQThDn3JwUcP?=
 =?us-ascii?Q?nw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EDAB7B4C87E9BC4EAF94F93C2D277725@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?c35rQwwrw4QzPLVLEfGwDvrBEFaf0Dk/1TELxyIjjnFG7T3Tj9U0mHYm8NtH?=
 =?us-ascii?Q?hD7REWnjbDZ+oAlYqj6DixcBes2F9M2esrxj7EucCwXaI3XmXKuWIvPDVHC2?=
 =?us-ascii?Q?vgWM1HbHk4TTKcEGr8QUIpj80L8F1stRxHFnPm41S9yNDGsTSHrNtBxhvOl3?=
 =?us-ascii?Q?QbqwlHlebQ1AnZuh19f+VW+Q+BXtwQD2CntVpOkKZT3vkYYu69KdB+Hy5QhJ?=
 =?us-ascii?Q?Yk5fIsJidEwMxXmoW1vVbPABXiWUcoM1NE4o5JJKM3xFRav3UNSfVcVGGZSp?=
 =?us-ascii?Q?uQlZ0HavVo8hSMiRnhuEC1eufSE2Q4jeuu8jgP3re7vb3GrwDnzKOb7Kajk1?=
 =?us-ascii?Q?DFsPRcwfJFXVWrZ9ewXvVcxQytCtNnfQjCm9+a1OcernaquUF714GTYIrens?=
 =?us-ascii?Q?m0E9hZAuawQW3MI+L8akrp1UDcWWYAWaU3CIsqvF7Y1g26HSBs9D8+4ceRfj?=
 =?us-ascii?Q?xVESlG/hFAydqF0TiqS9zCG0Fa6gY4EZwCbM21ItENY9cn0ii9+bjgT+4DjW?=
 =?us-ascii?Q?tpDTjiWPaVSOlo4vCva6QwS6l4BimdDBlnmc6BXDu299eqNO3ey5ujeIgglP?=
 =?us-ascii?Q?d1w56CuD+4yfgupjp5mRcwUpENcAgAoZjkfzhj0tQMvAd+VYSGSHTey64ZiA?=
 =?us-ascii?Q?Y4LHX5pUIe+EtKO5exEZQFpmjFWaGU35aw1baKsIO8VFNpzKZ3iTWMCgUYDa?=
 =?us-ascii?Q?/r4SWnuyxVCd09JOkQPgxGgmtxxhPHg3EDTpSVYyzHq/eQAOrYfB4mwOzX4v?=
 =?us-ascii?Q?DC50zJ+biMKJ1woAvDnqwLlQMcbaStN/LnF9GXw0Gz8p1zuBv9bD7FDybQ5i?=
 =?us-ascii?Q?/WgLdaZvDTpQWBAO57Oor+cFW654mrEGbC+Hp9TfQ3lM5WINSFzMCgnn/kSe?=
 =?us-ascii?Q?joOOVuMA/uRbBKoJdUtXsWYE09nhDgPvQisSWnlYE+NwjAzUdnwsnWs9DxjP?=
 =?us-ascii?Q?Kp4DvLOUFUoa3xA0Nux1cA=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9801a4f6-247b-4e8a-44f0-08db496267ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2023 10:05:20.0054
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X1wfkms9zsdEA3at5uobtUqL8o7xsYKL8umv0BKWTJCeeq3aTb5YLh1ANWztOkF83Y4gSq95SSMBeDkcgK/Zzl0fTW2YQWyoXWTEV3BupOY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6298
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 19, 2023 / 21:15, Chaitanya Kulkarni wrote:
> On 4/19/23 02:44, Sagi Grimberg wrote:
> >
> >> Before we unload the module we should cleanup the fc resources first,
> >> basically reorder the shutdown sequence to be in reverse order of the
> >> setup path.
> >
> > If this triggers a bug, then I think it is a good idea to have a
> > dedicated test that reproduces it if we are changing the default
> > behavior.
> >
>=20
> +1

Agreed. Patch post for the new test case will be appreciated. Not to forget=
 this
work, I will open a github issue later.=