Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Sagi Grimberg <sagi@grimberg.me>
CC:     Daniel Wagner <dwagner@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH blktests v2 1/2] nvme-rc: Cleanup fc ports in reverse
 order
Thread-Topic: [PATCH blktests v2 1/2] nvme-rc: Cleanup fc ports in reverse
 order
Thread-Index: AQHZe0uESVTiqdbLXU2l0HN/fMej6Q==
Date:   Sun, 30 Apr 2023 10:07:06 +0000
Message-ID: <2zcb7p4hgdeuj4wud3ztizodqt3lu44ktewusaxot5jn3ifrlx@x6hha62vjrqu>
References: <20230419084757.24846-1-dwagner@suse.de>
 <20230419084757.24846-2-dwagner@suse.de>
 <a58b526d-2e29-6c4a-e277-b684f98636eb@grimberg.me>
In-Reply-To: <a58b526d-2e29-6c4a-e277-b684f98636eb@grimberg.me>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?abLuM3SgVC74SELvftKFiWHs+lbdtgYlN8vGfHo7mKC2+mwTZk17ivp466dE?=
 =?us-ascii?Q?WXFOhdADzRiFCDe1naX2HWfx6GYSsF9zEcjC9W0q6FX29dEkG4bJVa/svI+8?=
 =?us-ascii?Q?3++wAt5kv/0M6eImwPjLr1d/7H3oOYDiLfkIildXMRlTSguF8y3stkkfKyfZ?=
 =?us-ascii?Q?eU71A7SXzVOa1VM9kgr+sxUZMdF+xlCAv+G5ydzLnl7NJM7+d8qTri+WVIBf?=
 =?us-ascii?Q?x7LVzYjmNoPsAOkKlVHMCPGj1cPkPVT+O2n5ERI+3Qs8Ty2olP9WIx3LmqZD?=
 =?us-ascii?Q?NDpLgZXniHgA5a4C/yfG8uF1LjIGOJbUpb2drYuQfQfTJewfGzLZLauYaL7I?=
 =?us-ascii?Q?tGcFxLr59r0K+cAXuWKep70U2IJkJXRNn5ElZnUUef2b1/sDhB4dAf2bbrYk?=
 =?us-ascii?Q?ymhADYyuoNrnyUFkGjU3/rIjgtLT78hBU+mSmOsf4lfGkXrIZXZ7BPqnvfv9?=
 =?us-ascii?Q?FmV+oFMPIuzWOj9ScAsHFXEgzdHTlznZw82UTx85oH3q2VGJvPjfhKbzVPBE?=
 =?us-ascii?Q?A0mxrP2f2FyrWa9sBr1JgtLi7QWH3vfdkUSmU2wV8SkQ9+yZrFbxAyWC8OJS?=
 =?us-ascii?Q?1Vc8JgoBqb1FLcbwQUexU0+0P7TpKZy3727BWgZSn+wzY2H9dmd5qlasLZAF?=
 =?us-ascii?Q?JsaJQJ6Gsw3te17dEh2PjNJIBDQl9CDc20BoDY2L+rbM6sXKih2ljDZYvX0T?=
 =?us-ascii?Q?Txi3aLqmK1iQOTVuswwo3Q2U59kz/HEWyVrtqAfoRFg+yEwuj/SbPOdZH/Ks?=
 =?us-ascii?Q?9ViBwFkTT7tXYnu4gVRHn3MUEwc/SF5kIWfuuJjl/mSVzNKed0+1+ByFCzae?=
 =?us-ascii?Q?r2KmnMOdVxXILb7SPSIAsGXRmmnzHkVtzUqyNNuwkjNc6UaxelZ1LJKcCUa5?=
 =?us-ascii?Q?8SVScd5sN51BsfFzqPmOANFIsxnEekQCrEJH05IXc89O5hZyrK6tJNLQ/QJI?=
 =?us-ascii?Q?HJDl1tzqaPNT98DYKFpcbVLBO10aKIzvepl69QzhAbn1+Xc+IkNUs4h/h+rp?=
 =?us-ascii?Q?XO5rSDhoGRHU8rOBzIzC8S75JuFwPHybBUGS4QmgV9WesbfiKxygfCMj1HJu?=
 =?us-ascii?Q?WiJ0Hxm6lK+39xrMP3sf1YTnRcekVFywNy6XcCuIUSHvZ1WCLi7cJj73mnIG?=
 =?us-ascii?Q?NkbZn2SW8uPfFG+xIvUj9OtKqeyw4zdwVir4Roz8RcUlQqsti917U6Z/2v4d?=
 =?us-ascii?Q?4YG24a15AlfzUZnE8FoPya2M0px+XOTqpb71WlVYPXMBkfiZDwsIzmTdFOqV?=
 =?us-ascii?Q?d29/woVZn7dDkgq3wZQpnLJ//R08oP1KJZkjGOTBJxI20dLL9a3WCVJeTz+w?=
 =?us-ascii?Q?dh4rVXLUsdXfPSvHlP2R6vY4fgqY3KbYnzsDqVCb3Ti0yIzU0Kagg+tHDjkV?=
 =?us-ascii?Q?eYQke5sXD0V3P03rZwwuos3IGXrdFPdszjcCqySBvQx6pK7DvWH/ZayKaSlh?=
 =?us-ascii?Q?A7OVHGdSskqpdecfDuDkfI62YnEuk3duvsjYEnNckGczH2k0QgYD8I0mVv59?=
 =?us-ascii?Q?wu17yyHTBX9RCBlmZ+hQV5Z7JM8H9N8EtOdxWqvHbfk9phW+pZvhl0A5zxTy?=
 =?us-ascii?Q?iI8oY0qOqsUy20M+lT614uySybVzo6YNBSJI2vSYATH5idQwv/Rq8vN4tvAI?=
 =?us-ascii?Q?i/OeKzewx5UWwXsJUSWnEQs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4E7726A3740443439B1682F5147D4D4E@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?VxiADP13gwIDaZ93ZvjPr6NyQVnxtUtDTul9iuhhuu2yvc8mwf7H0JevbtmM?=
 =?us-ascii?Q?f3PWQMdleXceDUmRk7B+V4K/ecthtQVKCX3Pj5MDMqY3ABeQ2WgYhszon/9u?=
 =?us-ascii?Q?Yayro3OgfECzEflK3FhjH42lRBM/Iz0qx0WMPCOOP4hFplSyVYAPUgBzaOEh?=
 =?us-ascii?Q?wIwVra1RQdqkceLj3FfrpTQJdfGyjbA8JZAki9lVaNIYBcDqdVVw811PX1bR?=
 =?us-ascii?Q?v7QjP7IvjXQ9eollNyrhQ97uNwaj6v7Usrar15Mdr7TLpY2qymZamdg2X5zP?=
 =?us-ascii?Q?SUi3r3MQzMr/zvZLGtXCNXxhSUY9ToSEjky4Dvk5ZSwDyYAUTaJuNpVTgivj?=
 =?us-ascii?Q?Ln7Fn86s7jRpf0EpHJIDo89L0OE5UaEmqAsDYh3U6C0LLStM1IeQkKo9NGa+?=
 =?us-ascii?Q?pjEUk9DtpwQVIreWg39vlyxc+6RbXoumU4Sb0yW0hh3kiePYChbbLh26bcwA?=
 =?us-ascii?Q?Ev5zf/utPQnuwugmPI7yDJTwYtrjPbVCUnXe7zgdvSGY7OeV34P8DU3AXFqQ?=
 =?us-ascii?Q?2BmkFvM83skRp2yv0VwqodABSctd374qxhOWdWDjGPVajtmsdxaGSvMhW+3b?=
 =?us-ascii?Q?tzPgJp9fNOo0pjqHaPiQHh/s4UdFvsV7jYcxFSJSQoCtCMo26OG+LogkcASG?=
 =?us-ascii?Q?tLMrGHSs4sloxq38nyVaFRSSbmMbR5Dstuuk/eLLQoqUYGCQ10JJ4rK/Zaqi?=
 =?us-ascii?Q?nki14x5TcEa39teywx0mY70N7WykdWZR8JGfNOaeg993soZL4Tj+1YB3KF0o?=
 =?us-ascii?Q?WC6zm4gosokAkFdG+cl+GRZHybxynC7vpQVRQ/SkOC7rcie7IwWnOHoImT6e?=
 =?us-ascii?Q?qBXwyWws4YuOBHEeDtcfNi+sRsD3GVBt3wh6PChLolIuXAiEb8dkUmg6XsiK?=
 =?us-ascii?Q?zmSnBxtHVL8gAOIDEleyTPk2N/SMVwWKfRsQLhiR88PmIXJBRfZBzlibx2JC?=
 =?us-ascii?Q?3NvsLjdGH6NcrJy+sXsJXQ=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfb1fbb7-22c8-4166-066e-08db4962a74f
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2023 10:07:06.5653
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yLFzpYqiXgdpksOjwzgJZVDtP/ocjRgh7J0V1X5Eam3Zg14PTXxn8SGZ1JYLEG4PrqI8LBieOqh7tJVxzzIedSOLasjYJ7VVFNiW5iP+Las=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6298
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Apr 19, 2023 / 12:41, Sagi Grimberg wrote:
>=20
>=20
> On 4/19/23 11:47, Daniel Wagner wrote:
> > We need to free the resources in the opposite order as we allocate them=
.
> >=20
> > Signed-off-by: Daniel Wagner <dwagner@suse.de>
> > ---
> >   tests/nvme/rc | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/tests/nvme/rc b/tests/nvme/rc
> > index b44239446dcf..ec0cc2d8d8cc 100644
> > --- a/tests/nvme/rc
> > +++ b/tests/nvme/rc
> > @@ -204,10 +204,10 @@ _cleanup_fcloop() {
> >   	local remote_wwnn=3D"${3:-$def_remote_wwnn}"
> >   	local remote_wwpn=3D"${4:-$def_remote_wwpn}"
> > -	_nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \
> > -			       "${remote_wwnn}" "${remote_wwpn}"
> >   	_nvme_fcloop_del_tport "${remote_wwnn}" "${remote_wwpn}"
> >   	_nvme_fcloop_del_lport "${local_wwnn}" "${local_wwpn}"
> > +	_nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \
> > +			       "${remote_wwnn}" "${remote_wwpn}"
> >   }
> >   _cleanup_nvmet() {
>=20
> Does this fix a bug? if it does, than it should probably be documented
> that there is a driver bug because userspace teardown ordering should
> not trigger a driver bug.

I think this fixes a bug, and it can be a left work to add another new test
case. Daniel, what do you think?=