Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp4767021rwr; Sun, 30 Apr 2023 15:00:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5qDEkBKWlSSLCtI8Wj07rJF5LUst2+7i2NBcJRC8UEpXptlx+TLqBfxLn1wpKDSf/zUrwW X-Received: by 2002:a05:6a00:24c5:b0:63f:1717:b7fa with SMTP id d5-20020a056a0024c500b0063f1717b7famr19165315pfv.24.1682892026074; Sun, 30 Apr 2023 15:00:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682892026; cv=none; d=google.com; s=arc-20160816; b=GqxRnXxq5CBRsSPc77G+tYQvONghr8m0cUs1uVwGvxHXAi4BD/ATYQ6Dv/5h3g56yJ Gu2gx7zcdRtfJcLK3dIUN0/EBSjV9pEd06WQiMF5rrggoMwAHHzDZ26jgR2r+JpIZ5tm KxOCSKrxMFV9qNlrUQPjimknu8gmKtO7/S1xH2YoIuxfc1ejlyQkSsn+15PsIgxczCLz BoYLuHfut/MBMIwJ8znc7114zVISnwS55xf4EcgneMhY2hPWN1RUJgLnpOD25MFEbmQQ 6/AD1hSCQ+VooeYgWO1nMgfMtDKR9r2EFcL2R546cdKCFzbEcQUMHVUkCgwYgs7jmSKD coZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=3CCBo9acX629wUTWbYgO6PJPSdCs1aVlP/Jra4BC8lc=; b=DXLCwMRTbYQckNzvML1US5JDSTxcFqWeSczwEXnMLatBlIkvYT6GfxHJVycNi/UipA rLeQ6WSKh/U68lUY8bwspH/j+oUkRgrKl04mjT2VMDuvaXDx6UDtRHgHsG7g8yIPvLDe bZLooX7GhCrGXn1nxBEU58pfJgKmjqEphZUUZsDHI0eaXEKUxUNl/FoaAodt4gUAYy4Q eh2ZIZNBVH3osLPuj+FrFy/Et+2p0F1OXQklETXTI6yCQBxratcBrSg9GDmD1VJlGdLx urzfGqxW9/SmVnUvpPVoxpB5p8DeyI+5tAVDq5t0WpB2UMCBUwnbRdHJYDfUoKDYd6Z/ nTFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b="R+x/59M9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k14-20020aa7998e000000b006399bb6f5b2si27060502pfh.25.2023.04.30.15.00.02; Sun, 30 Apr 2023 15:00:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b="R+x/59M9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbjD3VrM (ORCPT + 99 others); Sun, 30 Apr 2023 17:47:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjD3VrK (ORCPT ); Sun, 30 Apr 2023 17:47:10 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31594E4E for ; Sun, 30 Apr 2023 14:47:08 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-559e317eef1so19915387b3.0 for ; Sun, 30 Apr 2023 14:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1682891227; x=1685483227; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3CCBo9acX629wUTWbYgO6PJPSdCs1aVlP/Jra4BC8lc=; b=R+x/59M9qp8UonQFB6yAJM9fzbeBnIqbkZs3BiwzW+izc3wrD+66D3BSwauSYZj7s2 y98b78TC+/YzvW4g0sl7IWQO1GHyn+bzNn7OfaSNjDTVd7bdVjVY2NPV0R4zfoQn0I/S FRcp8Uh1n+i+Ycr8zPmu9oXPBGNcTSW1r5b0aVlpt+Y5nAKfH8q4nnS78XIJJfofgsaB yZiGFXuO2EvWOGQDl53MiiqKlZUGP34PXRrVnI0vSxQXKJyMH3dvLFnvLPBEpmRt7F1b GlQbS05GxIgml0nPQmZ985G1VMQ7KklWFdJ6k4Y0V/1Cu3Ra1C4yFBJeF9WKO3MsbRR0 U4sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682891227; x=1685483227; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3CCBo9acX629wUTWbYgO6PJPSdCs1aVlP/Jra4BC8lc=; b=Mtd/6E3rJEjl7oer3wIjYuu4rYW6QKWJ7O6L2ILFS6aNBX/aHf2yG4MOyg0i4mRHXa CwmyR8DHJlqF70hahdf2NzVi3v3LYY9Ip+p2ppujDL9njNwoyz8ZeS8Xa/oNC3dH+F4l qCjhFjo6KS/f3Rnc/bQEYfRrm1VpHhr8qXMwDbUE6UxJVaiHujt8e09WSXAZ5RGESIbe gAu3OjBqYsoLmlrTv6ERcMZra/MylKQ9FGphH8IdhjFtrXw6oFrfFtUPHD/sFzXzlCNm EUkN1sKf7oLCSmoMGdZ848W8bsN1eH0e4/vQz18+yKhQv0PmmloZ+/1LZYZhbr4992eT /Dug== X-Gm-Message-State: AC+VfDwDrEruDAickYTmuLKEU1cYy72ghCSnHBkLj2AnwdGRXjroGVMo f6uOi8fKFNXWf1tL5ZG7LEFavp0gJuup6zNJ2z7N X-Received: by 2002:a81:498b:0:b0:555:da78:c3e3 with SMTP id w133-20020a81498b000000b00555da78c3e3mr12125307ywa.29.1682891227314; Sun, 30 Apr 2023 14:47:07 -0700 (PDT) MIME-Version: 1.0 References: <20230420215331.88326-1-junxiao.bi@oracle.com> <20230420215331.88326-2-junxiao.bi@oracle.com> <05b3eebd-7a3f-13d5-1fe9-8f4ab3080521@oracle.com> <30ab7555-8f36-cfb7-9101-0ebb92af3c2f@kernel.dk> <6300a33a-9d3d-42a2-d332-81e02d52d310@oracle.com> In-Reply-To: From: Paul Moore Date: Sun, 30 Apr 2023 17:46:56 -0400 Message-ID: Subject: Re: [PATCH V4 2/2] blktrace: allow access trace file in lockdown mode To: Junxiao Bi Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-block@vger.kernel.org, nathanl@linux.ibm.com, jmorris@namei.org, serge@hallyn.com, konrad.wilk@oracle.com, joe.jin@oracle.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2023 at 6:41=E2=80=AFPM Junxiao Bi = wrote: > On 4/28/23 2:26 PM, Paul Moore wrote: > > On Wed, Apr 26, 2023 at 12:33=E2=80=AFPM Junxiao Bi wrote: > >> Paul, do you have any other concerns regarding blktrace? As Jens > >> mentioned, blktrace just exported IO metadata to Userspace, those were > >> not security sensitive information. > > I think this version of the patchset is much better, thanks for your > > patience. I don't have any further concerns, and since the lockdown > > LSM doesn't have a dedicated maintainer I think you should be all set > > from my perspective. > > Thanks a lot for the review. > > > Since there are no changes under security/, I'm assuming this will go > > in via the tracing tree? > > Should I notify some specific maintainer or mail list for merging? When in doubt, the scripts/get_maintainer.pl tool in the kernel sources can be helpful. The results for the debugfs and relay files are fairly generic, but if you look at the results for the blktrace.c file you get a more reasonable list of maintainers and mailing lists. I believe Jens has already commented on your patches at least once, I don't recall if the others have or not. I see you've already CC'd the block mailing list, so that might be enough. Keep in mind that we are in the middle of a merge window so it is very possible this patch might not be merged in a working/next/etc. branch until after the merge window closes (every maintainer is a little bit different in this regard). --=20 paul-moore.com