Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
From:   Jeff Chua <jeff.chua.linux@gmail.com>
Date:   Mon, 1 May 2023 11:59:12 +0800
Message-ID: <CAAJw_ZsbTVd3Es373x_wTNDF7RknGhCD0r+NKUSwAO7HpLAkYA@mail.gmail.com>
Subject: linux-6.4 alsa sound broken
To:     lkml <linux-kernel@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Oswald Buddenhagen <oswald.buddenhagen@gmx.de>,
        Takashi Iwai <tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Latest git pull from Linus's tree ... playing a simple sound file will
resulted in a lot of echo.

Running on Lenovo X1 with ..
00:1f.3 Audio device: Intel Corporation Alder Lake PCH-P High
Definition Audio Controller (rev 01)

I've bisected and reverted the following patch fixed the problem.

My best,
Jeff

commit 9f656705c5faa18afb26d922cfc64f9fd103c38d
Author: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date:   Thu Apr 20 13:33:23 2023 +0200

    ALSA: pcm: rewrite snd_pcm_playback_silence()

    The auto-silencer supports two modes: "thresholded" to fill up "just
    enough", and "top-up" to fill up "as much as possible". The two modes
    used rather distinct code paths, which this patch unifies. The only
    remaining distinction is how much we actually want to fill.

    This fixes a bug in thresholded mode, where we failed to use new_hw_ptr,
    resulting in under-fill.

    Top-up mode is now more well-behaved and much easier to understand in
    corner cases.

    This also updates comments in the proximity of silencing-related data
    structures.

    Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
    Reviewed-by: Jaroslav Kysela <perex@perex.cz>
    Link: https://lore.kernel.org/r/20230420113324.877164-1-oswald.buddenhagen@gmx.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>