Date: Mon, 1 Oct 2007 10:44:59 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Zach Brown <zab@zabbo.net>
cc: David Howells <dhowells@redhat.com>, hch@infradead.org,
       viro@ftp.linux.org.uk, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and
 read_inode()
In-Reply-To: <20071001173930.GA7718@mami.zabbo.net>
Message-ID: <alpine.LFD.0.999.0710011043250.3579@woody.linux-foundation.org>
References: <20071001130921.29339.72876.stgit@warthog.procyon.org.uk>
 <20071001130958.29339.31669.stgit@warthog.procyon.org.uk>
 <20071001173930.GA7718@mami.zabbo.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 27


On Mon, 1 Oct 2007, Zach Brown wrote:
>
> If you're soliciting opinions, I think I tend to prefer the feel of the
> code paths after the changes.  I don't know the benefits of the change
> are worth the risk in unmaintained file systems, though.
> 
> > +		return ERR_PTR(PTR_ERR(inode));
> 
> This caught my eye.  Surely we can do better :).  It seems to happen a
> few times in the patches, the instance in this patch was the first that
> I noticed.

Yeah. The above obviously *should* be the same as

	return inode;

apart from a few casts. But if the casts matter, there's something else 
wrong.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/