Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9633b9b-c39f-699a-4b05-1c0c55e2dec9@gmail.com>
Date:   Mon, 1 May 2023 17:51:20 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [BUG][RESEND] Bluetooth: L2CAP: possible data race in
 __sco_sock_close()
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com,
        "David S. Miller" <davem@davemloft.net>, edumazet@google.com,
        Jakub Kicinski <kuba@kernel.org>, pabeni@redhat.com,
        linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        baijiaju1990@outlook.com
References: <CADm8TemwbUWDP0R_t7axFk4=4-srnm5c+2oJSy7aeSzdKFSVCA@mail.gmail.com>
 <CABBYNZJCbYnxodwXAeq8F9NerzGWFva0OG6SfUWfJ_Grz=Xq6Q@mail.gmail.com>
From:   Tuo Li <islituo@gmail.com>
In-Reply-To: <CABBYNZJCbYnxodwXAeq8F9NerzGWFva0OG6SfUWfJ_Grz=Xq6Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks for your reply and interests. Our static analysis tool is still 
to be improved, and any feedback on it would be appreciated.

On 2023/4/29 5:24, Luiz Augusto von Dentz wrote:
> Hi,
>
> On Fri, Apr 28, 2023 at 3:27 AM Li Tuo <islituo@gmail.com> wrote:
>>    Hello,
>>
>> Our static analysis tool finds a possible data race in the l2cap protocol
>> in Linux 6.3.0-rc7:
>>
>> In most calling contexts, the variable sk->sk_socket is accessed
>> with holding the lock sk->sk_callback_lock. Here is an example:
>>
>>    l2cap_sock_accept() --> Line 346 in net/bluetooth/l2cap_sock.c
>>        bt_accept_dequeue() --> Line 368 in net/bluetooth/l2cap_sock.c
>>            sock_graft() --> Line 240 in net/bluetooth/af_bluetooth.c
>>                write_lock_bh(&sk->sk_callback_lock); --> Line 2081 in include/net/sock.h (Lock sk->sk_callback_lock)
>>                sk_set_socket() --> Line 2084 in include/net/sock.h
>>                    sk->sk_socket = sock; --> Line 2054 in include/net/sock.h (Access sk->sk_socket)
>>
>> However, in the following calling context:
>>
>>    sco_sock_shutdown() --> Line 1227 in net/bluetooth/sco.c
>>        __sco_sock_close() --> Line 1243 in net/bluetooth/sco.c
>>            BT_DBG(..., sk->sk_socket); --> Line 431 in net/bluetooth/sco.c (Access sk->sk_socket)
>>
>> the variable sk->sk_socket is accessed without holding the lock
>> sk->sk_callback_lock, and thus a data race may occur.
>>
>> Reported-by: BassCheck <bass@buaa.edu.cn>
> Need to check in detail what it means to hold the sk_callback_lock,
> btw is this static analysis tool of yours something public that we can
> use in our CI to detect these problems?
>
>