Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <136984f7-b9a0-721f-3e31-f6ef840b0878@oracle.com>
Date:   Mon, 1 May 2023 13:31:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 3/5] driver/perf: Add identifier sysfs file for Yitian
 710 DDR
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>
Cc:     James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1682329456-19418-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1682329456-19418-4-git-send-email-renyu.zj@linux.alibaba.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1682329456-19418-4-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXJFdTJMeFJabFhSZlpzazVaUXNheHRyL09QU21GODhodVVtNVhyOGtnUHlH?=
 =?utf-8?B?VGZWaTR5RU4za3VnOFZSNE9WbWc5aTR0cFVMR3gvdEtiNGxiZm1aaEJKbUlY?=
 =?utf-8?B?amUzSDlPZnhwZC9EeE1GcWFWT1BTRDhoUkpiRUR1ZlRtbDliN2RXSWtNMGNu?=
 =?utf-8?B?a2lBRm04Q3grL1JhdVpvNm9CVzVrTmYwdVVGR3ZTRE9lYWpOQmUxVExnbTJT?=
 =?utf-8?B?bkc5UERKb1pYQTFuRmNUN0gvUUlEcnB6amFQWmVxUm4zY3MvSHVXTEQxb3BR?=
 =?utf-8?B?aHZGOGhjNnA5d09aSzFsdnlZaXVGa1hIaVNKRkJ6dkpMVG1mNXFlMHVLQmNm?=
 =?utf-8?B?Y3phYUhSaUVGY0U2UllRbVRIM0dZeGtLdnB6RE14TzRrc0xuQkl6dDJpV25L?=
 =?utf-8?B?UzlOMFA5TEpkaU5MZlF1QnRNSU9tcDRyVHVOZHJtdlBlU1ZyczE0dzNRaDQ1?=
 =?utf-8?B?M01hdlZiTGxrYmVvWUt0V2JldGxkL21uN2dXUHdmVGwvVHB5ZzRjaHhtRk91?=
 =?utf-8?B?TkthNDROSVFMMlIyWGdyZ05KRU5BMnFhNHBYdEFqRXV2bi9KdGhZK2JwMytX?=
 =?utf-8?B?ajZJUmhCbmVKNGRaRjVjMlVmQUdVU3NFZmY0Z2Z6cUpsVGgzV0VMSEpFM3h1?=
 =?utf-8?B?NHlYZmFaODNZanlqUUZiUVhIbFBrR0RNSnNXcFNnQjVwWHE0dkxEdXo3SDNY?=
 =?utf-8?B?OGZoWEhzS3pHMUdrVFJFK0hmUldzRExhejlQcU1JYm85VEVXVHNUTjU2R25w?=
 =?utf-8?B?Z3pRNS8yQnRXN3BNTndYM2tlN3BDM1R1SVNhY3VEbzZkdUQ0NDh0V2cxR21Z?=
 =?utf-8?B?dnFDamJJbVpLWTBHTGdQQjljMXNISXpvVFRocndHR2l3TGtOT0ZzenkxTE1a?=
 =?utf-8?B?b1hEY0FQZXBTeWNqdXo4R0c3cWJKeWZxMEd6NEtVdDlYL2ZuRkk4SXVqOW9l?=
 =?utf-8?B?cWIwdUdNTisyaEdUenNpOGFHZVgweVJCVmhLLytZb2VoZFI1VDQ0ZzZqQzhl?=
 =?utf-8?B?MEVRaUUyRmgxSm9rbWEyUG5NdzZYclA5Nng2dEZMNmVhcmJPbi9WOFE1NEtN?=
 =?utf-8?B?V2dhS05zVXVaWlVFSFpkS0xJaVhOUGxoSnM5L3YwYUFhMlhka05MWC8yaFI4?=
 =?utf-8?B?MDJWNGdhc0h2Y0ZWdTNHeDRFajMyenV5VGdKR1RFRkpjMGRyeThxaTdMREVL?=
 =?utf-8?B?dHlsbW1KcldpY1FUa3dBYmpYZTdYRWZYT1BaMXdoVDhhMmR3djVlZmxlOUt6?=
 =?utf-8?B?RTRPalN6L3FMRUgyQUc3MG5NbkQ5ZCtpU1Awd3lFYS9GWUMvWHYvdG9MSWox?=
 =?utf-8?B?VHJScS9Edm5IZUx0bCtMRVRlMlBJYmNzdnpJdk1mZ0ZxLzJKWmVWZVd6bll6?=
 =?utf-8?B?QmhDUVp2YUVYMTNUT0tFMmE2Zm1nV3NyM2F2eTFZZ0xyY0xNaC94R09Ua1FE?=
 =?utf-8?B?SHg4NVBic1ZIZDY3YXBzbm1PaG5XTG5WVGdNQkRrWldkRjY2MHpWUWRnbHpN?=
 =?utf-8?B?czZFbGlCOXZFSk1rUmprQUNKYkFjWU1heUhNZzRPSkVlM21lSWVsaXFzcTNl?=
 =?utf-8?B?K255N2VqcW1jZ0pFd3J1T1ZRVkx6SUVWZ2xUKytTcG12K3BDM05tNm04MEpY?=
 =?utf-8?B?RXQ2SmFMdldGdWRqczV3SzlENTJlcFhUNTcySjFDQVZFRzZSYVFVclBjR3Zt?=
 =?utf-8?B?VmJSMzNuYzlBMC9GOXMwdGh5dzNiZ2VXV2dCTlBrVTNXKzAxRk8xZlpFQXNM?=
 =?utf-8?B?dWlCMlNRZEM3ek9HaXM5N2htbmJVTTNCZzR0TmhPZGFkREVvekRmajEvMUJE?=
 =?utf-8?B?c3JaNkE0R1hZd295S0tYOCtkVDRXVTRvTmFrZTJBVzJOaXpiVUVTZzhPZTBF?=
 =?utf-8?B?cllnNTZXWUxuWXFLN0RjNm5xa0xPblhFY2xzcW5pYXE1SU5kRmQvamdqbldV?=
 =?utf-8?B?NUMrbEZtM3NMeEQrNTRsNWFSNGZSTkF0STdBREpHRnNvRUQ2dmNxZ0tQRlpk?=
 =?utf-8?B?elBIVk5ZNFFvemtqZUJTdWl1bDU0TEYrZFRUWVF1QzdLUGlLdWdrWVN5V0Fq?=
 =?utf-8?B?bXZES0lJWmdnVDJOWlVUU0dEaGY4WVVSYmtZVmM1SmtCVnY5UWdCYzVqbUxw?=
 =?utf-8?Q?KUsS877LsW47vE1sNDJ/tjlpu?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?K3dENVlVYjUzaHgwTk8xallpbkwrcGpqZG4yVmRLNGpUdEFUakxFaVVHMm95?=
 =?utf-8?B?S2lyVm4wYzdJR0UrYXFEZlFEb05CbUozenpPK3l6YWREL2tocjJ4OTFFcVhN?=
 =?utf-8?B?RENEWFRJRDFiYnNES2dQUFRBOUhrSGR1MlZ0U0dyaGUyK2gyOEFXOWlFNmt2?=
 =?utf-8?B?N0kzMldjU2RQeXhGWmV2aWdPMXAxdW1JZEVuT3RaVE14Y2ZLNnNUNEpNYnNQ?=
 =?utf-8?B?RW51emxYL3dzUER4ajZWdGdYb3BLakh0N2swRmNWdDN5T1FwL3lhQVl1bFBK?=
 =?utf-8?B?Q2t6RWU2OWhNRnlvQ1kybmpJNVhhbit1UFZ2dUhWSW1rbTRYOEhPOE02cW53?=
 =?utf-8?B?S2RJT0g0cWxhQ0I4NEp0emtYMU0zd04ybjJwOVRDWVNOMGxacFd4a1Z6NE04?=
 =?utf-8?B?d1F6TW0yTGYrS2hMTzhnYzNwdE9BV3ovRjBnYmFQRHNYUE5YeU9ndFk3dzVD?=
 =?utf-8?B?SlRUODNrVjYydU1haXlEV25FWGVWVXM0V3pYVHlwMm9CeDRidmlkNm9DaHVX?=
 =?utf-8?B?NGw4c3RORGplelpjOHB4dk10MHlkSVJpdHI4ZlIzd016cmljY0NOREt6VDJJ?=
 =?utf-8?B?VHdheUFmVGZyTjNRTlE2RllPRlYxVGNkY2F4eTk5MVZEOEtVbDRSdmo3ZmR2?=
 =?utf-8?B?T0k3c3RKREZxWG44UDhGeXVxMG95Mk84Q2FtVEtpM3BMVkkxc1daMkczUTI0?=
 =?utf-8?B?ZzR6alB4c3lVanpVdHFMT1haeU1aVWV4SE5ody9vMUVMYnVENXVPaTVDT1F1?=
 =?utf-8?B?eVRpQW9laHU5d2wzZkd2WnoyR3BZdXdKTlRwYXlqNXI4ZzZBemU5UDAzakQ5?=
 =?utf-8?B?U1VzRW45c3hlRzJNWTMweVZaVjZscjJTT2VaRXBKOUVMQXFtOGIrRC9NbFFy?=
 =?utf-8?B?NG13VVFOSkM0cm1paVQyelpSeS9pR2UxVm43a3pNM3l1U25hS3BUZmFnenZK?=
 =?utf-8?B?dHA4SG9WUS9vNEdVM1hhMzhvY3NXWWVVN3h3MWVLaVdHNlNNSklkSENZcitT?=
 =?utf-8?B?emRiVi9YNEVCYXRBOTBUR1hkZmdZN1hyMEwxZ0tHbllGZnlhZzI5Q3NGZmE1?=
 =?utf-8?B?OW5yR0ZqYjgzODloTG5Sbm5SZmpRU3NYNjdZRlp6NVNMazNoWXg1eGtncWdN?=
 =?utf-8?B?YkxGREdQZ0wzWWl5V1hySU8vR3d4enNSbU9qNXBJanJ4Zm5DdVVPS2pyNWVP?=
 =?utf-8?B?ZEZNVkk4dkNCYXB2VXh4Mml5aXh6eVVjR0hES0RBUXJLUW93c0NVUVJVUmpj?=
 =?utf-8?B?ZUlYWGl1ekhtV1YvUyt5Wm1FdWtYM21zUUZxbmMrTkdsenBpRXpyM3NtSjIx?=
 =?utf-8?B?dEpqc0NMR2VoMS9WdFpyQkJScHVYSUN4YVV6ZFNYQTEveHFPRzNuVGt4cytQ?=
 =?utf-8?B?NExVaXVwZnRUSlpMcEorMCs5VTBRYzlOSk5ZbitaM2Z0VXRKcy9QdkpTeUZ1?=
 =?utf-8?B?dk9nanB6RjI5YWdmSW8yV2VzalNlU1Q5Vms0YmYzbzRNTTBnWFB6cDljMzVl?=
 =?utf-8?Q?BAsQuo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8dea01e-432d-4408-5216-08db4a400095
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 12:31:35.3318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J7BygDlQnQShCimPeLhK76TC8qEXvrOCuW1sXo9xz2zlhd2Yr1rREXesR8kg9nvKGLBb8lin+G7C8zJwCwsVfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5400
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-01_06,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305010099
X-Proofpoint-GUID: t3nsChIGo-2oyzrSOh4qC9HDJTIRfJ70
X-Proofpoint-ORIG-GUID: t3nsChIGo-2oyzrSOh4qC9HDJTIRfJ70
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/04/2023 10:44, Jing Zhang wrote:
> To allow userspace to identify the specific implementation of the device,
> add an "identifier" sysfs file.
> 
> The perf tool can match the Yitian 710 DDR metric through the identifier.
> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>
> ---
>   drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++++++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index a7689fe..fe075fd 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -236,10 +236,37 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev,
>   	.attrs = ali_drw_pmu_cpumask_attrs,
>   };
>   
> +static ssize_t ali_drw_pmu_identifier_show(struct device *dev,
> +					struct device_attribute *attr,
> +					char *page)
> +{
> +	return sysfs_emit(page, "%s\n", "ali_drw_pmu");
> +}

Would there be anything more unique per implementation version? Having a 
constant like this means that all implementations will have same events 
from userspace PoV.

Thanks,
John