Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df63b597-4355-b9fc-6002-5a390b1a56f5@oracle.com>
Date:   Mon, 1 May 2023 13:38:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 1/5] driver/perf: Add identifier sysfs file for CMN
Content-Language: en-US
To:     Jing Zhang <renyu.zj@linux.alibaba.com>,
        Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>
Cc:     James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
References: <1682329456-19418-1-git-send-email-renyu.zj@linux.alibaba.com>
 <1682329456-19418-2-git-send-email-renyu.zj@linux.alibaba.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1682329456-19418-2-git-send-email-renyu.zj@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDA3dVFMcmZlMUpacTRQc1NVMmFZVVhLeDkrQWRMa1FaS0ZjOXFpM2dVaCtj?=
 =?utf-8?B?dWlqY05JTEFnRVNPL0JoVXNDMzRhZEY2WUdlZXpwQkoya2RDa0xvODBNNXUv?=
 =?utf-8?B?NURvWUlBY1BNNmRhZTJ5MGExbitzQWpJa2dJSmt3SjdUNkRTM0RUeWdJd2xt?=
 =?utf-8?B?NFdiRDdrMlJhYjZyVVhibjRtUVlkam9pMmtaUXpQSFoxZFhQTWRRSnZmY200?=
 =?utf-8?B?aVdHbHBRdXhCODI0UXVZQlQzMmpHRlllZmxiNnhDYWVCUEhzWG9OYUlpTlpX?=
 =?utf-8?B?dXRwUGVJSDZ5cmRFMFY0TGpjdm1laXJHRnQrUzcyV1lhV1FqS2RySmdFVUtD?=
 =?utf-8?B?WFZmMlBIVDBLWVV5aGdOVXVTMkN4Y0FKZEQ4QTFUODJyZ0xuaUErN2w1VGk3?=
 =?utf-8?B?Uk5rcEhIQ2w5WFBxQUZkYlo3SkdPY3J5Ymh1OXJ5czNRdHB1UWFQMHg4OC8w?=
 =?utf-8?B?ODdiTzRrUmgrTHVXUTdCcTZNWkRLeXlrV0x0T2ZPbXhpZU1SM0ovSVk4bjcr?=
 =?utf-8?B?RjFoalNYTlBLR2JpRDJERzc4TGpKRy9ZWmZJdEl2Rm90RGEyOEJxQi82TEVQ?=
 =?utf-8?B?UWw3cHZxZVp4d1h2eHFRNW8wQ0hLV3BtbldNRzhzcmt0aEFpYjRTdlVXaSt2?=
 =?utf-8?B?aDNSM2hpOUdVOUV1NGRHKzFiYXBDMWpnOFJtVEtjSzVQRzd4QngydTN0cUtq?=
 =?utf-8?B?ZDEvU1hqeEI5Zi9RSXhWTlVTNWN3QndoY3A4OUdQRWVyTnZua09WbGlCNk1R?=
 =?utf-8?B?V3hrTlVTVzZGcVptWXBSZUF5NEQxemFBK3hCTkVvYm1NK255MHZsVlVqeHJH?=
 =?utf-8?B?a0thRzd6RTI2Z1JVaG5hR3JlNlhsdE5qRm0xS3Blejc2NTdCaTd2bU9qYnFZ?=
 =?utf-8?B?aUVmdjBWRStRWlBtL1A2MlpkUVNBd2E2U2JrdlBralhPZnlnZXJ0anUrZ3Fm?=
 =?utf-8?B?ZlpFRVYvVkhyd2swc1IzZWsxYW1oSXgzM0ZML21va0h2WEpYRlNOM0lnRmlY?=
 =?utf-8?B?S3V6NnlWbTFEVk1lYWVuaHMrMEp0c0Vha205Y1RlSzZJbzFiS1p6dWtqRk12?=
 =?utf-8?B?b2NJaWVKQmR1ZWdXT2JQMkR3SnkvSTdNY0o3ZGJlb0NyajY0TkhUOHdseVZq?=
 =?utf-8?B?QkJOd2tPTVE1RDNjaXlkeVpuVGFNYnB2alRUeEErN25MUzlpS0h0UnRsUElY?=
 =?utf-8?B?cThVanBiOGswVmpFSm9pV0gySjRRcjFzblorazU4KzI4dEFaeGFoZjNBUzQ5?=
 =?utf-8?B?SnROanJRVzFQOHJ0bC9pU2Vid2l4eDFoTlhCUW5ReC9FM3l1UVdjalRlWnpm?=
 =?utf-8?B?aXJJYnpITTAvZUI1a1BuMkpKZ1BDY2Y1ckh3SlNtdG0rYVhzbkhuTWxvVmZQ?=
 =?utf-8?B?M28vcDAyZW43MFIvT0ZHM3A3NzJ3WVJoMHc1Q3FLbGVwSktZNUQyaVRqSnA4?=
 =?utf-8?B?TVQxbU5IS3JUaEdJM2dMcnRvRjBwazJ5bGdTdHpGTlQ5WjRQYmVoaDRNVzI1?=
 =?utf-8?B?OFVGTC9heVc5UUlDNEhuTzZWazhUVzZtazVWOHBmdEplbUlnN1BldTZ4VWNp?=
 =?utf-8?B?OFBGd29xR1JTaUdPMXdPNTVEdnJXeWl2cndQWjc2MCszc21DZ1l3R0pvUThj?=
 =?utf-8?B?UmwzaTJpaFo2YVoxSjFBOUlIVTU1djl2bmdhWEgrd3hwZS9jdXhvaGIvWUhr?=
 =?utf-8?B?ZXdpOFBLZ2xJNzJhQ2lScTd2QjEyenByaGNJZktCazJIQXRBNFU2Vzg2ZVho?=
 =?utf-8?B?SFMwWENTRDJEVUlVb3hNSDBCbG1HMmt0Q0g0SUM4WTcvZUxuNFF6U2oraTdx?=
 =?utf-8?B?Qm9ZN2tqa3dGZ01UdCt2eXIzNm90OFpCNkpqQXRKaXAyTGZhalN5ZnRDd2NT?=
 =?utf-8?B?bCtER0FqVmFhTk1UMDRMYXZISDdWdWNVQlRGc1dhdE9mQnBxWDNUWC91Ui9H?=
 =?utf-8?B?aitQUHhQMHBIZ3Y4SEpEOExHTURiUUp4QU0zdFhMVVVwWDFtR3hkc0xmS0FK?=
 =?utf-8?B?QTRlQjJaN0hYeVZEUmdiOVVwRi93bUwyemwvWFFUSG1vb1hlQ0luakxYU0Fw?=
 =?utf-8?B?TkpCMzhZZ1J0bUc3Mkg2S2hxclFsc0hWRk1rbkZZeS9QbEcvdVRZdk40SnM4?=
 =?utf-8?Q?c3lB749oAtjn+GkW1HFyt8bSh?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Ti9TN1kxQytzSTV6S3RKbnhFTlpCVTE3ZUZNTm1FTVRYa2hHRFBieUN6WFIy?=
 =?utf-8?B?N1RxYVQ3eldmTDFkcHp4cHlOUkxGZnlMMzRCREdkeTVwS1ArRmp2bWh4L1RF?=
 =?utf-8?B?SEJOS0p6ZTJFdXh0YUN2Y2JXK0VERkxqUnRjeXlmYllaaHZYQi9LaWNIMGlx?=
 =?utf-8?B?SlFlMDlHSVk4b3lnWXBqZm55dFpwWmoremhFNjY0VXlmUDhzcHQxY1hLZUpy?=
 =?utf-8?B?YXRsZHMyZWNnVU55MVVqZTNkRTRzT1NsTDkwWjFzSlhDMzRLKzlyMDJ3QkJQ?=
 =?utf-8?B?MFFCWUkyeTMwdFo1dy8ra0xjb2JhMjBUQXNldVozQXFVdXFNYkVwZ3k1NHNB?=
 =?utf-8?B?YzlGRnExMXZpZi95cU0vRmxUS3dwcU1YNjlqbG9hRThDNDZxVnJVTGZVdTEw?=
 =?utf-8?B?amtIc0NaZWtaY05DRmx6YmFzWEV0amUrWHdLaVl3UHNwZ1ViTHMwRFFNNTlw?=
 =?utf-8?B?alg4UkZLVXpwVzROUHRGUVVvZmVSUHgrTXl1K2ZFVFUyWmFEdGpBczJZa2du?=
 =?utf-8?B?UUY4cGdVS1F1NDRmajd3RTU5c2phNkRyR3VqUGU0bXZ3WlR2TU96T1FpTXov?=
 =?utf-8?B?akZqb2RFc1BHOGhxOXJTWXFKWGRzRkpXV1hJcUZ4RWFHRFBPaEs0QXBnM1hT?=
 =?utf-8?B?QnpOcXhsSzgrdHFjcVFsZ2NNT0dwT3VIektXbjRicThibXdrN2d4aU12RWpn?=
 =?utf-8?B?eFU4ZENOSFJRcWVNNjFCdS8rdnNVUnVNWUZRUW9NeEFoWmVkUmFiQU1YZE0v?=
 =?utf-8?B?bXBoWWEyaGh5c2dTeFNjbzUvZFNsZ2labDBWNzhhbXlDUHFXM2NxNUZTYlZa?=
 =?utf-8?B?RFo0YkxOOVA3Nklkd1BSTG9UeVFwR2t4TmdrV1F0WUpIcktrMmVtTWl6d3JV?=
 =?utf-8?B?bDJZZVVmTVU5aFJUZ3NobGtleUVDQlFDdFFuNWhQTTkzcCtCalNsZXhFRHYx?=
 =?utf-8?B?N2F5d25tNkdTZzNVaVJKZG41Vm10NmVKN0sxUVF0TURGME1qU2xmamQ4aUls?=
 =?utf-8?B?L1QzTTFHMElaSE9lYThMZW04UHFLZG1KMEhmZjRSRnBaSUJpVEQvL3dkNGFJ?=
 =?utf-8?B?Z1RTSHR0Zmo0YVlWaW93YW5udm9oaWRzeUNUSHN6aGhDcy9LQks1UXZtK1dp?=
 =?utf-8?B?OGNKb3NFeEhMNkFNMmYvSCtOVDB1c2JTWHdzT3NhVEtJQVhaWngvYmpIeHp5?=
 =?utf-8?B?TXNSOXplbGhCdmUxcTk2Nzl4eUkwVm9TazhnRTBvcENWUlpvOTZkRUNGanZj?=
 =?utf-8?B?NlZCZGluaDdmVUx2U2tTSENFdit4MDNhKzZhdE9EaXhDalRRVU1BdUxyNkpD?=
 =?utf-8?B?UUVqZ2p4T3MwbWdaM0JzS0piVUQxcGRyZE1BSW0zcW1MMmJ6Sis3UjkyQzR3?=
 =?utf-8?B?dzJXMjZtOXlqa2xESTBpbVB3UEZmVGNuRFp1WWkveFpZa2xqdTZ6TjE2TUk1?=
 =?utf-8?B?UC9Fa2hvcXVuMGwrT1FaeSt1OWloY1JuZWUxZUF1Unlwa1B4UjVlNitNKy94?=
 =?utf-8?Q?Q/KytU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ad064f7-f538-4f07-a5f3-08db4a40e99a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 12:38:06.2784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VnnI10zSYARIA9oG8r/1gCR0LgwhofRsAS5X7TzVEAVbvh1576JXkvgiecTLOyi3/d292735o9sIQpwgrshiGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6563
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-01_06,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305010101
X-Proofpoint-GUID: g1uW13EdCxH8Jtoqr4taz9iOZAoUr4Aq
X-Proofpoint-ORIG-GUID: g1uW13EdCxH8Jtoqr4taz9iOZAoUr4Aq
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/04/2023 10:44, Jing Zhang wrote:
> To allow userspace to identify the specific implementation of the device,
> add an "identifier" sysfs file.
> 
> The perf tool can match the arm CMN metric through the identifier.
> 
> Signed-off-by: Jing Zhang<renyu.zj@linux.alibaba.com>
> ---
>   drivers/perf/arm-cmn.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index c968986..f425610 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -334,6 +334,7 @@ struct arm_cmn {
>   
>   	struct pmu pmu;
>   	struct dentry *debug;
> +	const char *identifier;
>   };
>   
>   #define to_cmn(p)	container_of(p, struct arm_cmn, pmu)
> @@ -1168,10 +1169,41 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev,
>   	.attrs = arm_cmn_cpumask_attrs,
>   };
>   
> +static ssize_t arm_cmn_identifier_show(struct device *dev,
> +		struct device_attribute *attr, char *buf)
> +{
> +	struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev));
> +
> +	return sysfs_emit(buf, "%s\n", cmn->identifier);
> +}
> +
> +static umode_t arm_cmn_identifier_attr_visible(struct kobject *kobj,
> +		struct attribute *attr, int n)
> +{
> +	struct device *dev = kobj_to_dev(kobj);
> +	struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev));
> +
> +	if (cmn->identifier == NULL)
> +		return 0;

nit: generally if (!val) is preferred

> +	return attr->mode;
> +};
> +
> +static struct device_attribute arm_cmn_identifier_attr =
> +__ATTR(identifier, 0444, arm_cmn_identifier_show, NULL);
> +
> +static struct attribute *arm_cmn_identifier_attrs[] = {
> +	&arm_cmn_identifier_attr.attr,
> +	NULL
> +};
> +
> +static struct attribute_group arm_cmn_identifier_attr_group = {
> +	.attrs = arm_cmn_identifier_attrs,
> +	.is_visible = arm_cmn_identifier_attr_visible
> +};
> +
>   static const struct attribute_group *arm_cmn_attr_groups[] = {
>   	&arm_cmn_event_attrs_group,
>   	&arm_cmn_format_attrs_group,
>   	&arm_cmn_cpumask_attr_group,
> +	&arm_cmn_identifier_attr_group,
>   	NULL
>   };
>   
> @@ -2241,6 +2273,22 @@ static int arm_cmn600_of_probe(struct device_node *np)
>   	return of_property_read_u32(np, "arm,root-node", &rootnode) ?: rootnode;
>   }
>   
> +const char *arm_cmn_identifier(unsigned long model)
> +{
> +	switch (model) {
> +	case CMN600:
> +		return "cmn600";
> +	case CMN650:
> +		return "cmn650";
> +	case CMN700:
> +		return "cmn700";
> +	case CI700:
> +		return "ci700";
> +	default:
> +		return NULL;
> +	}

nit: I think that it would be nicer to have this per-model string stored 
statically in arm_cmn_acpi_match[].driver_data and 
arm_cmn_of_match[].data, so we have a straight lookup

> +}
> +
>   static int arm_cmn_probe(struct platform_device *pdev)
>   {
>   	struct arm_cmn *cmn;
> @@ -2254,6 +2302,7 @@ static int arm_cmn_probe(struct platform_device *pdev)
>   
>   	cmn->dev = &pdev->dev;
>   	cmn->model = (unsigned long)device_get_match_data(cmn->dev);
> +	cmn->identifier = arm_cmn_identifier(cmn->model);
>   	platform_set_drvdata(pdev, cmn);
>