Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756043AbXJASUe (ORCPT ); Mon, 1 Oct 2007 14:20:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752794AbXJASUY (ORCPT ); Mon, 1 Oct 2007 14:20:24 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:45591 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbXJASUX (ORCPT ); Mon, 1 Oct 2007 14:20:23 -0400 Date: Mon, 1 Oct 2007 11:19:57 -0700 (PDT) From: Linus Torvalds To: Christoph Hellwig cc: Zach Brown , David Howells , viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode() In-Reply-To: <20071001180601.GA9417@infradead.org> Message-ID: References: <20071001130921.29339.72876.stgit@warthog.procyon.org.uk> <20071001130958.29339.31669.stgit@warthog.procyon.org.uk> <20071001173930.GA7718@mami.zabbo.net> <20071001180601.GA9417@infradead.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 23 On Mon, 1 Oct 2007, Christoph Hellwig wrote: > > befs_lookup, which the above gem is from, returns a dentry *. Ahh, ok. Then it actually makes sense. Although I'd prefer it if people planned on writing code like that more along the lines of error = PTR_ERR(inode); if (IS_ERR(inode) return ERR_PTR(error); because let's face it, the compiler can turn this into nice code, and humans can read it much better even if it's got an "unnecessary" extra variable etc.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/