Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6835178f8f58f6fce7797953f64c3f4c959d6ade.camel@linux.intel.com>
Subject: Re: [PATCH v3 01/15] dmaengine: idxd: add wq driver name support
 for accel-config user tool
From:   Tom Zanussi <tom.zanussi@linux.intel.com>
To:     Fenghua Yu <fenghua.yu@intel.com>, herbert@gondor.apana.org.au,
        davem@davemloft.net, vkoul@kernel.org
Cc:     dave.jiang@intel.com, tony.luck@intel.com,
        wajdi.k.feghali@intel.com, james.guilford@intel.com,
        kanchana.p.sridhar@intel.com, giovanni.cabiddu@intel.com,
        hdanton@sina.com, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Date:   Mon, 01 May 2023 09:01:04 -0500
In-Reply-To: <d886d1dd-51c8-d2e6-940b-9e5041707c6e@intel.com>
References: <20230428205539.113902-1-tom.zanussi@linux.intel.com>
         <20230428205539.113902-2-tom.zanussi@linux.intel.com>
         <d886d1dd-51c8-d2e6-940b-9e5041707c6e@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Fenghua,

On Fri, 2023-04-28 at 17:14 -0700, Fenghua Yu wrote:
> Hi, Tom,
>=20
> On 4/28/23 13:55, Tom Zanussi wrote:
> > From: Dave Jiang <dave.jiang@intel.com>
> >=20
> > With the possibility of multiple wq drivers that can be bound to
> > the wq,
> > the user config tool accel-config needs a way to know which wq
> > driver to
> > bind to the wq. Introduce per wq driver_name sysfs attribute where
> > the user
> > can indicate the driver to be bound to the wq. This allows accel-
> > config to
> > just bind to the driver using wq->driver_name.
> >=20
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> > ---
>=20
> ...
>=20
> > diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> > index 7ced8d283d98..505118fc19de 100644
> > --- a/drivers/dma/idxd/idxd.h
> > +++ b/drivers/dma/idxd/idxd.h
> > @@ -214,6 +214,8 @@ struct idxd_wq {
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0char name[WQ_NAME_SIZE =
+ 1];
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u64 max_xfer_bytes;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0u32 max_batch_size;
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0char driver_name[WQ_NAME_SIZ=
E + 1];
>=20
> It's confused to use "WQ_NAME_SIZE" for driver name size.
> Maybe it's better to have a new definition "DRIVER_NAME_SIZE"?
> BTW, WQ_NAME_SIZE is 1024 which is unnecessary big for storing=20
> driver_name[] in the structure. It would be better to have a smaller=20
> size (e.g. 128) in DRIVER_NAME_SIZE.

Yes, that makes sense - I'll add an IAA_DRIVER_NAME_SIZE of 128 and use
that instead.

Thanks,

Tom

>=20
> Thanks.
>=20
> -Fenghua