Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 May 2023 17:41:44 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Shannon Nelson <shannon.nelson@amd.com>,
        Brett Creeley <brett.creeley@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pds_core: fix linking without CONFIG_DEBUG_FS
Message-ID: <ZE/duNH3lBLreNkJ@corigine.com>
References: <20230501150624.3552344-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230501150624.3552344-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H0XRf+5xyYO2jPc25tYLWB32WB3CbWNWQTnfZM09Wyw0Wgi8vLFXVN/UJGbd?=
 =?us-ascii?Q?z15wupdj8VaGqT9LsC1F6HD1+qd7DQpXV2j3OSN9lTrFjNpl3gjRmqDg6wLZ?=
 =?us-ascii?Q?g/p9ZKqYPUwKGopkVpjTUC4hoATMLZJ+aAld5tosI0zEYdXA9OASwOpcN6kC?=
 =?us-ascii?Q?pGf0nwUNSO6ANfVhfnYOusZVLaGEp3zASsiH1u6jAyUt+gUeiWexAl1sw/2I?=
 =?us-ascii?Q?cL67Ukcs0KMS7xnhXBEcrUFNNs4YhIe2gQJkY8rVHpngR4ApXZvMkFDkuHxr?=
 =?us-ascii?Q?S3WYYOd198AKly17RbdgBBq71r5ISVVuu+g8//BhsgnWfYmScZoK27LKEd/1?=
 =?us-ascii?Q?6JrwAcb0D8557+wjmfhH7i97wMDtktt1SULUsLP7h4W9cLZPNWvoTSticten?=
 =?us-ascii?Q?KkSNr78JfkJn/OCjWH+D32rvnApfdg3Tdwi8tP3aH6VejCfMuIYoBPwkHMmn?=
 =?us-ascii?Q?2/lCtgmX3yyD2/A/En7rdTrJG7uiCDWJCagNKuQknN3JXty6wlPr2Hzu6Sst?=
 =?us-ascii?Q?3O7Nj/7I6Hun4O+RO9eHts33T0JI548FN4cgPAS1pl80woyXID4Vqqe6pqLR?=
 =?us-ascii?Q?nZEa2B43i6BEGtHTN3C/mQGv3wYRU5iw7M8rQPQT7GBF6Pmo/awcAqKrRI0I?=
 =?us-ascii?Q?emSFaxanqFcxv4rWL2GLhwAR8PDyfWzLxe3acih8cVt+fyjRM/hZfHS4B7CF?=
 =?us-ascii?Q?UAh0XzitkKhI7eaIoZejQQN2X5cCK2J0ybjoPb0ndB7fxdEClOsGcM+wcFBa?=
 =?us-ascii?Q?OHeQHFJT1Bpxm3H5EFtKQkystu0GSkes58vtJLbqnfyPenXjGTqp5DvrhwQN?=
 =?us-ascii?Q?TnPxzkBwGqa2cjBBM3BF6A3TZhcwC0/dxOTTFd4mdidxwJ3K5dmh6ZvuBo5Y?=
 =?us-ascii?Q?vCDQrj6z9t5Pr4tuQh4rpgXo+D7r6Xs0BzZAnQaCGw1ThapYPtbOyX3WQIRf?=
 =?us-ascii?Q?oj93hx6yiyslPLdaJWQA5kVaNCtCVDdC7HTY6Aahhc7a+B2UO0jKhvRZaTBS?=
 =?us-ascii?Q?zwuvDaeFlKjKQHbVquNB6VG/Mu+REhf90NfXRte01S/C/VjWV9GH4VOm64GR?=
 =?us-ascii?Q?tXSff9EKFFkqOhC3VKodz0BHhiLXttW0elOkNQzkHvqito8QoKP2hE69hsQt?=
 =?us-ascii?Q?8X4WFUarDl5nyUqcbvAr66/302dH0trZiGbkAeeBpEJKmHNt7xf+979WToPq?=
 =?us-ascii?Q?sJMFrHNxtKlD/6q9WG+KDPbxzuoKbOrp+UdO7f+gb+b1B+x12eGNW3J0HGza?=
 =?us-ascii?Q?TCjh6cS9YnKBHoI57UZlHs13iE9N2Q3rLnF/gSKYorKNXDfar36OK2Lhf+1b?=
 =?us-ascii?Q?mOLuL6SAWCiypHAR8py5w5kHSKZP44EaLUejWNFYKopo2F1M1X4P7yR3iE1j?=
 =?us-ascii?Q?WHGwyg+2CX6IQ+nvcCWMcFKjJxNRZ9A9us+Y64Mk/YsKGxElvbnv+yQZnVuN?=
 =?us-ascii?Q?MEeDgR4eefY+Zfiql1ovBHlWiMyMp6fEFYlO+TijKjfujaP+Kq/G5E1ke3Up?=
 =?us-ascii?Q?eHHPJlq/ISHC29CMXV7LwLcGIoT7BkWA9+K8wnFlnkkhrn/3wbIKihRwqMzA?=
 =?us-ascii?Q?l88vyKDD6ksfF5ATpODulD19yLaZhstj9eE2uHXemSn3bD5+vLWImUJPKFUb?=
 =?us-ascii?Q?yX3Yoqxv2nelr4DZPXfWzsiYswPiw/U5AJQWe+dBvrT9Ly8vJfHss4pLO2OY?=
 =?us-ascii?Q?3sqpeA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: deaf7732-52a9-476a-e286-08db4a5a9427
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 15:41:49.8498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: og0nzpoxaq5yl74OkzN1Ll1oLG/jHLi1XAFpVUghiPO9UCS1lVS68zKXB1VFOoiwoJRtYdYWKUyqZ96YQdMSllJHNsUFxGJB0KpbsVyXOKo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5538
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 01, 2023 at 05:06:14PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The debugfs.o file is only built when the fs is enabled:
> 
> main.c:(.text+0x47c): undefined reference to `pdsc_debugfs_del_dev'
> main.c:(.text+0x8dc): undefined reference to `pdsc_debugfs_add_dev'
> main.c:(.exit.text+0x14): undefined reference to `pdsc_debugfs_destroy'
> main.c:(.init.text+0x8): undefined reference to `pdsc_debugfs_create'
> dev.c:(.text+0x988): undefined reference to `pdsc_debugfs_add_ident'
> core.c:(.text+0x6b0): undefined reference to `pdsc_debugfs_del_qcq'
> core.c:(.text+0x998): undefined reference to `pdsc_debugfs_add_qcq'
> core.c:(.text+0xf0c): undefined reference to `pdsc_debugfs_add_viftype'
> 
> Add dummy helper functions for these interfaces.
> 
> Fixes: 55435ea7729a ("pds_core: initial framework for pds_core PF driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>


While exercising this I noticed that building pds_core fails
if either CONFIG_AUXILIARY_BUS or NET_DEVLINK are not enabled.

I think the solution is for PFS_CORE to select both CONFIG_AUXILIARY_BUS
and NET_DEVLINK.

I am wondering if this is on anyone's radar.
If not I'll send a patch.