Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230423123828.1346511-1-aford173@gmail.com> <DU0PR04MB9417FF20BEDB110DE49FB7F388679@DU0PR04MB9417.eurprd04.prod.outlook.com>
In-Reply-To: <DU0PR04MB9417FF20BEDB110DE49FB7F388679@DU0PR04MB9417.eurprd04.prod.outlook.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Mon, 1 May 2023 11:17:48 -0500
Message-ID: <CAHCN7x+A+=mYKLTX6JedQM=oBz=HmM=E_Sv5VxqWqyyjQeFDcQ@mail.gmail.com>
Subject: Re: [PATCH] Revert "clk: imx: composite-8m: Add support to determine_rate"
To:     Peng Fan <peng.fan@nxp.com>
Cc:     "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "aford@beaconembedded.com" <aford@beaconembedded.com>,
        Abel Vesa <abelvesa@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Apr 23, 2023 at 8:43=E2=80=AFPM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: [PATCH] Revert "clk: imx: composite-8m: Add support to
> > determine_rate"
> >
> > This reverts commit 156e96ff2172518b6f83e97d8f11f677bc668e22.
> >
> > This patch was found to cause some division issues on the i.MX8MP which
> > causes the video clocks to not properly divide when division was greate=
 than
> > 8.  This causes video failures on disp1_pix and disp2_pix clocks.
> >
> > Until a better solution is found, we'll have to revert this.
> >

Abel / Stephen,

Is there a way we can get this applied and put in for RC1?  When I
originally did this, I only tested with Nano and some brief testing
with Mini, but  it wasn't until I tested with Plus that I found
issues.

thanks

adam
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> Indeed we already see issue in NXP local CI with the previous patch.
>
> Acked-by: Peng Fan <peng.fan@nxp.com>
>
> >
> > diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-
> > composite-8m.c
> > index 6883a8199b6c..cbf0d7955a00 100644
> > --- a/drivers/clk/imx/clk-composite-8m.c
> > +++ b/drivers/clk/imx/clk-composite-8m.c
> > @@ -119,17 +119,10 @@ static int
> > imx8m_clk_composite_divider_set_rate(struct clk_hw *hw,
> >       return ret;
> >  }
> >
> > -static int imx8m_clk_divider_determine_rate(struct clk_hw *hw,
> > -                                   struct clk_rate_request *req)
> > -{
> > -     return clk_divider_ops.determine_rate(hw, req);
> > -}
> > -
> >  static const struct clk_ops imx8m_clk_composite_divider_ops =3D {
> >       .recalc_rate =3D imx8m_clk_composite_divider_recalc_rate,
> >       .round_rate =3D imx8m_clk_composite_divider_round_rate,
> >       .set_rate =3D imx8m_clk_composite_divider_set_rate,
> > -     .determine_rate =3D imx8m_clk_divider_determine_rate,
> >  };
> >
> >  static u8 imx8m_clk_composite_mux_get_parent(struct clk_hw *hw)
> > --
> > 2.39.2
>