Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83fd1a29-3af2-e2b7-02ea-edbaead8103a@amd.com>
Date:   Mon, 1 May 2023 13:36:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 01/10] crypto: ccp: Rename macro for security
 attributes
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        John Allen <john.allen@amd.com>
Cc:     David S Miller <davem@davemloft.net>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230428185543.8381-1-mario.limonciello@amd.com>
 <20230428185543.8381-2-mario.limonciello@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20230428185543.8381-2-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ri8yRU5GREg2R0duR1NoQ3Q1andjclVCWlkwZlV2RVV4a29zc3ovQVNJRTZo?=
 =?utf-8?B?WGhjNlZnaXpVNGFxNUZweHpxRGJzejBYbGh6cWVpNTRSYlVXOERpQmgycmRT?=
 =?utf-8?B?TGdIVldrNTROTmh6MTJwY2k3ekhaTHBSdU1VajBuRmo1ZHhyZVpZUVpaY3Fi?=
 =?utf-8?B?T2VCMm1GOGpKWmQ5aUcyVFNUSUxJcGtLc0FjWUJjUzR6U3ViS05KQnNZMGZ2?=
 =?utf-8?B?Q0tnaEVOcFJ0emRFSldNZ2hkMlA1VkMzRW53azZsMDYxV25jUkU0T1dDTUNh?=
 =?utf-8?B?cmZTQWFudnorSEpLdjBnSXlrak5ZcEt1QjhZVFdDOFpJampRWHZmNXFPMVBn?=
 =?utf-8?B?QTk0UnBjMGtZZFV3OERselFnazdOTWg2Y2tEY3dYSTUzcmVzOWRsaFUwNVky?=
 =?utf-8?B?TVV1TGt0YkNlc2w0OFJVdmtRLzNQd1ZoUkNVbG52cXpleVdod012VXFFa1NY?=
 =?utf-8?B?L2xKZnZXT05KS25OeWN2VVZFdjFMdUVQek01Tk9MTW11TGYzdkJsUkxhOUVz?=
 =?utf-8?B?MGV6SlptTTljYkwzbkpqWWJyWUxWOEdTd3BPVHBRL3FmZjZtcUYwSXR4MjIv?=
 =?utf-8?B?QXk1dnMrV0F1SXcxbzlTZkdqeExpc1NBcnc1ZkExZHlCa0NrcWozVFlHY2tu?=
 =?utf-8?B?Ri85aCsrMGU1cElMaW9JSDZiclVoSDRDMzNRY3dGMkFiN1Zkd1ZzNXMrakJ5?=
 =?utf-8?B?TWpQMGY5MUVOb3J0RmV2cFIxWUtud0hNMVU2ZUFjYlFmYU41aFd4MnR0Z0NE?=
 =?utf-8?B?S1R3Tk1qdjN0VUJqbVVSWGFBN0IvMkxjdGtQeC9maHcyV0JNQ1JsTE5Ba09x?=
 =?utf-8?B?K1oreUFBUW5PQUZDZ2lyTFpJSmZPS3FJZi9tSkhKV2dpL2lRRWJORTZ2aHhV?=
 =?utf-8?B?Z3dhTlM5V1p2YnVpcks3aG1seWdiWEZ1S0xFdkJVejRMTTQrNVRLQWJvV1FL?=
 =?utf-8?B?N01JaHVXNW15QjIrazhoK3JwSTRyOEFmSWwrSGsydTNVR0ZJNHBuV2l2OXJF?=
 =?utf-8?B?WWNqR1JwZk9Ddi9TeWwxbU55SHJKdFBYOFdMQzM1ZHNhb3hvRWtST05QdFR0?=
 =?utf-8?B?UThXMTlBQTVPaU9vaStCdmJJSEdjazlFZ2ROOE9aV2xleWRJYWNudWJzWU56?=
 =?utf-8?B?bCs0M29LQW8xeGJDWisyZldvaEsrSDV2RkRScFh0SnJ4cXZXbndId2xQNGFZ?=
 =?utf-8?B?NUltOVZ3TkpGL0tkK2JHSk5WUzFCc3NqN0tDY0piZDJ4WHZVVGNUcUJOc0Vm?=
 =?utf-8?B?RlpKR0FCWUd2NDQ5Mi9VZElheWZ0Qm44M1ZuUFlTK2Vua0ZHdHI4b1hRTDU1?=
 =?utf-8?B?YmZSQlkvRG1yK01aYlFkNTB4ZFI4YzYvWmNzZ3JhSWZEbUpUMjBBa3ZXbGVG?=
 =?utf-8?B?M1Y5L3BlWHJuMVpvc2ZzeFVEVkZGYzVWa2ZpNFk3TndnQVRockM0WFFhVGNB?=
 =?utf-8?B?dk8rTDBCb2tSK0xJR3lVRmhMQzBpOWdMWnR1a3hqMHV2cVJmcUwwSUN1RzVm?=
 =?utf-8?B?TUVPcmxLeWVJc25kOVRaWlBZa2VOa2tLUEFkaXZTM2Q0Q0FuRml0SFlZQlFu?=
 =?utf-8?B?aWcvTmlQbVl3UmVaY2xXTktRbDhtRkQ1eXA3NzZwQ0lnUXpFY1ZNSjVZQlFD?=
 =?utf-8?B?T0VMTVh2QjJYcWg3dkI5NFpBdGdGMGN5MXQvWk81TG9nU3NXT1p1RFYrMWZ0?=
 =?utf-8?B?K3M5NzEzMmJYY3gxODhweXJkNSszSEtVMlFOTlptN0dHUU4yNCtITkNvQVMw?=
 =?utf-8?B?VmpuMy9pVVZ0c2o3eExlTERCekhzeG9IOHdWRFd4QTlkdGhXYWw3dTZDWnRt?=
 =?utf-8?B?YWJ2dWp2NFlEM3dybFhTNlVGY2NwZmVoaXFSRk9EcDN2Mm9BeFhwbkh4QjRS?=
 =?utf-8?B?ZDB2Rmp0elRTVWY4MmhSaFRqdmUwWTczUFhhb3VBblNJT2kwakVVeFhrOU9R?=
 =?utf-8?B?ZDJMQVNBaWlGTW5rWFRHVDR1L3FpcUs1aXRhS2k5TmZ3MkRVcXVqbVlmc3RU?=
 =?utf-8?B?SUp1azF6QytMWlgvK3BHdEF1OFlVMmZYR0djRUZ3clB6ZU1MWEs1QkppMkVE?=
 =?utf-8?B?V2lWdTVDUCtFVElFTDh2S1ExczJRV0ZMSWREcTRnZGJwTDl5VWIzWVNKbjdU?=
 =?utf-8?Q?iqIeOzVxYDCAY44ULlsb9LLAE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 573fa655-cbe8-4129-f8c9-08db4a72f3d7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 18:36:18.3226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aefCNLGHCdt4Cn9GJ46gVxzRg5jj38iSQ4KSBBUyEY2c+Oq7A+P1C+RWc/u3aCaTXH75jzlzQgbGwFWzB1uhDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7708
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/28/23 13:55, Mario Limonciello wrote:
> The attribute_show() macro is only valid for determining the availability
> of security related sysfs entries. Rename the macro to better show this
> relationship.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/crypto/ccp/sp-pci.c | 26 +++++++++++++-------------
>   1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index aa15bc4cac2b..85e3dc8853e2 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -32,7 +32,7 @@ struct sp_pci {
>   };
>   static struct sp_device *sp_dev_master;
>   
> -#define attribute_show(name, def)						\
> +#define security_attribute_show(name, def)					\
>   static ssize_t name##_show(struct device *d, struct device_attribute *attr,	\
>   			   char *buf)						\
>   {										\
> @@ -42,24 +42,24 @@ static ssize_t name##_show(struct device *d, struct device_attribute *attr,	\
>   	return sysfs_emit(buf, "%d\n", (psp->capability & bit) > 0);		\
>   }
>   
> -attribute_show(fused_part, FUSED_PART)
> +security_attribute_show(fused_part, FUSED_PART)
>   static DEVICE_ATTR_RO(fused_part);
> -attribute_show(debug_lock_on, DEBUG_LOCK_ON)
> +security_attribute_show(debug_lock_on, DEBUG_LOCK_ON)
>   static DEVICE_ATTR_RO(debug_lock_on);
> -attribute_show(tsme_status, TSME_STATUS)
> +security_attribute_show(tsme_status, TSME_STATUS)
>   static DEVICE_ATTR_RO(tsme_status);
> -attribute_show(anti_rollback_status, ANTI_ROLLBACK_STATUS)
> +security_attribute_show(anti_rollback_status, ANTI_ROLLBACK_STATUS)
>   static DEVICE_ATTR_RO(anti_rollback_status);
> -attribute_show(rpmc_production_enabled, RPMC_PRODUCTION_ENABLED)
> +security_attribute_show(rpmc_production_enabled, RPMC_PRODUCTION_ENABLED)
>   static DEVICE_ATTR_RO(rpmc_production_enabled);
> -attribute_show(rpmc_spirom_available, RPMC_SPIROM_AVAILABLE)
> +security_attribute_show(rpmc_spirom_available, RPMC_SPIROM_AVAILABLE)
>   static DEVICE_ATTR_RO(rpmc_spirom_available);
> -attribute_show(hsp_tpm_available, HSP_TPM_AVAILABLE)
> +security_attribute_show(hsp_tpm_available, HSP_TPM_AVAILABLE)
>   static DEVICE_ATTR_RO(hsp_tpm_available);
> -attribute_show(rom_armor_enforced, ROM_ARMOR_ENFORCED)
> +security_attribute_show(rom_armor_enforced, ROM_ARMOR_ENFORCED)
>   static DEVICE_ATTR_RO(rom_armor_enforced);
>   
> -static struct attribute *psp_attrs[] = {
> +static struct attribute *psp_security_attrs[] = {
>   	&dev_attr_fused_part.attr,
>   	&dev_attr_debug_lock_on.attr,
>   	&dev_attr_tsme_status.attr,
> @@ -83,13 +83,13 @@ static umode_t psp_security_is_visible(struct kobject *kobj, struct attribute *a
>   	return 0;
>   }
>   
> -static struct attribute_group psp_attr_group = {
> -	.attrs = psp_attrs,
> +static struct attribute_group psp_security_attr_group = {
> +	.attrs = psp_security_attrs,
>   	.is_visible = psp_security_is_visible,
>   };
>   
>   static const struct attribute_group *psp_groups[] = {
> -	&psp_attr_group,
> +	&psp_security_attr_group,
>   	NULL,
>   };
>