Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 May 2023 11:58:36 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
        Lorenzo Stoakes <lstoakes@gmail.com>
Subject: mbind MPOL_INTERLEAVE existing pages
Message-ID: <20230501185836.GA85110@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VbB3VPmwKgm7ZyZwQJFS22VCG2vT/wbkee+8qTkX8ZaPf5IsB0cvqQaZYmi/?=
 =?us-ascii?Q?vaaNMYTaneAbxr+UKmqkKg7LS23r4IcGIo5F0PNmZy5NS9kQ/Ik9dhWneXSm?=
 =?us-ascii?Q?syn+oEf2f6bTy6iUWbA8JNGtpRBS0ljB92UktqTu1G4JNg5fbD34AN421evi?=
 =?us-ascii?Q?pwcgPt+q7Ib2nXuC2ndy8J/+gPe6oF1Zt6F2ZT9FQGGm5ohjxfahdGOwcS93?=
 =?us-ascii?Q?IdN5bSGd1CuLHNKOuaxf+R66dUX5k+JiXG7FOPXkAkCTFBZk4bFCuS6pkcH2?=
 =?us-ascii?Q?QkAoAn++HzQsd0N45leGCX3q5G4+s2VtqX7b3DH0qaNp3q/ocYzHEl9qSh3q?=
 =?us-ascii?Q?k1TO/sj44E+MeZ4L9Yc9O58y3bg9+gTC8hmn03ny2i/KD3deTJMTFcqvJv4l?=
 =?us-ascii?Q?MB7NJyLOElQp870Q57ICV2nVm8F/4bmENC1qQoMx1ZMtg3SmmPdd53+LYCkN?=
 =?us-ascii?Q?MIZAD800eVj3E2UEWKgMlYNR4lqLJexv5Y0K3YQFzHrRlT0oj3g+T3fThR8v?=
 =?us-ascii?Q?Rrl7lk3P2NtLqEZglgYM6MFcUB4JPhNBGY8wBzWuQdbmneJxYs7s2341/5MM?=
 =?us-ascii?Q?7hWDZnjotzm2LhDhbYfd2tE7TwBjSYJnXoI4HLgsMupJkUqHDUdBeFq9nX4x?=
 =?us-ascii?Q?ks9QnaRjeNb3NDFmDDLunODQjsYM7fs3tQ76HxePzIYgP1X7mYb7lLeth3PO?=
 =?us-ascii?Q?rDyH2uLGrMmio9YQmYAXQupHP9ixnE35iWGMRoR8xZA7dgKtzzy+B6nO+o1z?=
 =?us-ascii?Q?bqn0wly2ynyP268G0hdGaBR1eANJVMm7uPGoiQxAgvrsNx3UXGZlMGGggbMT?=
 =?us-ascii?Q?uKfI40atT3HT9hYt8m7SCvbuVf8cqaw3AhvDG0ofjcBLWnueGskg/zpG6TF3?=
 =?us-ascii?Q?pcaZAMsiGqrphhWOqPxfhPdt6j4fIs+Wd6yIW4Hm+c/TuLM4+VIishnZ/23v?=
 =?us-ascii?Q?HuU4vC6aphykowNQniwvdcdlCgIKSFRqA6GvPFN5tPqaD9ZLZSFrWQD5buOx?=
 =?us-ascii?Q?+5jj3KPv68EAMhkNW6BmTsoHiZgipJwnI47KZ/r8xAIpLIL36oF7flApM1kK?=
 =?us-ascii?Q?r7RdCt6imSoMkL1LSKC6KjXB2YjVzj7cOJyiTMPFwcinQabr5zxui/zHdo/t?=
 =?us-ascii?Q?egO++AI0AEjGFrI5oMNluasuxAcIL92ZWyhk5fi7pcmyFrNxRHu2HfV766Hk?=
 =?us-ascii?Q?BVNroDlb0SAQYyPDNwq2p3zL8Kugfz98lf08FJSzdSvVOmSXPQqTOocgWBDU?=
 =?us-ascii?Q?AeTC1b3OIsYmdjwrQyqYfm28HIpvu/bMetXYIOW8emiJv6mqhVokqoQ6X1rh?=
 =?us-ascii?Q?K65Ru1vFJOf0oEPzHLNvGnPyvUAU29gLP6XqkQ8fh8pa8hukcTizqIR/4YFW?=
 =?us-ascii?Q?mZ0kYwCwNTj4OYCZen53ETW7bqoQNLaBvXRVjgT9fUbmpZnmqD4HtAiti1Au?=
 =?us-ascii?Q?6fDjMNgwtIzPZDumGYt+fedrXXC7tSbb74TEzXaiT6+HlikRHF3cXziDvOYX?=
 =?us-ascii?Q?LGhXbViMoJ+0GNg/JWU1trAgA33euuh/721F398cCyRepqpt5K7XMns1Haei?=
 =?us-ascii?Q?hvZtva7n2XWxkgCNBqnhjT9Hk3uSx820U+AuDr+J?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: FWNOyn90sXQUzOhvm2PSTZclrGdtsxOtXuadTippL3ETOCPcCeTN3IFcCg+vsv8Q06CnMnJUPNJ2o/WNGUyf6fJhW71kwPkA0naBFV3mie6GPLdaC+tCWbulBS7enjqwXifBV0r6/WmKZkdKeBjQjUoIzBJO3gFrHgd7HdQoMMLVkaF+Vfk6rFXXANmsYWC67ZlUhmoJXiOF648IX//Y5IpqT9GpaQ/hhLoglfOLIY7PlpJYeeGcvA1skZfTtA4Kdy8vQWkl+iJWe9pexQdaV//E/cohBBMfG2tFES0rgUrYEvhvheJ22uyc4/w2nEWFlQX00pjHpfpA5Egc/bCMWKDOsRk6PEZoEAgN/AWeCOvhW/pnM0DYYt4Tn/1L9+RDagZE5O6YeQRzQ0siKht3EIqFeHfiiUD1DqLYQ+ndVGQKjQpe+nfAP6h0zJyIJenZSqvJRr5XPC64kCA01So1vzLdcG39objLc0pkRO3EnaIQVEaUM1X00p/VKLxBPx2cctozXxzCDGTSoYLj3kxKs6gv8Iz6p0dCRnfB0i8hTPfdlBYIFGaBnAm4psP0e7lPrgcAsne+V++RiyqpKf62aNbmGro8snfScUm36PGBhe5/kykwe/Kp+LuuWp3N1wo8Uu9f04xB3TYNQ/U0+dyquCatKSviVsxVvenBrGF2RVHW+7ftx4Hv/vI6KtKVu/nzq2z9HJu7L/JQDGIj0JX+ngNe4HGlQDi0OMwBGzvK5GFLS31x7fmeLvsARNbMpy4IbrSNPBD9j9URfMtd7pEJnsS4yzN5j8G7OKiuCCKxgO6eedgEv/7OZhz9TxUgO6K21jde9prY8zbKZ3XJErwFPGU2ftKrOv/E6d6yYHS6jWg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb0b7f4-d59d-424a-e43d-08db4a761321
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2023 18:58:39.2239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LLt5vEUZ0h2aCU/MrPcZtMe8DkIXK+aDfVjhFNkRPwOQroy8KKZdPiCZb0J4vUTXVMg/F12YLSb+k+7adtBPCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4454
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-01_11,2023-04-27_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0
 mlxlogscore=619 bulkscore=0 suspectscore=0 mlxscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2305010154
X-Proofpoint-GUID: lPRPTtc7DIuXccSWGKDDtI9oV6CpsO_W
X-Proofpoint-ORIG-GUID: lPRPTtc7DIuXccSWGKDDtI9oV6CpsO_W
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I received a question from a customer that was trying to move pages via
the mbind system call.  In this specific case, the system had two nodes
and all pages in the range were already present on node 0.  They then
called mbind with mode MPOL_INTERLEAVE and the MPOL_MF_MOVE_ALL flag.  Their
expectation was that half the pages in the range would be moved to node 1
in an interleaved pattern.

In the above situation, no pages actually get moved.  This is because mbind
creates a list of pages to be moved via:

	ret = queue_pages_range(mm, start, end, nmask,
                          flags | MPOL_MF_INVERT, &pagelist);

No page will be added to the list as queue_folio_required is called for each
page to determine if it resides within the set of nodes.  And, all page are
within the set.

I have reread the mbind man page several times and agree that one might
expect MPOL_INTERLEAVE with MPOL_MF_MOVE_ALL to move pages and create an
interleaved pattern.  My question is should we:
- Change mbind so that pages are moved to an interleaved pattern?
- Update the documentation to be more explicit?

I can do either, but just wanted to get opinions before starting.
-- 
Mike Kravetz