Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-374-g72c94f7a42-fm-20230417.001-g72c94f7a
Mime-Version: 1.0
Message-Id: <db973b45-a292-4924-a351-40bec063434e@app.fastmail.com>
In-Reply-To: <ZE/duNH3lBLreNkJ@corigine.com>
References: <20230501150624.3552344-1-arnd@kernel.org>
 <ZE/duNH3lBLreNkJ@corigine.com>
Date:   Mon, 01 May 2023 21:34:54 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Simon Horman" <simon.horman@corigine.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Shannon Nelson" <shannon.nelson@amd.com>,
        "Brett Creeley" <brett.creeley@amd.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>, Netdev <netdev@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        "Conor Dooley" <conor.dooley@microchip.com>,
        "Philipp Zabel" <p.zabel@pengutronix.de>
Subject: Re: [PATCH] pds_core: fix linking without CONFIG_DEBUG_FS
Content-Type: text/plain
Precedence: bulk

On Mon, May 1, 2023, at 17:41, Simon Horman wrote:
> On Mon, May 01, 2023 at 05:06:14PM +0200, Arnd Bergmann wrote:
>
> While exercising this I noticed that building pds_core fails
> if either CONFIG_AUXILIARY_BUS or NET_DEVLINK are not enabled.
>
> I think the solution is for PFS_CORE to select both CONFIG_AUXILIARY_BUS
> and NET_DEVLINK.

Makes sense. I just double-checked the other uses of these symbols
to see if they should be 'select' or 'depends on', and you are
right that selecting them is the correct solution.

There are two instances of 'depends on CONFIG_AUXILIARY_BUS'
in drivers/reset that both should be 'select' as well, since
this is not a user-visible symbol.

       Arnd