Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230429053506.1962559-1-irogers@google.com> <20230429053506.1962559-4-irogers@google.com>
 <d6784858-2a5f-7920-f1ac-d7ec9ed89605@linux.intel.com> <CAP-5=fUtgEvgburjhE6HpazDh9dtn=DiSOwHaVnoE3N7sBynEw@mail.gmail.com>
 <a7020f11-3915-58e9-9d9e-792672ecbd61@linux.intel.com>
In-Reply-To: <a7020f11-3915-58e9-9d9e-792672ecbd61@linux.intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Mon, 1 May 2023 13:48:44 -0700
Message-ID: <CAP-5=fV326=0PLb+SZF3nFwQhXpdtMtk6KV+zZNEcs1erW9i1Q@mail.gmail.com>
Subject: Re: [PATCH v3 03/46] perf stat: Introduce skippable evsels
To:     "Liang, Kan" <kan.liang@linux.intel.com>,
        Stephane Eranian <eranian@google.com>
Cc:     Weilin Wang <weilin.wang@intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ahmad Yasin <ahmad.yasin@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Samantha Alt <samantha.alt@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>,
        Edward Baker <edward.baker@intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Florian Fischer <florian.fischer@muhq.space>,
        Rob Herring <robh@kernel.org>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        John Garry <john.g.garry@oracle.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Sumanth Korikkar <sumanthk@linux.ibm.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Leo Yan <leo.yan@linaro.org>,
        Yang Jihong <yangjihong1@huawei.com>,
        James Clark <james.clark@arm.com>,
        Suzuki Poulouse <suzuki.poulose@arm.com>,
        Kang Minchul <tegongkang@gmail.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 1, 2023 at 1:25=E2=80=AFPM Liang, Kan <kan.liang@linux.intel.co=
m> wrote:
>
>
>
> On 2023-05-01 11:29 a.m., Ian Rogers wrote:
> > The events are displayed twice as there are 2 groups of events. This
> > is changed by:
> > https://lore.kernel.org/lkml/20230429053506.1962559-5-irogers@google.co=
m/
> > where the events are no longer grouped.
>
> The trick seems don't work on a hybrid machine. I still got the
> duplicate Topdown events on e-core.

For hybrid the rest of the patch series is necessary, ie the patches
beyond what's for 6.4, which I take from the output (ie not a crash)
you are looking at. As multiple groups are in play then it looks like
the atom events are on >1 PMU which can happen as the x86 code special
cases events with topdown in their name. Some fixes in the series for
this are:
https://lore.kernel.org/lkml/20230429053506.1962559-6-irogers@google.com/
https://lore.kernel.org/lkml/20230429053506.1962559-40-irogers@google.com/
and related:
https://lore.kernel.org/lkml/20230429053506.1962559-19-irogers@google.com/
and so fixing this requires some detective work.

I don't think it should be a requirement for the series that all
hybrid bugs are fixed - especially given the complaints against the
length of the series as-is.

Thanks,
Ian

>          38,841.16 msec cpu-clock                        #   32.009 CPUs
> utilized
>                256      context-switches                 #    6.591 /sec
>                 33      cpu-migrations                   #    0.850 /sec
>                 84      page-faults                      #    2.163 /sec
>         21,910,584      cpu_core/cycles/                 #  564.107 K/sec
>        248,153,249      cpu_atom/cycles/                 #    6.389
> M/sec                       (53.85%)
>         27,463,908      cpu_core/instructions/           #  707.083 K/sec
>        118,661,014      cpu_atom/instructions/           #    3.055
> M/sec                       (63.06%)
>          4,652,941      cpu_core/branches/               #  119.794 K/sec
>         20,173,082      cpu_atom/branches/               #  519.374
> K/sec                       (63.18%)
>             72,727      cpu_core/branch-misses/          #    1.872 K/sec
>          1,143,187      cpu_atom/branch-misses/          #   29.432
> K/sec                       (63.51%)
>        125,630,586      cpu_core/TOPDOWN.SLOTS/          #      nan %
> tma_backend_bound
>                                                   #      nan %  tma_retir=
ing
>                                                   #      0.0 %
> tma_bad_speculation
>                                                   #      nan %
> tma_frontend_bound
>         30,254,701      cpu_core/topdown-retiring/
>        149,075,726      cpu_atom/TOPDOWN_RETIRING.ALL/   #    3.838 M/sec
>                                                   #     14.8 %
> tma_bad_speculation      (63.82%)
>    <not supported>      cpu_core/topdown-bad-spec/
>        523,614,383      cpu_atom/TOPDOWN_FE_BOUND.ALL/   #   13.481 M/sec
>                                                   #     42.0 %
> tma_frontend_bound       (64.15%)
>        385,502,477      cpu_atom/TOPDOWN_BE_BOUND.ALL/   #    9.925 M/sec
>                                                   #     30.9 %
> tma_backend_bound
>                                                   #     30.9 %
> tma_backend_bound_aux    (64.39%)
>        249,534,488      cpu_atom/CPU_CLK_UNHALTED.CORE/  #    6.424 M/sec
>                                                   #     12.2 %
> tma_retiring             (64.18%)
>        151,729,465      cpu_atom/TOPDOWN_RETIRING.ALL/   #    3.906
> M/sec                       (54.67%)
>        530,621,769      cpu_atom/TOPDOWN_FE_BOUND.ALL/   #   13.661
> M/sec                       (54.30%)
>    <not supported>      cpu_core/topdown-fe-bound/
>        383,694,745      cpu_atom/TOPDOWN_BE_BOUND.ALL/   #    9.879
> M/sec                       (53.96%)
>    <not supported>      cpu_core/topdown-be-bound/
>            105,850      cpu_core/INT_MISC.UOP_DROPPING/  #    2.725 K/sec
>
>        1.213449538 seconds time elapsed
>
> Thanks,
> Kan