Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753715AbXJAUfN (ORCPT ); Mon, 1 Oct 2007 16:35:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751892AbXJAUfA (ORCPT ); Mon, 1 Oct 2007 16:35:00 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:59310 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751447AbXJAUe7 (ORCPT ); Mon, 1 Oct 2007 16:34:59 -0400 Date: Mon, 1 Oct 2007 13:34:58 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Yasunori Goto cc: Andrew Morton , Linux Kernel ML , linux-mm Subject: Re: [Patch / 002](memory hotplug) Callback function to create kmem_cache_node. In-Reply-To: <20071001183316.7A9B.Y-GOTO@jp.fujitsu.com> Message-ID: References: <20071001182329.7A97.Y-GOTO@jp.fujitsu.com> <20071001183316.7A9B.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 25 On Mon, 1 Oct 2007, Yasunori Goto wrote: > +#ifdef CONFIG_MEMORY_HOTPLUG > +static void __slab_callback_offline(int nid) > +{ > + struct kmem_cache_node *n; > + struct kmem_cache *s; > + > + list_for_each_entry(s, &slab_caches, list) { > + if (s->node[nid]) { > + n = get_node(s, nid); > + s->node[nid] = NULL; > + kmem_cache_free(kmalloc_caches, n); > + } > + } > +} I think we need to bug here if there are still objects on the node that are in use. This will silently discard the objects. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/