Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 1 May 2023 17:22:23 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Maximilian Weigand <mweigand@mweigand.net>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH v2 6/6] Input: cyttsp5 - implement proper sleep and
 wakeup procedures
Message-ID: <ZFBXvz17jDhEPI6c@google.com>
References: <20230501113010.891786-1-mweigand@mweigand.net>
 <20230501113010.891786-7-mweigand@mweigand.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230501113010.891786-7-mweigand@mweigand.net>
Precedence: bulk

On Mon, May 01, 2023 at 01:30:10PM +0200, Maximilian Weigand wrote:
>  struct cyttsp5 {
>  	struct device *dev;
>  	struct completion cmd_done;
> +	struct completion cmd_command_done;

Why do we need separate comletion? Do you observe some additional
traffic from the controller when powering it off and on?

> +static int __maybe_unused cyttsp5_suspend(struct device *dev)
> +{
> +	struct cyttsp5 *ts = dev_get_drvdata(dev);
> +
> +	if (!ts->is_wakeup_source)

I believe the idiomatic way to check this is to call
device_may_wakeup().

> +		cyttsp5_enter_sleep(ts);
> +	return 0;
> +}

Thanks.

-- 
Dmitry