Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: [PATCH v14 5/6] dt-bindings: clock: meson: add A1 Peripherals
 clock controller bindings
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <CAFBinCCdoaNuQymcjp5j9MHn2jpPWMqXe-+EgBo=5Ot8Bwaofw@mail.gmail.com>
Date:   Tue, 2 May 2023 02:38:20 +0100
Cc:     Dmitry Rokosov <ddrokosov@sberdevices.ru>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>, mturquette@baylibre.com,
        sboyd@kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>, jian.hu@amlogic.com,
        kernel@sberdevices.ru, rockosov@gmail.com,
        AML <linux-amlogic@lists.infradead.org>,
        linux-clk@vger.kernel.org, devicetree <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, Rob Herring <robh@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2F9DDB93-5EE7-4B5D-AFB5-052968081E0A@gmail.com>
References: <20230426095805.15338-1-ddrokosov@sberdevices.ru>
 <20230426095805.15338-6-ddrokosov@sberdevices.ru>
 <CAFBinCCdoaNuQymcjp5j9MHn2jpPWMqXe-+EgBo=5Ot8Bwaofw@mail.gmail.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Precedence: bulk

> On 1 May 2023, at 7:51 pm, Martin Blumenstingl =
<martin.blumenstingl@googlemail.com> wrote:
>=20
> Hi Dmitry,
>=20
> On Wed, Apr 26, 2023 at 11:58=E2=80=AFAM Dmitry Rokosov
> <ddrokosov@sberdevices.ru> wrote:
>>=20
>> Add the documentation for Amlogic A1 Peripherals clock driver,
>> and A1 Peripherals clock controller bindings.
> Maybe a native English speaker can comment on whether it's
> "peripheral" or "peripherals".

I=E2=80=99m not a grammar specialist, but I would write:

=E2=80=9CAdd documentation and bindings for the Amlogic A1 SoC =
peripherals
clock driver=E2=80=9D

Peripherals is the correct plural but reads better when you add
context on the type of peripherals.

Christian

> [...]
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../bindings/clock/amlogic,a1-clkc.yaml       |  73 +++++++++++
>> .../bindings/clock/amlogic,a1-pll-clkc.yaml   |   5 +-
>> include/dt-bindings/clock/amlogic,a1-clkc.h   | 114 =
++++++++++++++++++
> I have seen that Yu Tu named the S4 peripheral clock controller
> binding and driver "s4-peripherals-clkc" [0].
> Does it make sense to apply the same naming here as well?
>=20
>=20
> Best regards,
> Martin
>=20
>=20
> [0] =
https://lore.kernel.org/linux-amlogic/20230417065005.24967-3-yu.tu@amlogic=
.com/
>=20
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic