Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84bc488b-5b4b-49ec-7e1a-3a88f92476f6@amd.com>
Date:   Mon, 1 May 2023 21:01:19 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.0
Subject: Re: [PATCH] pds_core: fix linking without CONFIG_DEBUG_FS
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@kernel.org>
Cc:     Brett Creeley <brett.creeley@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230501150624.3552344-1-arnd@kernel.org>
 <20230501153502.34f194ed@kernel.org>
From:   Shannon Nelson <shannon.nelson@amd.com>
In-Reply-To: <20230501153502.34f194ed@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGdXV3dKS1kvVlNIV29mVitEcklxTW9OSjFIcURBeEwrSDNZcVVoNGJzcnlR?=
 =?utf-8?B?UitDN2dqbmgwZStqUWtyWE9iOThjY3hWSnZMV2pBNUo2bGcxeTJDMVpPeHZY?=
 =?utf-8?B?bDJwTmlVTTFOY3BxUjNVa1h5emRGdTVTOFFtbFhUUG1XR0NUbkQ0WE9QY2FG?=
 =?utf-8?B?Sms5dWI5WHJKaHV4clVZOWdnMnI2bmk0Z2hBeGpaVExuWjYrYXNpREJRVmhD?=
 =?utf-8?B?S2xUYmh1bk9TMEk3UExVcU91bVdBRlZmQytBOFFDTWFTWTZieHE2eWJzKzg2?=
 =?utf-8?B?alE0ZjUwYm9OK2VFSytUY1FTTkxPelp2eVJXb0lIcDhkMnZTRHpuaHFabWFD?=
 =?utf-8?B?Qmo2Myt0eVAyZ0ZsUHo5dFBNcGJLMENtSGZFQnNqUlpURG15cTNQQkNjN0Fs?=
 =?utf-8?B?c011dVo2bmVJRDcxU21yaGNOcVhLSFN2ck1pb293QkNoZ3ZGTTl1cGRuV0tQ?=
 =?utf-8?B?dU5DNWFwcDRlTE1lb25uNTBnSXhTU004VWFqMzFvRVhYUHowZEtFRmMwNFhX?=
 =?utf-8?B?RHp5TUhLZ0UxRlFxOCtjK1VFTk9FSzk3Z2d3VEdNV0tLMktId2NvWWdnM1Vv?=
 =?utf-8?B?OUt3Vkg3RHNXanFGamlrbVZNOTBYNjUvMVE4allWZHcvRFF3M2EycGFhYUNy?=
 =?utf-8?B?R1hPUmhhRnhmdEhzZ2hnV0I0aTFwVFd1bGlwamEwTStmQmQ0UGp4V2txc1Jn?=
 =?utf-8?B?c1E1WmlDWk5DOEdGSFA0SnpDV1JHREJXWjdGQ3VoMlRGQnZ4ZjBZWC9hN2lw?=
 =?utf-8?B?a3p4RDA2Wjk4bmN4SXNCamp2ZlN5N1ozcGJjV0F6SlVVeVA0NjhvOEhCSUV1?=
 =?utf-8?B?VXQ5QVlmQUlQRzlka3VIeUlTYnYxaTJPSk5JZVo3VGFsV216b2pVUG56c3BQ?=
 =?utf-8?B?Nm03Z3ZmbzlNQnB1Mkhvb0dLd1h6RXZYRkxHQ1Z1UTNjK0I0VUE1SHpoM0Nk?=
 =?utf-8?B?K2F3OVphR0E1WmJIL3hianVNTTJ3Rm5kRG9sL01UVXNPTFNBV3VsRjVmNk9G?=
 =?utf-8?B?M2tlMHllZmxGRWRCaUtuK0R2Ym5FSXI0dTR5ZlVBZW84VDlKbStuUEJsUUNG?=
 =?utf-8?B?NTFlQzFRYkVkUkVHd0Zia0tKZEQwL2ljUFpRQXQxc0taRTZBVjRaRkwzWnN3?=
 =?utf-8?B?dit1WHJ6eEFFbXdmOXBjMjNnZGhVVEl3SkxaL0MxUkREYTBWblduUDlwU1Bp?=
 =?utf-8?B?KzR5aS9HNXhqbjRqdWwrQ2RVWFpSQlNqaWRzVmxIdEZnSFNJRzJnOWRKQWpC?=
 =?utf-8?B?ZmtHanhLRjFYWFRLaEpOTXAyanJYamRhNW1SWHBRVWVIVTFqTGxDWWg2ejd4?=
 =?utf-8?B?UU8wTkplMkIxRW4zNVpjL2ZHUDkwOVBTZGdDcmd0cjFkcDdqVWtnblZidTBI?=
 =?utf-8?B?MXBHcS85RTlrUlNiUEV1RTRTNHp5OHRXSVZ0eitzdGp3Z1JHUWxMRlR2MTQ1?=
 =?utf-8?B?V0tWMkVRcG5yMnY3QVBYN01Uc3pXTCs4YUw0TWgxYXdPS1hGQWMxTXdjSThP?=
 =?utf-8?B?V1VtQ2JEN29oNHcxQ1JkR1g5T1lXak5oSlFoRXRJcjN5RnR4bmsvT2VXL1R3?=
 =?utf-8?B?cHRJeC9KYkF2UTdpczIvZC9ncjlwbmtzYUtORXloRmRmR0JNSzl2U1hVV1Jv?=
 =?utf-8?B?WjN4OW51SVplREJ6Zjh3YUo3Mlk4aDBWMlJkRjZCQ3o2bEJkYjBNajM4K2J3?=
 =?utf-8?B?VThKV2JFVW13ajVndlZoYkg1dU0vZXBkUkx5Sk5mWEI4QnB4ZkxhWlQxNWZt?=
 =?utf-8?B?WmY1WTlNTENkSUpSSnVDNWlicmV1ODRQU3d2TjUyOUdINmQ3R3ZQbE1EcGdt?=
 =?utf-8?B?Q2NMUjEyaTg5UGN1dUJqa2dvUVlmY1hzYjE0TFpISHdObklQdFhZU3FIbE9V?=
 =?utf-8?B?djZJZ2Y5SHQ4TGVEZ05IK1NHT1RFbGViZHVJQ2xxREdSOXRVWGdFYVVKVTF6?=
 =?utf-8?B?ZmY0TTVFL01tTzNwNHBwbkMvYjc1eWNJYmdlQW5SRWhybEduc0dJQzJLa3pt?=
 =?utf-8?B?UXlEVUFJTEtXVWFrQUFJbEtPRjhKZVhyQ1lyQlNHaGlISzJrcGN2ZW42bDJs?=
 =?utf-8?B?NFVKUUdVSG0vTVJyN3BnSUV5ZDl0UGRXTjhUOVZkdENQbTRGRTB2NDNWaCt4?=
 =?utf-8?Q?WOP9/32OrkLoVad92ZmQwrDXT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 463cd557-efaa-4dc9-9229-08db4ac1e43b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6583.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 04:01:22.2920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ybdFzqnCQACD9/oK/Yg5iN+bJAeOVlsZlzTOZY3dopf7uiQ0P8tcChfOLNElPx9MoiAPKcSYHYerTKVO7p4rgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8244
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/1/23 3:35 PM, Jakub Kicinski wrote:
> On Mon,  1 May 2023 17:06:14 +0200 Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The debugfs.o file is only built when the fs is enabled:
>>
>> main.c:(.text+0x47c): undefined reference to `pdsc_debugfs_del_dev'
>> main.c:(.text+0x8dc): undefined reference to `pdsc_debugfs_add_dev'
>> main.c:(.exit.text+0x14): undefined reference to `pdsc_debugfs_destroy'
>> main.c:(.init.text+0x8): undefined reference to `pdsc_debugfs_create'
>> dev.c:(.text+0x988): undefined reference to `pdsc_debugfs_add_ident'
>> core.c:(.text+0x6b0): undefined reference to `pdsc_debugfs_del_qcq'
>> core.c:(.text+0x998): undefined reference to `pdsc_debugfs_add_qcq'
>> core.c:(.text+0xf0c): undefined reference to `pdsc_debugfs_add_viftype'
>>
>> Add dummy helper functions for these interfaces.
> 
> Debugfs should wrap itself. Doesn't this work:
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/Makefile b/drivers/net/ethernet/amd/pds_core/Makefile
> index 0abc33ce826c..54d1d5b375ce 100644
> --- a/drivers/net/ethernet/amd/pds_core/Makefile
> +++ b/drivers/net/ethernet/amd/pds_core/Makefile
> @@ -9,6 +9,5 @@ pds_core-y := main.o \
>                dev.o \
>                adminq.o \
>                core.o \
> -             fw.o
> -
> -pds_core-$(CONFIG_DEBUG_FS) += debugfs.o
> +             fw.o \
> +             debugfs.o

Yes, that should do it, and should have been done in the rest of the 
change that I made after Leon suggested removing the dummy functions 
that I originally had there [0].

Tomorrow when I'm back from vacation I can do a couple of follow-up 
patches for this and for the other config tags that Simon pointed out.

sln

[0] https://lore.kernel.org/netdev/20230409112645.GS14869@unreal/