Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3483476c-97fa-cc41-617c-96807d3e047e@linaro.org>
Date:   Tue, 2 May 2023 08:56:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add IDs for IPQ5018
 family
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Robert Marko <robimarko@gmail.com>, agross@kernel.org,
        andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20230429193336.600629-1-robimarko@gmail.com>
 <8feae59c-b762-8cc8-7aa9-237ce4af5b1e@linaro.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <8feae59c-b762-8cc8-7aa9-237ce4af5b1e@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/05/2023 14:51, Konrad Dybcio wrote:
> 
> 
> On 29.04.2023 21:33, Robert Marko wrote:
>> Add SOC IDs for the IPQ5018 family.
>>
>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>> ---
>>  include/dt-bindings/arm/qcom,ids.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
>> index 802495b20276..c1283bad81e1 100644
>> --- a/include/dt-bindings/arm/qcom,ids.h
>> +++ b/include/dt-bindings/arm/qcom,ids.h
>> @@ -216,6 +216,9 @@
>>  #define QCOM_ID_SM8350			439
>>  #define QCOM_ID_QCM2290			441
>>  #define QCOM_ID_SM6115			444
>> +#define QCOM_ID_IPQ5010			446
>> +#define QCOM_ID_IPQ5018			447
>> +#define QCOM_ID_IPQ5028			448
>>  #define QCOM_ID_SC8280XP		449
>>  #define QCOM_ID_IPQ6005			453
>>  #define QCOM_ID_QRB5165			455
>> @@ -229,6 +232,9 @@
>>  #define QCOM_ID_SM8450_3		482
>>  #define QCOM_ID_SC7280			487
>>  #define QCOM_ID_SC7180P			495
>> +#define QCOM_ID_IPQ5000			503
> 
>> +#define QCOM_ID_IPQ0509			504
>> +#define QCOM_ID_IPQ0518			505
> Are you sure these names are in tact?

Good catch :)

Best regards,
Krzysztof