Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb3d2590-a1f8-fe7e-0bba-638ee80719af@amd.com>
Date:   Tue, 2 May 2023 09:59:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl
Content-Language: en-US
To:     =?UTF-8?Q?Andr=c3=a9_Almeida?= <andrealmeid@igalia.com>,
        Alex Deucher <alexdeucher@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, pierre-eric.pelloux-prayer@amd.com,
        =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <maraeo@gmail.com>,
        =?UTF-8?Q?Timur_Krist=c3=b3f?= <timur.kristof@gmail.com>,
        michel.daenzer@mailbox.org,
        Samuel Pitoiset <samuel.pitoiset@gmail.com>,
        kernel-dev@igalia.com, Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>,
        alexander.deucher@amd.com
References: <20230501185747.33519-1-andrealmeid@igalia.com>
 <CADnq5_NXj4W44F_etRQ7HWdVTnf5zARCM3Y_o3EiwWiHj8QMpA@mail.gmail.com>
 <6ab2ff76-4518-6fac-071e-5d0d5adc4fcd@igalia.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <6ab2ff76-4518-6fac-071e-5d0d5adc4fcd@igalia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K05VMXpQMEQ1eHo1V1VkeGRXUXdtQkE3SzZCWnFQa01aU1pPeUVTN2RWVnBV?=
 =?utf-8?B?VDNDMXlIa09IM21jRWUxbk1zSVEzWDV6UnJEejA0MDJWOC9kajFpQmYxV3Zj?=
 =?utf-8?B?dUdURjRPeW9xUW83VmsvZjBuUkNEM0pPV2xvTWNjblZQeFpDMnp5UEk1TStQ?=
 =?utf-8?B?WmdDMXkwT2MwempEd0RuRm1Gb2lPaDNVZGFTMi9CeUgxL0dIK0djWmw5anNN?=
 =?utf-8?B?ZUtiUkQ0cWpabFN2M3pEcEpnOUQvMHA1UUV5d3ZTTXRPaUJ2Vjk0cVZkdS85?=
 =?utf-8?B?d3lTeFRuMFAxMFJCY0pSa3hRNkMzU0FXYlIxR3ZZd1BuSkdPeGxjYytkRWhH?=
 =?utf-8?B?ZnVObWdVNXVjVk9XZnJWK2hpQjZTSWRoRDRWdDBTaHloODJIaEthZEgveE1M?=
 =?utf-8?B?S1BHTFViT1cza3J0dWlPd2hFSEVZNWNwWDlXWU9kVEdhTXM0SU9PYnJwNXhm?=
 =?utf-8?B?VDFLVTN3ZktlTjVBSE8ycDBYMWVjc01QUk83KzBWT0xPL2RONEc5MEg3RmIv?=
 =?utf-8?B?UG9DQUl3emVmV2tKV0NLUnFkRWg2TVJvWmhrRW80N25Wc1lJZ3VJYXZNN1RK?=
 =?utf-8?B?d1ozQ2luU3JNbVE0VU5OTlVZMldCS1JCQjE4cDY5SkdlZWE0Q2M4SnZlblhK?=
 =?utf-8?B?SVdWajFmdmVEeVpoSEVSTjJtc2QyTnJnV1NpOEJ5VGZadml0KzY3YkNOaU1k?=
 =?utf-8?B?RFRCbjBuQ2dMOENIVzJVVkdsVi8vWGFueVUxUzFIejVTVGNGTndnTlRGUTlI?=
 =?utf-8?B?YkRxSTJIQU5aWFVGM3BUUHIzMEVLbDRZU2lrbnRGUWJ6STd6VGV4Y1dQSUxR?=
 =?utf-8?B?Mk9EcSs4ME9BLzA0V0x1dUJYNjV5RW9nTll4ZTNTdUhSUDVuTkVlRHpveWJl?=
 =?utf-8?B?MHFNTVp6R1lYRXZray8yUStIaThjbWtrNVZjM0kyNWE0SFVKc09PMG50OGVv?=
 =?utf-8?B?WFBraUg3b3AwSFVHMSs4K3d1bHlObENqNEVMRnhZMmp3Q0ZHR1ZkeCt6azFS?=
 =?utf-8?B?RlA1UjZSeXlGUDJrcWpkTndUM0krd3JsalNBN05zNStVRFRjbVdGRWRsV3pv?=
 =?utf-8?B?djZxcUtCSnhuL1ZBUVdSUjJZU3dqWDZuZjV5OVFzMzBQaUhRMHYzc2t2Z242?=
 =?utf-8?B?RDBFMmpnNUZVejFnVy8rbnp3TW5PbHo5b3B6MEZiQVBsWmI5K2t1RXU2SDBY?=
 =?utf-8?B?YnRMU05jTW9JOCt2R3l0a200cDJHZUxTaXFaRS9KejRQdlN1cXZjRnVTWjk1?=
 =?utf-8?B?a1ZZczh6dnhqeUJGdkJUVzUvU2JhWHpZc0pZSmVIUFFibGYyTEVrcGpWRHFp?=
 =?utf-8?B?czA1QUIxSUdwVVo3M3ZaTnVPSERGK2Rab0lvMWxOQzRCdUVESHQyeXBEcXhr?=
 =?utf-8?B?VHMxZ3h1WU1ES2dMVjRoZWExZDExSk9nTjFwSU9CVGFiMTBxNVNzQ2J5L0I2?=
 =?utf-8?B?eUJsejUzMlZyQ1dXZnpyaHg4OERoTXNHdTl4Zmt2cURGVXF6VmFqOWNWR2xq?=
 =?utf-8?B?bVdJU0syczJhMmRCK2dSeUU3K1pjMnlKVXJFRHpXd0YwSTBxbHBsVGxWRGpB?=
 =?utf-8?B?R1QyMk1Vd3AxUkZ1ZXVrVWhsUm1RYXhveHdWTXBWYVhsY0pjb2hOUkpIaVRi?=
 =?utf-8?B?M3Z4Rk84NDBhU0ZoNG9mNTN2L1paUWpQb0tzeE0xRnRybW1YTHRudDk2QzNJ?=
 =?utf-8?B?VS9tOEU3YU9QWkJrVWwySTc2aDBRdmpmMktGY0ltblh0aGk1M1ZUMW1yNjhD?=
 =?utf-8?B?T2RCQnJKeHBaRldWNTlqdTNrUzNKK21tQnVIc3JtWlVyamh2RDlIR3E5bmEy?=
 =?utf-8?B?cUtvUFBKb2VQMWxwSDY1OTUycVhpcGo1TTZCZlZXM2djQ2hJdnBTcXdVWlRv?=
 =?utf-8?B?V0VySmhrRUVoaHl3VmtWTnhEVDZDYnFkN2QycVVFV0dYSlBLYTFzTHVicnQ1?=
 =?utf-8?B?VFloaFdRSXFES0xZbVFqL2kyeThZWmxMcE9jWUQzVFhEYnEzaEtiRU10THZu?=
 =?utf-8?B?RHRQUmUyTitXUFhhejFlZllwMXlISU44STlrOUkxb25vYlBSWSsvbW96MFAy?=
 =?utf-8?B?TUFhSEVCNC9OUktnQUFqeE1MaGhic3MrZDRXbUhla0MwWEpoRm1oT08ra2Yw?=
 =?utf-8?B?V0tHS3JmSTNuaU1RS3JxT2RGRmlocittL0JXRUNMeVJuZmZhZjdWbitFYmFy?=
 =?utf-8?Q?5r7JY0ZPNxF4d6whkUZMKiLYhzxFI2AcCG8aWkq1Z0NS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92128c1e-f100-4379-0cb7-08db4ae32794
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 07:59:28.8005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k67V9uGptGv9kBp2BDdPHP6undj1gO0e4lKQqR3D6MPpv61ZfC+GJCEpkk7a46/A
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6996
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 02.05.23 um 03:26 schrieb André Almeida:
> Em 01/05/2023 16:24, Alex Deucher escreveu:
>> On Mon, May 1, 2023 at 2:58 PM André Almeida <andrealmeid@igalia.com> 
>> wrote:
>>>
>>> I know that devcoredump is also used for this kind of information, 
>>> but I believe
>>> that using an IOCTL is better for interfacing Mesa + Linux rather 
>>> than parsing
>>> a file that its contents are subjected to be changed.
>>
>> Can you elaborate a bit on that?  Isn't the whole point of devcoredump
>> to store this sort of information?
>>
>
> I think that devcoredump is something that you could use to submit to 
> a bug report as it is, and then people can read/parse as they want, 
> not as an interface to be read by Mesa... I'm not sure that it's 
> something that I would call an API. But I might be wrong, if you know 
> something that uses that as an API please share.
>
> Anyway, relying on that for Mesa would mean that we would need to 
> ensure stability for the file content and format, making it less 
> flexible to modify in the future and probe to bugs, while the IOCTL is 
> well defined and extensible. Maybe the dump from Mesa + devcoredump 
> could be complementary information to a bug report.

Neither using an IOCTL nor devcoredump is a good approach for this since 
the values read from the hw register are completely unreliable. They 
could not be available because of GFXOFF or they could be overwritten or 
not even updated by the CP in the first place because of a hang etc....

If you want to track progress inside an IB what you do instead is to 
insert intermediate fence write commands into the IB. E.g. something 
like write value X to location Y when this executes.

This way you can not only track how far the IB processed, but also in 
which stages of processing we where when the hang occurred. E.g. End of 
Pipe, End of Shaders, specific shader stages etc...

Regards,
Christian.