Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aab0ee5c-4573-759a-ebda-401b041a65cb@quicinc.com>
Date:   Tue, 2 May 2023 14:22:08 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v7 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for
 SC8280 Multiport
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Felipe Balbi <balbi@kernel.org>,
        "Wesley Cheng" <quic_wcheng@quicinc.com>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <quic_pkondeti@quicinc.com>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>, <quic_harshq@quicinc.com>,
        <ahalaney@redhat.com>, <quic_shazhuss@quicinc.com>
References: <20230501143445.3851-1-quic_kriskura@quicinc.com>
 <20230501143445.3851-2-quic_kriskura@quicinc.com>
 <df24efb2-8279-ef15-a118-2a24885288c8@linaro.org>
 <a001c9c0-f186-f125-daab-e646790badfe@quicinc.com>
 <0f2dea5a-b6f7-b659-f41e-55d1777b4dd1@linaro.org>
From:   Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <0f2dea5a-b6f7-b659-f41e-55d1777b4dd1@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/2/2023 2:17 PM, Krzysztof Kozlowski wrote:
> On 02/05/2023 10:35, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 5/2/2023 1:18 PM, Krzysztof Kozlowski wrote:
>>> On 01/05/2023 16:34, Krishna Kurapati wrote:
>>>> Add the compatible string for SC8280 Multiport USB controller from
>>>> Qualcomm.
>>>>
>>>> There are 4 power event irq interrupts supported by this controller
>>>> (one for each port of multiport). Added all the 4 as non-optional
>>>> interrupts for SC8280XP-MP
>>>>
>>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>>> ---
>>>>    .../devicetree/bindings/usb/qcom,dwc3.yaml    | 21 +++++++++++++++++++
>>>>    1 file changed, 21 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>>>> index d84281926f10..2c96da1ce5b8 100644
>>>> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>>>> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
>>>> @@ -26,6 +26,7 @@ properties:
>>>>              - qcom,sc7180-dwc3
>>>>              - qcom,sc7280-dwc3
>>>>              - qcom,sc8280xp-dwc3
>>>> +          - qcom,sc8280xp-dwc3-mp
>>>
>>> SC8280xp comes with two USB controllers: one single-port and one multi-port?
>>
>> Hi Krzysztof,
>>
>>     SC8280XP comes with 3 controllers. The first two are single port
>> controller and the third one is a multiport controller. In DTSI:
>> usb_0 / usb1: have compatible set to : "qcom,sc8280xp-dwc3"
>>
>> And multiport controller has it set to "qcom,sc8280xp-dwc3-mp"
> 
> OK, then this looks fine.
> 
> Please add the compatible to existing allOf:if:then to constrain clocks
> and other pieces. If none of existing if:then: matches your case, add
> new one.
> 
> Best regards,
> Krzysztof
> 

Thanks Krzysztof. One query:

Clocks are same for both single/multiport controllers. Would the 
following be fine ?

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml 
b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 2c96da1ce5b8..c0f4745febf0 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -263,6 +263,7 @@ allOf:
            contains:
              enum:
                - qcom,sc8280xp-dwc3
+             - qcom,sc8280xp-dwc3-mp
      then:
        properties:
          clocks:

Regards,
Krishna,