Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6652048rwr; Tue, 2 May 2023 03:41:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5+fqY4AXfpunJlY5VA686TSnzho6D7y90s9iml1j8UstVSzAeVQxKiMUACKXcccF069GIR X-Received: by 2002:a17:90b:e95:b0:24e:16ae:61ca with SMTP id fv21-20020a17090b0e9500b0024e16ae61camr4059671pjb.34.1683024075565; Tue, 02 May 2023 03:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683024075; cv=none; d=google.com; s=arc-20160816; b=U5LzqjOzTf1q5yItsmvueJcansp6afcd5XCnFt102ojfSBqflCyojnHmY0m0eM6qev UVGOEgIfmmVzRqz5Y3VoR1kj7Kn1cKYYtE6EGa4iZbFJZFaX97Aw3F+ENGcqEN1fIHTH L8eiPxVvvYxUuHU5Y+EUrgl0ZbP9uC5fDXW3H020ACRYY1vdHNz2Ah6v4iCKvih7BDLq eaazOvClZ5HkRFXyFuvg9nGRM3IySIRgrR1ETSqKJJ54Tgk/EB2HwIThj+urYcR6WfQu LTrrI9ElfKz2qAf0lXTYsbNw5SAt29wxf8pBKGALdTCSjs865zmiUCPpIBbIT6V1qiLl D0gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=BuK9yt7coqgqQBziCDgLRC212bKpkXeD99LtZ/3AI/w=; b=beUXfQ1S754wqm4gC37Fu6mXLW0Aqyxj9cNJ9aT/r/+1rRG+2N7u513xLUtknY4c7z tmcbghioK/wOKeHQtgBCJkYcb/F8G4ipaCEONCxj0nbly5tQTciVzNqLpZRaqytNaUyj 3SfUGzHElGyMPQOKmc7opO/L3C5SbmdiR6qGS0ex5b6edmc37xIBwcV9rCLDHvRKAkeF w0gAv1upzXM5GbnjPlMu9Dx9Q/NFO++/6PZqHnFnc+Vzu+vqmxuPr9BIRcnCrsDyqyk1 oq10Ci9JFh3PvVP4TUHArtkjDANedpWnHEVjM9pQh1Q8fKR0RWKUIXI0hI2MmidPa5kj sBqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uNqccEYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a17090322c100b001a92c70e1e2si32499345plg.582.2023.05.02.03.41.03; Tue, 02 May 2023 03:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uNqccEYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234046AbjEBKga (ORCPT + 99 others); Tue, 2 May 2023 06:36:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233864AbjEBKfq (ORCPT ); Tue, 2 May 2023 06:35:46 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75A644C0E for ; Tue, 2 May 2023 03:35:33 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4efe8991bafso4735764e87.0 for ; Tue, 02 May 2023 03:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683023731; x=1685615731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BuK9yt7coqgqQBziCDgLRC212bKpkXeD99LtZ/3AI/w=; b=uNqccEYEEjKxz0ppsRGvYmKtlasNF9Qxu9Ja9yoqq/6yX43E5LOsDx8ZXNeIsgWG1p Tq43QPdv6Fyjfou1qTd+x9tlLmAERrDSJLRrJoaRvEi8B87UqlGcx0UI48ORYnP9yQnZ j7ymKPzdpmLtlPZWPxx+LXSqBNE8cvMsVK4sN2EuCJFBu9XUhEP/1scZj5UXexfL63Qr 4FUk/qa0ElNhhvyb9LzIsGjEMhSyAuamXmT/lhnbNOIs9KpPbgm4qntnvTVtOxJb/NvJ YCHjasOS5D5UM6ppnT9QRpxhGyNvmLoMrIeM7q6LOvSWe3+LO62uU6y4QnDJftKzHzOz Ycwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683023731; x=1685615731; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BuK9yt7coqgqQBziCDgLRC212bKpkXeD99LtZ/3AI/w=; b=bCslK3ECdWeWjkMY3GkkN8AAaJWsJgZWj3O/PCs71mSG6sLAQBPke+7QHwWIzddcX/ Ie+IWZ2EUnVrCAxtnQIbRBsjN692aoC7KgU71I2aCbnMmZH5IBKdEYy6J/4EQN6XOXaU nA3/iNqfE6C7gA6Q1g45i10XrB/UxbfHHP1VuqLESUwx6ybEaEhUrbRdZEvZj9BZrAfj sILPnccq7oyZTqN8tueHqyDzeCAdQx4C+3duGGA/WkixEmKTQ9CosJEZUhLMet/Rk+4N ngBfeX8sOCSu1rWN1oqeME9ZTid+OjSrpnxuhGG3XKwRdVQSWV6ChWSxSwoxvLC65I8o +3Uw== X-Gm-Message-State: AC+VfDwiMWdy0Y7soi3OjdZ77Rw77hGSA3jzG9yR7IONZ1yU9/ntKIky ChUoGDV5JH7sSZDad5G1qgCp7g== X-Received: by 2002:a19:ae12:0:b0:4dd:a61c:8f74 with SMTP id f18-20020a19ae12000000b004dda61c8f74mr4792906lfc.51.1683023731622; Tue, 02 May 2023 03:35:31 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id y24-20020ac255b8000000b004cb41b43c25sm5254716lfg.197.2023.05.02.03.35.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 03:35:31 -0700 (PDT) Message-ID: <47b8c36f-cf53-beec-3b18-1544456beabf@linaro.org> Date: Tue, 2 May 2023 12:35:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v10 3/4] arm64: dts: qcom: sm6115: Add USB SS qmp phy node Content-Language: en-US To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, kishon@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org References: <20230502053534.1240553-1-bhupesh.sharma@linaro.org> <20230502053534.1240553-4-bhupesh.sharma@linaro.org> From: Konrad Dybcio In-Reply-To: <20230502053534.1240553-4-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2.05.2023 07:35, Bhupesh Sharma wrote: > Add USB superspeed qmp phy node to dtsi. > > Make sure that the various board dts files (which include sm4250.dtsi file) > continue to work as intended. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Bhupesh Sharma > --- Reviewed-by: Konrad Dybcio Konrad > .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ > arch/arm64/boot/dts/qcom/sm6115.dtsi | 29 +++++++++++++++++-- > .../boot/dts/qcom/sm6115p-lenovo-j606f.dts | 3 ++ > 3 files changed, 33 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > index a1f0622db5a0..75951fd439df 100644 > --- a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > @@ -242,6 +242,9 @@ &usb { > &usb_dwc3 { > maximum-speed = "high-speed"; > dr_mode = "peripheral"; > + > + phys = <&usb_hsphy>; > + phy-names = "usb2-phy"; > }; > > &usb_hsphy { > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index 631ca327e064..f67863561f3f 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -661,6 +661,31 @@ usb_hsphy: phy@1613000 { > status = "disabled"; > }; > > + usb_qmpphy: phy@1615000 { > + compatible = "qcom,sm6115-qmp-usb3-phy"; > + reg = <0x0 0x01615000 0x0 0x1000>; > + > + clocks = <&gcc GCC_AHB2PHY_USB_CLK>, > + <&gcc GCC_USB3_PRIM_CLKREF_CLK>, > + <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>, > + <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > + clock-names = "cfg_ahb", > + "ref", > + "com_aux", > + "pipe"; > + > + resets = <&gcc GCC_USB3_PHY_PRIM_SP0_BCR>, > + <&gcc GCC_USB3PHY_PHY_PRIM_SP0_BCR>; > + reset-names = "phy", "phy_phy"; > + > + #clock-cells = <0>; > + clock-output-names = "usb3_phy_pipe_clk_src"; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > qfprom@1b40000 { > compatible = "qcom,sm6115-qfprom", "qcom,qfprom"; > reg = <0x0 0x01b40000 0x0 0x7000>; > @@ -1111,8 +1136,8 @@ usb_dwc3: usb@4e00000 { > compatible = "snps,dwc3"; > reg = <0x0 0x04e00000 0x0 0xcd00>; > interrupts = ; > - phys = <&usb_hsphy>; > - phy-names = "usb2-phy"; > + phys = <&usb_hsphy>, <&usb_qmpphy>; > + phy-names = "usb2-phy", "usb3-phy"; > iommus = <&apps_smmu 0x120 0x0>; > snps,dis_u2_susphy_quirk; > snps,dis_enblslpm_quirk; > diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts > index ea3340d31110..81fdcaf48926 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts > +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts > @@ -306,6 +306,9 @@ &usb { > &usb_dwc3 { > maximum-speed = "high-speed"; > dr_mode = "peripheral"; > + > + phys = <&usb_hsphy>; > + phy-names = "usb2-phy"; > }; > > &usb_hsphy {