Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91b218e9-1650-a032-3b23-be6134c33e4f@amd.com>
Date:   Tue, 2 May 2023 16:25:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 35/46] perf parse-events: Support hardware events as
 terms
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Kan Liang <kan.liang@linux.intel.com>,
        Ahmad Yasin <ahmad.yasin@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Stephane Eranian <eranian@google.com>,
        Andi Kleen <ak@linux.intel.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Samantha Alt <samantha.alt@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>,
        Weilin Wang <weilin.wang@intel.com>,
        Edward Baker <edward.baker@intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Florian Fischer <florian.fischer@muhq.space>,
        Rob Herring <robh@kernel.org>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        John Garry <john.g.garry@oracle.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Sumanth Korikkar <sumanthk@linux.ibm.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Leo Yan <leo.yan@linaro.org>,
        Yang Jihong <yangjihong1@huawei.com>,
        James Clark <james.clark@arm.com>,
        Suzuki Poulouse <suzuki.poulose@arm.com>,
        Kang Minchul <tegongkang@gmail.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230429053506.1962559-1-irogers@google.com>
 <20230429053506.1962559-36-irogers@google.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230429053506.1962559-36-irogers@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnRMV1FXVWcyUytMM0NLVmMxTlFFREFZRWc3NU9PL0FpaEdTcjA2bkZkTGt1?=
 =?utf-8?B?YUFqL2x6NUZLVTdTR2lMOERDWnJmVnBPMS83enovL24zOEQ0YmZLNXROakNu?=
 =?utf-8?B?ZVd6VVNac2hzK2hDZGJGUmJQUXEzd2RGZkR1V2JmTWlGVjhmcmFmdHE1T1NO?=
 =?utf-8?B?Ry85QkRjNVN6K3dvN2hTdjUzNmJxQXhuRmRpT1dZNmFNTmg5K0pvaGZKSUdU?=
 =?utf-8?B?L3kybW1ScVpHY0tsU2ZpQzRYd1huTVdFdXVaanhTb01qcEwwbXBpRlYyMzAw?=
 =?utf-8?B?QmNzQzkwbDlnM2Z0a2tqcWFJVU1BZDd2K1BQbE41dkpjNThSS2JtSy9hN2hB?=
 =?utf-8?B?clZCakovYmg2MjRpQkIrTEsyeE5uckVUb0U0OGtMSFgwY1NBVERhS0lkaDha?=
 =?utf-8?B?ei9PTHkvNU53emVQVFJMMWlZb09jL0YwSWd1MVczdDZNSnBpL2hnTGdCRWJS?=
 =?utf-8?B?TlBTanp3S1lGWStzUndCNU9wUlFQcFJSM0pkbm1qVTJUQTcwamIxRW82Zmd3?=
 =?utf-8?B?RE5saXFBd2tVczFtdkJjZHVoMWtQbnE4NDlESDd2UXBpRmNTRzNFazJpdm84?=
 =?utf-8?B?dUVqUzhaMTRFR2JBaTRTMW82bW12QmdBVU53VWJGK1lBd3hLZ0RTQVRQdkxK?=
 =?utf-8?B?Qk1LTC9oUnF0bFlqUmNJazVxMjB4NGl3TXNtZU9nSVZsUUhYRFZoVjcrNnp2?=
 =?utf-8?B?QUJOZFBSckJYcm03NXpuNzg3T1FkeDFVbjkrVmJQR2hyTGlZbklBb1FJcVNs?=
 =?utf-8?B?eFcyTEFVbDJtWlJ4UHVPa2lNZmIvVG5iRzhFYWl6QiswelZnRlN3ZSt6TlR3?=
 =?utf-8?B?ZlNPYkRwbnNlc1Zsdm92OU5ON0djN1VtTCtSMW84dHRia1NaVm9CM21mKzJM?=
 =?utf-8?B?M1B3aGNvRmpMQkY4VjlZVXEwQTBqdit2eERVRStDRlhYaVpMLzZ1K1d3MmJ6?=
 =?utf-8?B?UGc4Y2d4Wlo2VU1JcWhrcUJhUDNUeWZJVjR2aFJHdHZiNVkwL1dmdFBidXAx?=
 =?utf-8?B?RVljeWpzVitFbEZKdnZqUW1VYVlKSFpkVmtlUVVLaitENDlnd2VTUUREUHRB?=
 =?utf-8?B?ZzlsblZsM1h5OTIyWGt3U05kbmVBMENBR0NTVitPVUdZYktQSU9OVGtwV0ZW?=
 =?utf-8?B?YWxjOG1aSVJjaHRhSmc2Qi94UTEyQ3NkU0FSR3ZQT2Z2cll5K2pUbnpEYUFs?=
 =?utf-8?B?d0YyVGVucmxoeGJiNUtMclB4Z3pCWUFlRXRmdGRSUFFJdkFHOFhMZDBXUnNZ?=
 =?utf-8?B?S2JWQzIybCs3a2pld2VqZHIwdTZraWpwM0dKS2pvMDlEMFl5c2UzcUlrR2xN?=
 =?utf-8?B?RUtBY1BQaG9GVkRJQ0FVOUlwSkRTK2x5M2FaUWVBQWdMdDl4QjZFRGdlOFI5?=
 =?utf-8?B?OHN6TXU3dDNLVUJuU0xXL21OdUxsZ0RFZ1RUVWxBbWw4N0QyOUxKbjJEaHUv?=
 =?utf-8?B?Vy81aHdXS0pGdGk0bkZVbHBOd0FxS2pwUEdrb2JDZjRVZXNtOWM2STd3NFEw?=
 =?utf-8?B?TUE5dXJUKzQ3bFZVU3ZBMGRJL2JkMms4SXZ6alk3blUreERmR3A5MlEvSmhE?=
 =?utf-8?B?SHJCclg4ZllWNit6QUVaeHJueUJGQllGanI3WVRPcXZKMXIxQWVobFVRVmRQ?=
 =?utf-8?B?WlI5L2ZFOGNsLy9qTUN6RWhvSWlrYzhlUE94b2ttYmUwY0Q4R2FJWlBzSTIv?=
 =?utf-8?B?YzJsUXgxMG5QYnppYkc3aTQ5SlY0Nlc5VzVxajJGZ0hleU1GTTlUK2RhYmpO?=
 =?utf-8?B?UUpqRjFSQi8rMG1tZlJkZEg2TksxL09qTElJVStvOXJVMHJwdjZadWlHM0w2?=
 =?utf-8?B?Vk1SVWNzUGY2YmFWZnl5VlUzQmlwZFQzTkNoWXN2c0FaN04zZUszcURmYkRy?=
 =?utf-8?B?emtSSlVKbkRRdGpMaFJTREtrM2RDd1BOY1F2cjY0dExzdjlsY01raTRUS01G?=
 =?utf-8?B?R2MzYjdONzRhZWcyUnkzanB6SEVsWGVQN1AwUU9LNnJ6eTNOeUF6bktESHZr?=
 =?utf-8?B?YlhDdGZudUg5L1BJcW9mWm1YRFBZUElucmcydlNxaVYyVnFnSkxrOXhPZ3Mz?=
 =?utf-8?B?cExoZDJraGVBWGxuemVBNldwWTZReW44NzgzWWhDWnRFSWJJSStwSXpRVk1h?=
 =?utf-8?Q?yGgGgXIXsW99Vu1VAx/UdXcyk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b2fb9be-fb28-4f50-d4b3-08db4afbd74e
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 10:56:11.6547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5rP2AFRmUtyQctlF6rNlEQYO0ZOvs8eg9THK7lTXwSwmERBcvdAUx+vP6ECXxFQmXqYpYEXD0E/6uXZ/RtfaQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6880
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -269,6 +279,16 @@ percore			{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_PERCORE); }
>  aux-output		{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_AUX_OUTPUT); }
>  aux-sample-size		{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_AUX_SAMPLE_SIZE); }
>  metric-id		{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_METRIC_ID); }
> +cpu-cycles|cycles				{ return hw_term(yyscanner, PERF_COUNT_HW_CPU_CYCLES); }
> +stalled-cycles-frontend|idle-cycles-frontend	{ return hw_term(yyscanner, PERF_COUNT_HW_STALLED_CYCLES_FRONTEND); }
> +stalled-cycles-backend|idle-cycles-backend	{ return hw_term(yyscanner, PERF_COUNT_HW_STALLED_CYCLES_BACKEND); }
> +instructions					{ return hw_term(yyscanner, PERF_COUNT_HW_INSTRUCTIONS); }
> +cache-references				{ return hw_term(yyscanner, PERF_COUNT_HW_CACHE_REFERENCES); }
> +cache-misses					{ return hw_term(yyscanner, PERF_COUNT_HW_CACHE_MISSES); }
> +branch-instructions|branches			{ return hw_term(yyscanner, PERF_COUNT_HW_BRANCH_INSTRUCTIONS); }
> +branch-misses					{ return hw_term(yyscanner, PERF_COUNT_HW_BRANCH_MISSES); }
> +bus-cycles					{ return hw_term(yyscanner, PERF_COUNT_HW_BUS_CYCLES); }
> +ref-cycles					{ return hw_term(yyscanner, PERF_COUNT_HW_REF_CPU_CYCLES); }

These are generic terms and thus can be added to _any_ pmus. Ex:

Before:
```
$ sudo ./perf stat -e amd_l3/cycles/ -C 0 -- sleep 1
event syntax error: 'amd_l3/cycles/'
                            \___ unknown term 'cycles' for pmu 'amd_l3'
```

After:
```
$ sudo ./perf stat -e amd_l3/cycles/ -C 0 -vv -- sleep 1
Control descriptor is not initialized
------------------------------------------------------------
perf_event_attr:
  size                             136
  config                           0xb00000000
  sample_type                      IDENTIFIER
  read_format                      TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING
  disabled                         1
  inherit                          1
  exclude_guest                    1
------------------------------------------------------------
sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8
sys_perf_event_open failed, error -2
Warning:
amd_l3/cycles/ event is not supported by the kernel.
failed to read counter amd_l3/cycles/

 Performance counter stats for 'CPU(s) 0':

   <not supported>      amd_l3/cycles/

       1.059391819 seconds time elapsed
```

Here `type=0` which means perf is trying to open event on HW pmu instead
of amd_l3//. `config` is 0xb00000000 where 0xb is amd_l3 pmu type:

$ cat /sys/bus/event_source/devices/amd_l3/type
11

Not sure if this is expected behavior.