Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 13:28:02 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, intel-wired-lan@lists.osuosl.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] igb: Define igb_pm_ops conditionally on CONFIG_PM
Message-ID: <ZFDzwkvMH1LdVKuF@corigine.com>
References: <20230428200009.2224348-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230428200009.2224348-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1QU/1KqJPkVwWSx2LMJ0bzVxNVtKvdlSkPcetPPZj0Bq3D0rNwEoJeYA8wZO?=
 =?us-ascii?Q?kZrJEAck7BKVX4XV+a7ClNLCPCed4XR6qBLpPd0u8fCYY0xbJOe/DenU2VxG?=
 =?us-ascii?Q?KVFEA8dq9UrLzF52f/kWZ8/qjLzDFWVlIUDhNu2uqOCVCbfFpwST2NqhMED3?=
 =?us-ascii?Q?AxKMGIO6L6qIl/qtKQRWeCnNfMVQ9v87+bH3LORCKvcwo/Ciufoh3rjYxics?=
 =?us-ascii?Q?5XOHGXEDoF+NeX0zzlcZaCO+lP6hVUNFFB7zHNvrBxtcopB2gLQ9RFgeSO+N?=
 =?us-ascii?Q?kMvr9JLzaZncUIKPS70o792zdTWEDIVIc9Thkgfmr81s4Vbqf96MiDYqaaLn?=
 =?us-ascii?Q?lhOdw5yzYyRpltd78RC7jX1GAL3PzhM9KoW4HyrI1PpiChuvC1R4mGGPxBLb?=
 =?us-ascii?Q?jvEBwz70GLD9pVAc83Q20LU8qQpS3hmOi+4ngIxa4zNusAxOErUIHvDatgJS?=
 =?us-ascii?Q?iVnSJlYdCl62HMQ9SDFjzEYgfPY64Ovkp8oNmMovmikaagFlMDYiYpW6b62K?=
 =?us-ascii?Q?B3NpY0UEX0yj0Ikjb/s6ZLD4Ao2GFMTcps8QLYG90EoIffF+G0xJh9L/d+oV?=
 =?us-ascii?Q?CJHKXNcuXcgchIEAXnTXtGG2JGsrhRFjGTwWbq040F47QeYu5/KgVOs53pAc?=
 =?us-ascii?Q?xa48DsBVRiu8UO8+B3qSGT+jjmNi+btuvKt0LPRcrDKQWc0QhKp7tS5PdujU?=
 =?us-ascii?Q?GM9qTiNnG3PbeodrqJZKtFtU2U65D4kLb7WCM5NvdVN91Mzc9CIBpFpJmVPv?=
 =?us-ascii?Q?g2yj+MZlvp/DgRG98BgO64NeLpOz8Y4mxLT/AcJAgGF+43n0D2VqskGId0j7?=
 =?us-ascii?Q?9wZhu2hqtHmUoSNaLRUzYfnGohqniA20u5jI0ja8wucR/rXfajvgoZM6Gy+R?=
 =?us-ascii?Q?ZEb3BNLLkT+7HYe6tWJBM47BTzBiJatqdGPzFEoi08q83M4QvttO8AM/LRqp?=
 =?us-ascii?Q?B3Pav1DtAWJzcZnfdGpeHJ0qEZ4m9MejKmIHyWsail5dlgtq7DiPtfMnCHrW?=
 =?us-ascii?Q?RoXTVAKCLqpnTlSg0CMDvf1Sy9P8o5lH4Eiqtu9jhRzXXLyAr/leH6AUHI4Z?=
 =?us-ascii?Q?AijTd/mAkaxBJv7aOZ9VfHvHewBt885/7PP+o5ygyrMARLBOBom62hyX/cWl?=
 =?us-ascii?Q?SYjKMRHbrSlUT7xrDORaumnBIpLAMJ8W+qroWqOqbpJIKZXQuxZAZC5Jq6mu?=
 =?us-ascii?Q?gouHn2mnMo63mQgNSqWgNm0pEKUkF1B4YQwM75dwSb3UeNM5NahpDauGAvur?=
 =?us-ascii?Q?4SDWUpJCvVMKjq9tMsJOqEc8la6dKPeaagN0LtvLEAh30NGrZu5RtGj5wrVi?=
 =?us-ascii?Q?LQmC2OWE6LM/BxpHPvx8VA4uuKxImRv1X04a7MbLS5lhQPK+Vx1rmYg3JaT+?=
 =?us-ascii?Q?VFaJPU9ccSK8N/nB6cs/q5sHMjNCw4luTXy/1z4R9QTIBYzyyPJbIBJEbFCx?=
 =?us-ascii?Q?OIzL+oGMwAg2FFoF5aMREHDj6sMATi3M40vsIuTZoApKFCiTRpE/5Ddy7Th4?=
 =?us-ascii?Q?EDdOxiG0l6f1MWFusEc8E3dbLEQ4FXvYsFHNCByChMkz5iDkHZoUq9F0CeQH?=
 =?us-ascii?Q?sK/HM1UcroPTghtiku3YdPpcn83R8kuMs/otCpvVwqFahNOZGO5C+FHHDPZ8?=
 =?us-ascii?Q?Iwnt1SDcg9qnFdhoYnZcR+4m3O7zY4OkiRukxxGFHa7GuPZcrmrtiSclExK7?=
 =?us-ascii?Q?W7cjQg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d86dbb20-1627-4393-cac8-08db4b004efb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:28:10.4180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MtPCO9R1msM0dbC+7ZPLwlRYRx7GPXp3H0nBGQNP3zEElCD4GbOB+Fd5Cx5LoJH/QN6VXoMPCe8sTccWiY0VjMmbCFQ2eNDY7IjRlqQU6NM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB4137
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 28, 2023 at 04:00:09PM -0400, Tom Rix wrote:
> For s390, gcc with W=1 reports
> drivers/net/ethernet/intel/igb/igb_main.c:186:32: error:
>   'igb_pm_ops' defined but not used [-Werror=unused-const-variable=]
>   186 | static const struct dev_pm_ops igb_pm_ops = {
>       |                                ^~~~~~~~~~
> 
> The only use of igb_pm_ops is conditional on CONFIG_PM.
> The definition of igb_pm_ops should also be conditional on CONFIG_PM
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>