Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 13:55:04 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Ratheesh Kannoth <rkannoth@marvell.com>
Cc:     Sai Krishna Gajula <saikrishnag@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "leon@kernel.org" <leon@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [EXT] Re: [net PATCH v4 09/10] octeontx2-af: Skip PFs if not
 enabled
Message-ID: <ZFD6GIS+lrVn4AJs@corigine.com>
References: <20230426074345.750135-1-saikrishnag@marvell.com>
 <20230426074345.750135-10-saikrishnag@marvell.com>
 <ZEj2UYNavsn0xE/D@corigine.com>
 <MWHPR1801MB1918C1AE94BB287FE29FC76BD36F9@MWHPR1801MB1918.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR1801MB1918C1AE94BB287FE29FC76BD36F9@MWHPR1801MB1918.namprd18.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9omMJ/8wIwEQBvb7xuVFrQBhXQ3kwfxz/BalOFdnJEQpeGEuP7WJHWHPGsnt?=
 =?us-ascii?Q?5ukJ7rvEeCy+c9QwngSvubT1oe1YYCrlsxN44iaYx1+At0IFxllDf7odS32+?=
 =?us-ascii?Q?Vyam+aT5UE0KHa+PLKa6RtU2QRJI4OTTaZrsCpoVdSYQzC8lQMA/+ltqtpjJ?=
 =?us-ascii?Q?UX5rxojFlVYpJKxNoyBmie/5jhVcA2CT/rnPdKT2g3Uoy4OTU8ypJSxf3jrs?=
 =?us-ascii?Q?i9AMJfLpA/P5f+dqnVf/JeVoH/PZauaYpP5OTuFvNa4QrNrYz61ftsYMRO2O?=
 =?us-ascii?Q?vT8cNHhfhXXLGibiUWOyGrJqFDhhtUqXCmYA9CeEwA/I07w/25SVNXs/L12+?=
 =?us-ascii?Q?NdLs3hB2u1tLapElNxEGYWQLnEe5FgsHsHNKnnQyhnQf6DRJ2K8qXUnZSW+K?=
 =?us-ascii?Q?vPYcgdHaQ14mwU7PzKjT4ahyUmKgjYR+c4ROgxlcoS/E4MFcJKlEygrG50Nq?=
 =?us-ascii?Q?pLu0o3q/2ywRsPbFxLToXQV6v/1sGFj+4zdA4cctMkrmiJ/u49N76jHr7SHh?=
 =?us-ascii?Q?2FqxsZi+rZyEItMsg/njT61vUZJRuhCONYaaZnPmqp+aXeKYvLlG8eiesVEL?=
 =?us-ascii?Q?i+NfTJxduB/acDiPYKuLbnWPbNmTg/gn0t8pDtutQBlCKmJwNjcgXV4zbBvI?=
 =?us-ascii?Q?Jq2h49rGksl8L7bJNE5+Zp7m0S7wFCepVqbv/kOs3cxpGa+DDAKmSHrHzrUS?=
 =?us-ascii?Q?fQjkLXk1SiNzppWQBwMSAy2P1xaseT496v2fZIuWbQPkzNFLF1UlAvadb98T?=
 =?us-ascii?Q?xGad657/c3rarP/oVKOrIgYQzu7MDZcwEkcNA3iOjg9vcn01mRpVN+Dch2jn?=
 =?us-ascii?Q?DZdUsfiARjH+dN5fMjWGSthl+E/2cgJB6Aym7hoZ3XgK0fEKOdmioPbCuUIQ?=
 =?us-ascii?Q?8j7RQWdM1G1tEfqY8YlqRMwzmCn9WElqjCcIXoALQaVeOZVButzGfeoecteo?=
 =?us-ascii?Q?LLoF51wTZuM50Wpc9tui1E4fOVMNGimsQV+hys4E+1mtINA2Mlnx50GWb3qg?=
 =?us-ascii?Q?3GydHUtIhSyNWE10BWgYRZVECmNnvoUXtBw2fjJSmeX3o2R1ZoemMPTLXToT?=
 =?us-ascii?Q?GgsRQ8O3jC1RrrgOK0kDjoDTgVZcySbTv0qEQVseLxR0ce2oMOKHc70tHZWe?=
 =?us-ascii?Q?9PFAyam+87PlSAZM5kVYeh7PBkxIzdFIjnThNlUk0KrqxbJ0XJUKg3tFuce9?=
 =?us-ascii?Q?GbK3pwC1THBJJE+phh0RWKWR5QrUfDMij8mYLq1Nmn0N5JdjQqqrzgIS6hkQ?=
 =?us-ascii?Q?1HXVAo7xhq8Pan+hvd49V794hgiNmFNAprgIcn/ys8qcButoxoEU3ARv+DPt?=
 =?us-ascii?Q?f9mRXVi9V93DyJzGUNDXCSJ+hvVAlSjVhHqT6sW82uyHAtGJJo/miXs+Dox/?=
 =?us-ascii?Q?AFMy+f/5Vm1QT4s12lNZwvar9LqZr/JAU3VH8Fkrzo+gFYRSseFtojSxFtY6?=
 =?us-ascii?Q?+zXBpP5QhkzGnrsQXyH97turK8yk/iQalczemjTLDTawFs9QK4rYbRvxrpw4?=
 =?us-ascii?Q?DR+n9gfgYrpnc9aFRuGK/Ki3GJzHYrIQkff+7vEfie88MNaJ+wn1DOQtwVgr?=
 =?us-ascii?Q?vGJNP3jhKKVKHpkjsc1XqO6JGckKmpazmYzIRbWmVbcypTHBxvc4UyI2SvHU?=
 =?us-ascii?Q?joaYwPQEidxjngjYXQhldipooX57PMfH0H/iNdi5Jw+Sp3e/4bZ5coH/+/A7?=
 =?us-ascii?Q?qYxM9A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed00a6b0-738a-42bf-2636-08db4b0415ba
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 11:55:12.0966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gaRMOLeRlYJt5fvnvRYEfR5KULAHfg4Lsmatq1YIlzkr3sxb3NmK756BK6WXoBWOHhkU4t4wDqdvoEQgvPF/IfuL6mF92620kkjD9/BcsF4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR13MB4721
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 02, 2023 at 03:10:53AM +0000, Ratheesh Kannoth wrote:
> Hi Simon,
> 
> Thanks for your review. Please find replies inline. 
> 
> -Ratheesh
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine.com>
> > Sent: Wednesday, April 26, 2023 3:31 PM
> > To: Sai Krishna Gajula <saikrishnag@marvell.com>
> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> > pabeni@redhat.com; netdev@vger.kernel.org; linux-
> > kernel@vger.kernel.org; leon@kernel.org; Sunil Kovvuri Goutham
> > <sgoutham@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> > Linu Cherian <lcherian@marvell.com>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>;
> > Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Ratheesh Kannoth
> > <rkannoth@marvell.com>
> > Subject: [EXT] Re: [net PATCH v4 09/10] octeontx2-af: Skip PFs if not enabled
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On Wed, Apr 26, 2023 at 01:13:44PM +0530, Sai Krishna wrote:
> > > From: Ratheesh Kannoth <rkannoth@marvell.com>
> > >
> > > Fiwmware enables set of PFs and allocate mbox resources based on the
> > > number of enabled PFs. Current driver tries to initialize the mbox
> > > resources even for disabled PFs, which may waste the resources.
> > > This patch fixes the issue by skipping the mbox initialization of
> > > disabled PFs.
> > 
> > FWIIW, this feels more like an enhancement than a fix to me.
>
> [Ratheesh Kannoth] I agree, commit message convey this change as
> enhancement. But this Code change fixes a crash in driver.  We will
> modify the commit message as below in next Patchset version.  " Firmware
> enables PFs and allocate mbox resources for each of the PFs.  Currently
> PF driver configures mbox resources without checking whether PF is
> enabled or not. This results in crash. This patch fixes this issue by
> skipping disabled PF's mbox initialization. "

Thanks, much appreciated.