Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 13:07:01 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
CC:     <linux-kernel@vger.kernel.org>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] reset: mpfs: select AUXILIARY_BUS
Message-ID: <20230502-uneven-configure-0f7e322e7a5c@wendy>
References: <20230502102041.1418397-1-p.zabel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="FiooAKBTGpfrY2OE"
Content-Disposition: inline
In-Reply-To: <20230502102041.1418397-1-p.zabel@pengutronix.de>
Precedence: bulk

--FiooAKBTGpfrY2OE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 02, 2023 at 12:20:41PM +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>=20
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Cc: Daire McNamara <daire.mcnamara@microchip.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  drivers/reset/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 6aa8f243b30c..086cb23debba 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -154,7 +154,8 @@ config RESET_PISTACHIO
> =20
>  config RESET_POLARFIRE_SOC
>  	bool "Microchip PolarFire SoC (MPFS) Reset Driver"
> -	depends on AUXILIARY_BUS && MCHP_CLK_MPFS
> +	depends on MCHP_CLK_MPFS

I think this `depends on` makes this patch moot, as MCHP_CLK_MPFS
selects AUXILIARY_BUS. I don't really mind if it's switched to select
for consistency, or removed entirely though, so:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> +	select AUXILIARY_BUS
>  	default MCHP_CLK_MPFS
>  	help
>  	  This driver supports peripheral reset for the Microchip PolarFire SoC
> --=20
> 2.39.2
>=20

--FiooAKBTGpfrY2OE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZFD85QAKCRB4tDGHoIJi
0uYSAP97Y1L2HznR1GU6MUA7Awr9Vihe4woT5Q9C/iTVb5LtuQEAlaXhApfu+UB/
H6wPtKdByxE8X3C2zqFRVocHRDT7UwM=
=23wo
-----END PGP SIGNATURE-----

--FiooAKBTGpfrY2OE--