Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230501190602.86281-1-jandryuk@gmail.com> <ZFAWaQbDR1_r5jf-@codewreck.org>
In-Reply-To: <ZFAWaQbDR1_r5jf-@codewreck.org>
From:   Jason Andryuk <jandryuk@gmail.com>
Date:   Tue, 2 May 2023 08:03:15 -0400
Message-ID: <CAKf6xptMDRVet-C_1H7txPb_J_xq+XnNxwrQVbNWL_2JGnbHgw@mail.gmail.com>
Subject: Re: [PATCH] fs/9p: Remove INET dependency
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@kernel.org>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        v9fs@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Dominique

On Mon, May 1, 2023 at 3:43=E2=80=AFPM Dominique Martinet
<asmadeus@codewreck.org> wrote:
>
> Jason Andryuk wrote on Mon, May 01, 2023 at 03:06:00PM -0400:
> > 9pfs can run over assorted transports, so it doesn't have an INET
> > dependency.  Drop it and remove the includes of linux/inet.h.
> >
> > This allows configuring 9pfs over Xen with INET disabled.
>
> Good catch.
> Could you add depends on INET to NET_9P_FD in net/9p/Kconfig?

trans_fd.o builds without INET and without UNIX.  Looks like trying to
use either TCP or UNIX sockets would lead to runtime errors, but it
also supports generic file descriptors.  That could be useful for
someone.   Since it builds, would it be okay to leave this patch
unchanged, or do you still want the depends added?  Leaving the patch
unchanged provides more flexibility, though the runtime errors may
surprise users.  While I built a Xen kernel without INET or UNIX, that
is an unusual scenario.  Typically INET and UNIX sockets will be built
in anyway even without a depends.

Thanks,
Jason