Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6754796rwr; Tue, 2 May 2023 05:16:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5uvh5yAGtRY5lje2Nohr4ZIprGnFE8AyXpaIro1PQ/Q2gKkm0mYPNC4CVUH5C2GScdp0TV X-Received: by 2002:a05:6a00:b51:b0:63b:7ae0:fde9 with SMTP id p17-20020a056a000b5100b0063b7ae0fde9mr26090315pfo.20.1683029761070; Tue, 02 May 2023 05:16:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683029761; cv=none; d=google.com; s=arc-20160816; b=jt7D3KVAMIUJ1cjJcunIVoKqSUOgrJW35XJpEL2oTM2lTuO63fmpPJOtPRSDwf+VF6 0BrggtF+44u1jfmJR5HY8gnGPyAMjv+IXcqh7+ah4iHYyiVCmRcQ2ljNFyGHsJlVrLqI mB0iiK+73Dt4Jinhca+cPrjOL6zM3H1s9mwodtAvNqP6PGfxcrz9eKHXChM8lw7u74Yz Zok8lyZIRhNHPlCTtl02gn3VZnW5fb3C8B3ZCd8hoe3NsQfOIcRS/LLxvm1yGgjCeyaA W8rVeE8Hibvsyo+IARG+PyjF4seYP+RbhAjQaYWZXY7VmIanPdW9PKOEpTmugSSpn8yG gTgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+IGPXg+qv7U5cBSHTJdEeb3CehKswgix6IZ8XQVyrl4=; b=0HVMLf9uczofXWN7Ic/QOzpFTpDkvQai14YcT1lDbvob/oCM7SfN0c2UJjJfB7GG4/ s81XujyfuE+fI7FbXn9xr45zNvmoOuJiinC3p1ZiEgfxSBl1PhaDDRsoutDxNUGm3iSi NRORt5d4A7wONDFwwgINC9LLNN+7MPWlfimfKlocMvPSsfNTW/pgFHyy0yCH2KAi7VtD nE0ptKztnq2w9YixczhPAPTW8Go4u44A2oq5KPIL6PIE3YtiZkc2sG1wrFhRRUQ2fGkG omlHjf2+44hev9iVGt5sMaltbFuIhtidIuhCznt50M2KApL/VbHmHNkuTqK9RTOSrZJb /l1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LUr2TB5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y28-20020aa78f3c000000b0063d32d1c0b9si30001791pfr.125.2023.05.02.05.15.47; Tue, 02 May 2023 05:16:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LUr2TB5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233870AbjEBMOk (ORCPT + 99 others); Tue, 2 May 2023 08:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234101AbjEBMOh (ORCPT ); Tue, 2 May 2023 08:14:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFE7310CE for ; Tue, 2 May 2023 05:14:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FD406239C for ; Tue, 2 May 2023 12:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BF28C4339E; Tue, 2 May 2023 12:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683029667; bh=eW8ke/Mn63RwEWiRtAK4MYQo9cCYrdx9UJrJoCRyfio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LUr2TB5A4aCRJCzXL676+jAIODvVN675E6ZSu/S7GHis9y/p8lARt0qFy+I2Dly7r n6WObxQprjldtEt1Yq1dgVJSj3rXO1XpdWGAWKQwNDrTiYZOCv+tVLnglYQVo9lWIG bE2JZtlgAequYMnsplhzbriuFBeh5mN+6UHJcI77jtq98ff8IhFuemBEnhEvPN2mRE 8ick2wurBRKX6xgRDQninOVYiVPQ0x0RdlvM1fbgaIq6f1Axf4Qjo1Kxi2eFvN0Swx R4vpJjLNKHij1rqvLKDte+Ahtd9JUf39VKgBpO8+24GSu/uG2NW0MgBxNxt5KXnwqL zT5lAfSTwbcYw== From: Will Deacon To: Fangrui Song , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Ard Biesheuvel Cc: kernel-team@android.com, Will Deacon , Bill Wendling , Nick Desaulniers , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] arm64: lds: move .got section out of .text Date: Tue, 2 May 2023 13:14:16 +0100 Message-Id: <168302779125.294142.11817759835961907319.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230502074105.1541926-1-maskray@google.com> References: <20230502074105.1541926-1-maskray@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 May 2023 07:41:05 +0000, Fangrui Song wrote: > Currently, the .got section is placed within the output section .text. > However, when .got is non-empty, the SHF_WRITE flag is set for .text > when linked by lld. GNU ld recognizes .text as a special section and > ignores the SHF_WRITE flag. By renaming .text, we can also get the > SHF_WRITE flag. > > The kernel has performed R_AARCH64_RELATIVE resolving very early, and can > then assume that .got is read-only. Let's move .got to the vmlinux_rodata > pseudo-segment. > > [...] Applied to arm64 (for-next/core), thanks! [1/1] arm64: lds: move .got section out of .text https://git.kernel.org/arm64/c/0fddb79bf283 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev