Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c384fc1-4f4b-2ef1-2349-060448f81be6@amd.com>
Date:   Tue, 2 May 2023 08:32:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] drm/amd/display: mark amdgpu_dm_connector_funcs_force
 static
To:     Arnd Bergmann <arnd@kernel.org>,
        Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Cc:     Stylon Wang <stylon.wang@amd.com>,
        kernel test robot <lkp@intel.com>,
        Arnd Bergmann <arnd@arndb.de>, Alex Hung <alex.hung@amd.com>,
        Qingqing Zhuo <qingqing.zhuo@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, Hans de Goede <hdegoede@redhat.com>,
        Aurabindo Pillai <aurabindo.pillai@amd.com>,
        Hersen Wu <hersenxs.wu@amd.com>,
        dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        Wenchieh Chien <wenchieh.chien@amd.com>,
        David Airlie <airlied@gmail.com>
References: <20230501143213.1571373-1-arnd@kernel.org>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230501143213.1571373-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDRWNzJVakF1TVhFZ2NGbEIrWWlDUWFjNXlVNWVEQVFnVU45bmFsNHdiZnFj?=
 =?utf-8?B?VHVxWW9rN1p6WWFoT0tJWGpwMFpKdm0zMEpuMm53VjQvbkcxYlRxcTFBNW1B?=
 =?utf-8?B?djE0NVh6QXFhY3BTVTFYeWlZYitpem14aisvNUJ2SDFleDZpQzhobzdiRk1n?=
 =?utf-8?B?dVcxOEpLZEVsc0FJMWVCeHI4YkZvNVZaYThYY2xidFVINjlhUUlwcXlDUFd1?=
 =?utf-8?B?bXpIdjlKWm0xajFhMVp0OGh6bmRlSjljdGdlZFVPQ0hSaHRJVmpYOHdlbE1a?=
 =?utf-8?B?YWJBWlFCNXJFZGs4ekcrOTg4Z1F6RUFGMXNuU2Qvc0lHTFBZemtUVlI4aElK?=
 =?utf-8?B?Zm41ZkZQY1RWZlNGY0JPT0UrSGNRaXpuU1JoQVh2bEhIakhGdmo0cTZWaXdZ?=
 =?utf-8?B?Z2NkNVdubEtObmxObk5pZmxhUTZSdnpVVHNxd2RMVFFPZFdOWEhDMmVRMm1v?=
 =?utf-8?B?cDVBYjEwc3FXUU9LbS9WTDBzT3JnVkN0OVdpSDJFZEZhVGgwMnkwQmpHOERU?=
 =?utf-8?B?M1hOR3N2MXRqc3hJQlMrTHYxMTgvcE9xTWZFYkl3WU5XK3NsbW5WMjBnczhJ?=
 =?utf-8?B?YUE1THBvUm40NDlIblVrTFBBSFhZUGtuUUUzOW92Q0Rwa3NKQ0tQMENlTURr?=
 =?utf-8?B?elM3aUlCMmFKY0g0bnhrWExxOUVVcnp2UGFqajdCNzdKYzNFa0NVb1VrOGR6?=
 =?utf-8?B?bzdNbjRwaHVoTHJobEQzbHFvaDNYU1Q4cUZTMjQ0WTMwanNUVWI2bG9neEQv?=
 =?utf-8?B?MjJZWG81U1NXSmJZSkRUMUlUU3BoNE1lakJ4OTl5YzlONTZsMjhPczFiUEtl?=
 =?utf-8?B?TWZuejY0elltOTFZSUtnK3pxVGZqTlFiVEMxMi9WRUEvL2YrV2gwNG1seXB3?=
 =?utf-8?B?MXl5VndCRXZEMkxiZnhYOTNTNW9QaFg4d20wN2RadHRyRWhLR1JPVHZoQzZa?=
 =?utf-8?B?dWFRc1JwbVJhOG83c2JrdG02L2lVa2ZDU0s2UTc0a0drTng4UTFad0NlMk9Y?=
 =?utf-8?B?Z2xVTE5OWkwyM2F1OW9EVTFWNmk3dnRxQnFOb0MrWEg5ZlFSejZmamVrOURx?=
 =?utf-8?B?ZGlRQ2xUdDhMMXU0RVpSK1VkZHVGYVMrQnNBMHFLVlFDeG9yWlRQNHFybmVZ?=
 =?utf-8?B?RzBDRzhrQTNHODFYaHRBM2FYNW9YNnZoRTRPNElRR0VFT0FGSEdvUHlTUkVn?=
 =?utf-8?B?SXBSOFZ3emZEMGJpMzFNNWp1MUhRQlFrMEFRWFdEVzZsSlhvZ200MmpHV1Z3?=
 =?utf-8?B?WWNMeEVQWjBsZEkzSmllUHZFYjJuMGhLaUhYZWE4ZkdteU45Ky9hdVRZMzZM?=
 =?utf-8?B?MEZxemRrWHRBei83ZTF3ZHpiNkE2WjNLYVdLTjR1Uy8rR0FIVm1zc1NYaTZR?=
 =?utf-8?B?M1NmdjV4b1RibVY4U01MRHR0endZN1JBaTZoR3lQeU5qU0ZqNGEvOG1KNGJs?=
 =?utf-8?B?YlJJVlQ1eGZMc1ZFYm4zUFF0MElKWVpIYS94T2h1eGxITHZyamZuZlkwTjVi?=
 =?utf-8?B?cnR0VFhtbXhnM2Y2VER2ZGNMTVM4SW5MSHlYY25YbU9HUjBGVGVEN3BHU0ZL?=
 =?utf-8?B?RERCV0tubGZBN0lENVZwWmxjbGJRdWFyaktUTUVwZGp1ZkZMbzgwWmd4Z1k5?=
 =?utf-8?B?UW1Tanl5bUExQ0hQd3F1Vkk2MTQxMlVOV0dRN2ZGYW1UR2xabkhRMUkwWk10?=
 =?utf-8?B?RjFya2hSc3g3dUZZaEZGZnZpQ1pjZVBhT3I1T2NjRFIvOFNSZ0ZxQk5qQlc3?=
 =?utf-8?B?MmlpNjQ1UHVKTHhPNTFFV3lETUhrSnRPaElVK1hIdk0zb3ltTXhBeXNZQStt?=
 =?utf-8?B?NjBJbHVOSnliYWpPdUJpU3B1TmR2cHJmNHFoOW4wTEk0MUpaZEdZU1ZyOFdo?=
 =?utf-8?B?U2VQRW85ekppd3hvWXFqNGF0VXIraVBZK3dMenVNSlh3bHZKTUpMSm9RcEdE?=
 =?utf-8?B?NEpvNjZibkJNcUF2WE1qQmdndmVQQnp1N0hReWY4bUFiVHJUeFhyUDM5OEsv?=
 =?utf-8?B?NkVFcjdnb1hSTEtNdWoweGVKYTYyL2d4UmY4eDRVL2s2SlplVjRZbTJLTmV0?=
 =?utf-8?B?SGZQWUdYYmRuNlFvL3V2UXg0WWd4YVBkQWhOYjhBZnB4VXdyTjVWak9kUU5X?=
 =?utf-8?Q?KLgW75sj1our9xBSrd7yBmphZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 188ae03e-2963-4097-86e1-08db4b0919ff
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 12:31:06.8586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Re95nrFukeyINPxaBQtEZHh8K6nUJPJAHUEZBJq28ERZZJqvipVlUpmUU/GR5jFilmLoR2QXZwVb/POky6A9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7147
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/1/23 10:31, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A global function without a header prototype has made it into
> linux-next during the merge window:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6339:6: error: no previous prototype for 'amdgpu_dm_connector_funcs_force' [-Werror=missing-prototypes]
> 
> Mark the function static instead, as there are no other
> callers outside this file.
> 
> Fixes: 0ba4a784a145 ("drm/amd/display: implement force function in amdgpu_dm_connector_funcs")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304251640.JClqTim9-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks!

> ---
> This was previously reported by a bot for the drm-next tree but remains
> broken in linux-next-20230428. Sending it out as I needed this fix
> for my local builds.
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 3647d21d688f..2bbb2988942d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6336,7 +6336,7 @@ amdgpu_dm_connector_late_register(struct drm_connector *connector)
>   	return 0;
>   }
>   
> -void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
> +static void amdgpu_dm_connector_funcs_force(struct drm_connector *connector)
>   {
>   	struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
>   	struct dc_link *dc_link = aconnector->dc_link;
-- 
Hamza