Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 14:54:52 +0200
From:   Daniel Wagner <dwagner@suse.de>
To:     Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Subject: Re: [PATCH REPOST blktests v2 2/9] nvme: Do not hard code device
 size for dd test
Message-ID: <p5eminun5jsblyb3k5nycsrefpzlzqlrihozlz3ezh65hcsfnu@pxhvomc3qwmn>
References: <20230421060505.10132-1-dwagner@suse.de>
 <20230421060505.10132-3-dwagner@suse.de>
 <z3lbxnnewuwnozrme27okchaxytt7zegj4emgpt4gmewsvcr5k@aordfdu7tai4>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <z3lbxnnewuwnozrme27okchaxytt7zegj4emgpt4gmewsvcr5k@aordfdu7tai4>
Precedence: bulk

> > -	dd if=/dev/urandom of="/dev/${nvmedev}n1" count=128000 bs=4k status=none
> > +	size="$(blockdev --getsize64 "/dev/${nvmedev}n1")"
> > +	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
> > +	count=$((size / bs - 1))
> 
> Do we need -1?

Not really. My aim was to just to make it test case a bit more
reliable. The original test didn't fill up the disk either.

I am going to drop it.