Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 10:02:07 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     Christian Borntraeger <borntraeger@linux.ibm.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jens Axboe <axboe@kernel.dk>,
        Matthew Wilcox <willy@infradead.org>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Leon Romanovsky <leon@kernel.org>,
        Christian Benvenuti <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bjorn Topel <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Christian Brauner <brauner@kernel.org>,
        Richard Cochran <richardcochran@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        Oleg Nesterov <oleg@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>, Jan Kara <jack@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Mika Penttila <mpenttil@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        Dave Chinner <david@fromorbit.com>,
        Theodore Ts'o <tytso@mit.edu>, Peter Xu <peterx@redhat.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v6 3/3] mm/gup: disallow FOLL_LONGTERM GUP-fast writing
 to file-backed mappings
Message-ID: <ZFEJz4s/95t1I4+7@nvidia.com>
References: <cover.1682981880.git.lstoakes@gmail.com>
 <dee4f4ad6532b0f94d073da263526de334d5d7e0.1682981880.git.lstoakes@gmail.com>
 <fbad9e18-f727-9703-33cf-545a2d33af76@linux.ibm.com>
 <7d56b424-ba79-4b21-b02c-c89705533852@lucifer.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7d56b424-ba79-4b21-b02c-c89705533852@lucifer.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VPW+z/1M1uAKHrO/05aotVZFipi0fvpSE4hEh+S+Vm9ksXboWTDM3K+qmdfh?=
 =?us-ascii?Q?5XcJkZXEMWSpYw4MExxt5fJIaySR720b6mwObrt1bxneUPFehj2e0DC70Fb1?=
 =?us-ascii?Q?66U429YmE0t5DZBlVqyjLw0UqrlA0NNmY1AMT66kM44QtRVPan50Rkz7mUIF?=
 =?us-ascii?Q?IoUrDSBKIAEbTXSUsEApgTYlu/wcBI/Us8Kys0hO/lNHa7LCUDZb/QJMInDk?=
 =?us-ascii?Q?GV9CMgZCutnSzbNPTtYVG4+wN5sJ1DAMWClgAbltCDYkKuXtLHPnwezKFItQ?=
 =?us-ascii?Q?sxR5rAhEhfcUjsVeUmkZEaYiCuDDaDaBHlqaxR/9fRBw9UwMdUZaYfQQ1gyF?=
 =?us-ascii?Q?f7xII1DY85eYcJKpdmJP1ZY0dt0M2iKNEarbkBaNuEw2YhKadgRzY0Oanl63?=
 =?us-ascii?Q?yoU4lPXk2HPZnqpimkfS0m1oUMHG3K5Z4VfhzYLwZ5HmDl88BIeI5lm65ItW?=
 =?us-ascii?Q?GAbd2Hog/MVZPl799YGwyycUVrQTT6Z3DwbcuvK5UV1WAnzP7eW/Dvh1atDx?=
 =?us-ascii?Q?Yq7Y/W/oKpl1TUbBax37L4HzG/Tt10dJEMoUw1PNZqKnRGfeq5titQ/u+RgV?=
 =?us-ascii?Q?ZpX6Dt3aZ9aw3K0nF7durUazCAGSaDLC64V6ptDGVtzDIoxJtEBzuSGdQWLy?=
 =?us-ascii?Q?HnWEknDwgLm0PQZPHykfCqA7flRLCbKFTo2kgHk3su1eb5PwLcdftq5OvNpZ?=
 =?us-ascii?Q?gxXWyMI0WU5ea8ZoYcZbNkSBUHGuSgqCkixOVJ/LL1JP0egWq9SH/LbP1s6X?=
 =?us-ascii?Q?BMjjkk4Uabk2IgBoIDQZY1RI0CScBIR1Sg8qExyUPXS8YPMBcB/iQND4StGe?=
 =?us-ascii?Q?nNUCtifvpix4GccgVxYBasRqy1kzL6zIUn049AhdJU5qBki7CdrWt/cZEQ/e?=
 =?us-ascii?Q?CwuqE9Nf4ILSI07zUE9MOxGaAADiXTdKg6wO7Nup20U1y26sbxYjasVdrTlD?=
 =?us-ascii?Q?5LWykP39ngiU0zjmpqCzkkxj5tIKtM0ptx6ybRXNxvSJvMzJNks6TSTZmXwy?=
 =?us-ascii?Q?gWTFSPVjR/yli/oLh/565WaGcYcQQXgq+LOTdnA4IE67v7vprHgKrSOpnjS7?=
 =?us-ascii?Q?4yxeSW/DbD5nZzQUffgmVLV+mqlDgNUUsSei6iQVLVaxzUNNnFpqh4hdgpDm?=
 =?us-ascii?Q?T19RWmeoenFigqLtEpD3uDcwIFPBrYzcnEMLWXcrXWGkZ2xnidRl4sCeEIbd?=
 =?us-ascii?Q?m5frk/l8D6BEnJYEOpQPzBtlQepTA0l0+tn8giAEu+jKWO6W4a7cqhG3zlE2?=
 =?us-ascii?Q?C0bTHDkm5EKQo7lG88aqr82GMgsNCWjufjk+YLClZXRIgQ8A39PUY1sXv8a0?=
 =?us-ascii?Q?q57p4qe2Hakg7pxaxFYR7WjrznQNRFm/2C2lumsDxioYiqIVbn3n4oOexSqG?=
 =?us-ascii?Q?kTCdeuTxDm+iEgtFtqhoruYGmBMSDHBoIkdXOQKQPtjz0+EscdnKuOqPGczY?=
 =?us-ascii?Q?gN/nafrvIZWMlBQnz78UVnS9MZlgIsMJJIKkAaPzuY+grI7HF50GO20jGB77?=
 =?us-ascii?Q?p0zo0Bx+UTzcLabqPmkasRbXk730fVorb0bowsfMHHqRCW4YoEP2Lbixh4Qj?=
 =?us-ascii?Q?xuyLNFzzm48I+pfE+6Dc2nZGWmZzXO/x8XAYg1GP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc7c1fe2-a315-4db8-72cf-08db4b0d6fe4
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 13:02:08.9331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qKy0mJq9ChuheWxZ+40dlOzGlkIDxcSGYSWvjwkXjLRf9Gv5YcQUE8qeKIx42Omq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4573
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 02, 2023 at 01:54:41PM +0100, Lorenzo Stoakes wrote:
> On Tue, May 02, 2023 at 02:46:28PM +0200, Christian Borntraeger wrote:
> > Am 02.05.23 um 01:11 schrieb Lorenzo Stoakes:
> > > Writing to file-backed dirty-tracked mappings via GUP is inherently broken
> > > as we cannot rule out folios being cleaned and then a GUP user writing to
> > > them again and possibly marking them dirty unexpectedly.
> > >
> > > This is especially egregious for long-term mappings (as indicated by the
> > > use of the FOLL_LONGTERM flag), so we disallow this case in GUP-fast as
> > > we have already done in the slow path.
> >
> > Hmm, does this interfer with KVM on s390 and PCI interpretion of interrupt delivery?
> > It would no longer work with file backed memory, correct?
> >
> > See
> > arch/s390/kvm/pci.c
> >
> > kvm_s390_pci_aif_enable
> > which does have
> > FOLL_WRITE | FOLL_LONGTERM
> > to
> >
> 
> Does this memory map a dirty-tracked file? It's kind of hard to dig into where
> the address originates from without going through a ton of code. In worst case
> if the fast code doesn't find a whitelist it'll fall back to slow path which
> explicitly checks for dirty-tracked filesystem.

This looks like the same stuff David was talking about, a qemu guest
with VFIO backed by a filesystem file..

Broadly though, arch kvm code should not call pin_user_pages().

Either it is KVM focused and it should use the shadow table and it's
existing mmu_notifier synchronization scheme

Or it is VFIO focused so it should use mdev/etc and have an unmap call
back.

I'm not really sure what this is for though..

Jason