Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1682985701-19914-1-git-send-email-zhouzhouyi@gmail.com> <783a1e86-d625-4d8b-9b7c-0531b11b9290@paulmck-laptop>
In-Reply-To: <783a1e86-d625-4d8b-9b7c-0531b11b9290@paulmck-laptop>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Tue, 2 May 2023 21:50:01 +0800
Message-ID: <CAABZP2wTpG1dCU8GNTuiyj+2zkHxWgOF3j3Mqjk5BUgS6KADZA@mail.gmail.com>
Subject: Re: [PATCH V2] rcu/torture replace wait_event with wait_event_idle
To:     paulmck@kernel.org
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org, lance@osuosl.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 2, 2023 at 9:40=E2=80=AFPM Paul E. McKenney <paulmck@kernel.org=
> wrote:
>
> On Tue, May 02, 2023 at 08:01:41AM +0800, zhouzhouyi@gmail.com wrote:
> > From: Zhouyi Zhou <zhouzhouyi@gmail.com>
> >
> > In kfree_rcu_test, kfree_scale_shutdown will be detected as hung task
> > if kfree_loops is too big. Replace wait_event with wait_event_idle
> > to avoid false positive.
> >
> > Tested in the PPC VM of Open Source Lab of Oregon State University.
> >
> > Suggested-by: Paul E. McKenney <paulmck@kernel.org>
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> Good catch, thank you!
>
> However, this commit beat you to it:
>
> ef1ef3d47677 ("rcuscale: Move shutdown from wait_event() to wait_event_id=
le()")
You are very welcome ;-) Still, this is a very fruitful learning
process for me ;-)

Cheers
Zhouyi
>
>                                                         Thanx, Paul
>
> > ---
> >  kernel/rcu/rcuscale.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
> > index 91fb5905a008..d99c586939d1 100644
> > --- a/kernel/rcu/rcuscale.c
> > +++ b/kernel/rcu/rcuscale.c
> > @@ -771,7 +771,7 @@ kfree_scale_cleanup(void)
> >  static int
> >  kfree_scale_shutdown(void *arg)
> >  {
> > -     wait_event(shutdown_wq,
> > +     wait_event_idle(shutdown_wq,
> >                  atomic_read(&n_kfree_scale_thread_ended) >=3D kfree_nr=
ealthreads);
> >
> >       smp_mb(); /* Wake before output. */
> > --
> > 2.34.1
> >