Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 16:46:17 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Dominique Martinet <asmadeus@codewreck.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, v9fs@lists.linux.dev,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] 9p: fix ignored return value in v9fs_dir_release
Message-ID: <ZFEiOdK0/UxKiPQQ@corigine.com>
References: <20230427-scan-build-v1-0-efa05d65e2da@codewreck.org>
 <20230427-scan-build-v1-1-efa05d65e2da@codewreck.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230427-scan-build-v1-1-efa05d65e2da@codewreck.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pgFkRkjIY43GUT8llDzLtsT/FdNefwY0Jx5wJdpTfzgVOVWuqisdcW0NaAMb?=
 =?us-ascii?Q?BidJ4ZJc0tVnBV+ox76RHj1LL9xCriRetIBET9uKbgkYU6RH+dJ1f76c5niT?=
 =?us-ascii?Q?BnNzAlN7Ct0hByCIr9g8kCjj3JUUY0SW2xUzM1BsvDk6oFCptRyLRqyOXwfz?=
 =?us-ascii?Q?PRT5EN5VKeOBVSqC12w/Jq6vFr8JIRGRXT/gLv1ZhXYo1oY6+ysQdvFzTmIj?=
 =?us-ascii?Q?oEEq7KTJJmZXBVMUWV70MtQR9bk/NIc/MNAkgyCjkL+Dcy/eN16e0nMQ2QVF?=
 =?us-ascii?Q?THoTPUcrV5RNczUtA9JquvvgyfhXwAbKnXNiYiZb8yo87r33+Kdovn+LWqSI?=
 =?us-ascii?Q?A/lOGj7pJcB53xfrcnR8VdwDmRns/+rUBl+BM8iRiLQaGfAwzNAOvas/ZVDE?=
 =?us-ascii?Q?7ctzdECjvzBuUcNYTxytyKgz//mC0XbdnF7k7jm78bpr06BfnQc9+PIDipzp?=
 =?us-ascii?Q?QJjBTI6DczaZhKwicOGY2IbmWby37buonp7GeIHNaLv723J7X8lbykniVgAv?=
 =?us-ascii?Q?/xCBaOWjbeElrQimbiHNVO02e1WPoP8x9UpBGpHkDpAo5VFTV3cwC5xj2qTR?=
 =?us-ascii?Q?jto3xBs2K/MSbZX7IXgNYVUgU7Z0D+ASMCmPwrEU2PnXEmERFKxF1tC8zLJo?=
 =?us-ascii?Q?ZpeTQuF4UQ32v90knvgS4WpUqpFsKwls3qfwKROzMnO0tMCAzwRhW+R0mlL5?=
 =?us-ascii?Q?0OwukcVMBldDNCiwYibW2T+XV/Nh0NI8wyaJmoor7cgh24i6aaLfaLalWTPf?=
 =?us-ascii?Q?hT/Z5HYtPRN79YiaPC3hj3OfY2M9tjP9AlT0AfOhllGdPFSxoWz2tW7zs0i/?=
 =?us-ascii?Q?cAAPl5ofdjCs/+r9uxk5c0Bf1WvrYgwCohx/jS5Ol7UaAe1txz29y9QCTaDm?=
 =?us-ascii?Q?nhUPTLL0iik6ndLtTqicbqy8EQRqPRnerWTiEXEKbVgpQgtYA6gKPdnLt4dj?=
 =?us-ascii?Q?Dz3plxDMqocptojwEHHL5lMhCFjyfB73oAvlTFfK87P0RVt04CwWXMJ8ddBj?=
 =?us-ascii?Q?JZM/x3ujsm1y58ejQV4sgFVQeOhNg/Uc/7//HM8jaqsJnjlHQ+AtG7WmSLML?=
 =?us-ascii?Q?ca00tqF9Jg+dQZ4rfakeix0k3mqs+XvS0EFAiIUTn/llS4RPE2p3GPkZGUnc?=
 =?us-ascii?Q?tNYSv5bLiLKFgl4JtgIXd9GIOjxbcY2+SK2W+64mJCmeJh2RiblTmRnfH6ml?=
 =?us-ascii?Q?63UOoKmP0htgGYTFQFsiwt27Au6VSoB+MPAQqZdQ7SA3Nz8OEF0ZZsmeC/1/?=
 =?us-ascii?Q?RZJ3CzsuMfKI3UF74eSnFHUiifpB1Q9pk0TvqXAPhbFcITFkJjPJY6CxU8RN?=
 =?us-ascii?Q?hHcFNw4g+s9etxfcSc4g/xMOHmFyotGLLaFwZdyjPpW9nV00GEHbECCIgA8J?=
 =?us-ascii?Q?v2j5JFlVR9UnGGSxwdv7QavLv3i3pM21ILuHdx4cFz/M05VQP+cvHyy08NTc?=
 =?us-ascii?Q?ydXlkr1Q0agl0OtB81ODEl4YI4uNg63ch1vtDLiOeXnQAIcLIcsUbXz8vXRU?=
 =?us-ascii?Q?mRcK0utcd2emQR4gO+CFX6H7UJiOmg6ecr23X0QEXDZbEPA6jiaCEpcAaXYC?=
 =?us-ascii?Q?beATP7Q+JbIt4yPKUr96ZJqISJzvpoRKxU1xJy3Qq/YlH/SsMm7auvgpyQt5?=
 =?us-ascii?Q?zTWxHoEEpMXvs7Va8Z1Y/Bx+/13gAfOszzhqZNiEJbAaxVu2DDurgpey318f?=
 =?us-ascii?Q?ksY3aA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2953b82b-9064-4536-99f0-08db4b1c0086
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2023 14:46:24.6114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /pfJjh6iu6GxOuUqi2ipeJq8sKhBqmZGDqZKY3djG67R0uPRvQsaEL59p887lZNqkAU7RmN3nhqnjJP3wbeBkqHg8bwaUlThSxTGW+6dGS8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3648
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 27, 2023 at 08:23:34PM +0900, Dominique Martinet wrote:
> retval from filemap_fdatawrite was immediately overwritten by the
> following p9_fid_put: preserve any error in fdatawrite if there
> was any first.
> 
> This fixes the following scan-build warning:
> fs/9p/vfs_dir.c:220:4: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
>                         retval = filemap_fdatawrite(inode->i_mapping);
>                         ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Perhaps:

Fixes: 89c58cb395ec ("fs/9p: fix error reporting in v9fs_dir_release")

> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>