Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 2 May 2023 18:24:53 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Brandon Ross Pollack <brpol@chromium.org>
Cc:     Dan Carpenter <error27@gmail.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        linux-kernel@vger.kernel.org, masahiroy@kernel.org,
        ojeda@kernel.org, alex.gaynor@gmail.com, keescook@chromium.org,
        nathan@kernel.org
Subject: Re: [PATCH] .gitignore: ignore smatch generated files
Message-ID: <969f9704-6781-4bd6-a0ee-46c7110a2c93@kili.mountain>
References: <20230427023345.1369433-1-brpol@chromium.org>
 <CANiq72nxNtLvx1J-50F8D05QQjx4FBPkrhg6pysc25RL6--Zhw@mail.gmail.com>
 <CA+_b7DLoTEn6_2auTVN9Wj62ogOFXnhf7kTmh_KCZPkCBfJsSw@mail.gmail.com>
 <CALWYx-bvyzN3nGtGpLKyoayWLtzKwJGCtdFMfg=6bJSP2qYNGg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CALWYx-bvyzN3nGtGpLKyoayWLtzKwJGCtdFMfg=6bJSP2qYNGg@mail.gmail.com>
Precedence: bulk

On Fri, Apr 28, 2023 at 11:55:17AM +0900, Brandon Ross Pollack wrote:
> On Thu, Apr 27, 2023 at 8:20 PM Dan Carpenter <error27@gmail.com> wrote:
> >
> > Thanks for this.  To be honest, I hadn't remembered that Smatch
> > still generates trinity_smatch.[ch].  I would prefer to just delete that
> > stuff.  Another idea is maybe Smatch could put everything in a
> > smatch/ directory?  That feels like maybe it would be nicer?
> 
> Sure, that'd be great as well.  I'm pretty sure that smatch outputs
> these files from whatever directory you run from, that's why I did the
> overall pattern rather than a path pattern.
> 
> Should we just patch smatch to not output trinity* files and output to
> a directory and change this patch to mask out the directory?

I've deleted the trinity stuff.  Let's just apply the rest as-is.

regards,
dan carpenter